All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] IPv6 anycast refcnt fix
@ 2007-02-25 12:04 Michal Wrobel
  2007-02-26 23:36 ` David Miller
  0 siblings, 1 reply; 4+ messages in thread
From: Michal Wrobel @ 2007-02-25 12:04 UTC (permalink / raw)
  To: netdev

This patch fixes a bug in Linux IPv6 stack which caused anycast address
to be added to a device prior DAD has been completed. This led to
incorrect reference count which resulted in infinite wait for
unregister_netdevice completion on interface removal.

Signed-off-by: Michal Wrobel <xmxwx@asn.pl>

--- linux/net/ipv6/addrconf.c	2007-02-22 19:46:27.000000000 +0100
+++ linux/net/ipv6/addrconf.c	2007-02-25 00:22:37.000000000 +0100
@@ -456,6 +456,8 @@
  			ipv6_dev_mc_dec(dev, &addr);
  	}
  	for (ifa=idev->addr_list; ifa; ifa=ifa->if_next) {
+		if (ifa->flags&IFA_F_TENTATIVE)
+			continue;
  		if (idev->cnf.forwarding)
  			addrconf_join_anycast(ifa);
  		else


^ permalink raw reply	[flat|nested] 4+ messages in thread
* [PATCH] IPv6 anycast refcnt fix
@ 2007-02-25  0:13 Michal Wrobel
  2007-02-25  0:57 ` David Miller
  0 siblings, 1 reply; 4+ messages in thread
From: Michal Wrobel @ 2007-02-25  0:13 UTC (permalink / raw)
  To: linux-kernel

This patch fixes a bug in Linux IPv6 stack which caused anycast address 
to be added to a device prior DAD has been completed. This led to 
incorrect reference count which resulted in infinite wait for 
unregister_netdevice completion on interface removal.

Signed-off-by: Michal Wrobel <xmxwx@asn.pl>

--- linux/net/ipv6/addrconf.c	2007-02-22 19:46:27.000000000 +0100
+++ linux/net/ipv6/addrconf.c	2007-02-25 00:22:37.000000000 +0100
@@ -456,6 +456,8 @@
  			ipv6_dev_mc_dec(dev, &addr);
  	}
  	for (ifa=idev->addr_list; ifa; ifa=ifa->if_next) {
+		if (ifa->flags&IFA_F_TENTATIVE)
+			continue;
  		if (idev->cnf.forwarding)
  			addrconf_join_anycast(ifa);
  		else


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2007-02-26 23:36 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-02-25 12:04 [PATCH] IPv6 anycast refcnt fix Michal Wrobel
2007-02-26 23:36 ` David Miller
  -- strict thread matches above, loose matches on Subject: below --
2007-02-25  0:13 Michal Wrobel
2007-02-25  0:57 ` David Miller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.