From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Uwe Kleine-König" <ukleinek@kernel.org>
Cc: Hal Feng <hal.feng@starfivetech.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor@kernel.org>,
Emil Renner Berthing <emil.renner.berthing@canonical.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Paul Walmsley <pjw@kernel.org>, Albert Ou <aou@eecs.berkeley.edu>,
linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v23 1/2] dt-bindings: pwm: opencores: Update compatibles, examples and maintainers
Date: Fri, 16 Oct 2026 15:54:07 +0200 [thread overview]
Message-ID: <f052b1b3-87fe-48e6-aa02-df47517ef8d0@kernel.org> (raw)
In-Reply-To: <atH4DnTWVZPkaO2C@monoceros>
On 16/10/2026 14:55, Uwe Kleine-König wrote:
> Hello Krzysztof,
>
> On Thu, Oct 15, 2026 at 12:27:16PM +0200, Krzysztof Kozlowski wrote:
>> On Thu, Oct 15, 2026 at 12:20:54PM +0200, Uwe Kleine-König wrote:
>>> Hello Krzysztof,
>>>
>>> On Thu, Oct 15, 2026 at 11:01:29AM +0200, Krzysztof Kozlowski wrote:
>>>> On 14/10/2026 13:04, Hal Feng wrote:
>>>>> Remove the jh8100 compatible since the JH8100 SoC has been canceled and
>>>>> will not be released.
>>>>>
>>>>> Change the register size in examples to 0x10, since an OpenCores PTC IP
>>>>> has only 4 32-bit registers: CNTR, HRC, LRC and CTRL.
>>>>>
>>>>> I will maintain this pwm module in place of William.
>>>>>
>>>>> Tested-by: Maud Spierings <maud_spierings@hotmail.com>
>>>>
>>>> Drop, did not happen. Is it so tricky to respond to the one patch here,
>>>> where the tag would be applicable, instead of replying to cover letter?
>>>
>>> I don't know what Maud did, but if they checked that the various dt
>>> linters are still happy, that doesn't deserve a Tested-by:?
>>
>> No. Why would compilation be called testing?
>
> I'd call the task of checking if anything breaks with the proposed
> changes testing. For changes to .c files that most likely requires
> complilation and running the resulting code on a machine. For dt binding
> changes it means "testing" if all the existing device trees still
> conform to the new binding because you cannot compile and run the
> binding specifications. So in my mind this is still testing and a
> Tested-by trailer is ok and welcome for me.
Running standard build process tools, like checkpatch, sparse,
gcc/clang, dt-validate is not testing.
Best regards,
Krzysztof
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Uwe Kleine-König" <ukleinek@kernel.org>
Cc: Hal Feng <hal.feng@starfivetech.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor@kernel.org>,
Emil Renner Berthing <emil.renner.berthing@canonical.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Paul Walmsley <pjw@kernel.org>, Albert Ou <aou@eecs.berkeley.edu>,
linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v23 1/2] dt-bindings: pwm: opencores: Update compatibles, examples and maintainers
Date: Fri, 16 Oct 2026 15:54:07 +0200 [thread overview]
Message-ID: <f052b1b3-87fe-48e6-aa02-df47517ef8d0@kernel.org> (raw)
In-Reply-To: <atH4DnTWVZPkaO2C@monoceros>
On 16/10/2026 14:55, Uwe Kleine-König wrote:
> Hello Krzysztof,
>
> On Thu, Oct 15, 2026 at 12:27:16PM +0200, Krzysztof Kozlowski wrote:
>> On Thu, Oct 15, 2026 at 12:20:54PM +0200, Uwe Kleine-König wrote:
>>> Hello Krzysztof,
>>>
>>> On Thu, Oct 15, 2026 at 11:01:29AM +0200, Krzysztof Kozlowski wrote:
>>>> On 14/10/2026 13:04, Hal Feng wrote:
>>>>> Remove the jh8100 compatible since the JH8100 SoC has been canceled and
>>>>> will not be released.
>>>>>
>>>>> Change the register size in examples to 0x10, since an OpenCores PTC IP
>>>>> has only 4 32-bit registers: CNTR, HRC, LRC and CTRL.
>>>>>
>>>>> I will maintain this pwm module in place of William.
>>>>>
>>>>> Tested-by: Maud Spierings <maud_spierings@hotmail.com>
>>>>
>>>> Drop, did not happen. Is it so tricky to respond to the one patch here,
>>>> where the tag would be applicable, instead of replying to cover letter?
>>>
>>> I don't know what Maud did, but if they checked that the various dt
>>> linters are still happy, that doesn't deserve a Tested-by:?
>>
>> No. Why would compilation be called testing?
>
> I'd call the task of checking if anything breaks with the proposed
> changes testing. For changes to .c files that most likely requires
> complilation and running the resulting code on a machine. For dt binding
> changes it means "testing" if all the existing device trees still
> conform to the new binding because you cannot compile and run the
> binding specifications. So in my mind this is still testing and a
> Tested-by trailer is ok and welcome for me.
Running standard build process tools, like checkpatch, sparse,
gcc/clang, dt-validate is not testing.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-10-16 13:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-14 11:04 [PATCH v23 0/2] Add OpenCores PTC PWM support Hal Feng
2026-10-14 11:04 ` Hal Feng
2026-10-14 11:04 ` [PATCH v23 1/2] dt-bindings: pwm: opencores: Update compatibles, examples and maintainers Hal Feng
2026-10-14 11:04 ` Hal Feng
2026-10-15 9:01 ` Krzysztof Kozlowski
2026-10-15 9:01 ` Krzysztof Kozlowski
2026-10-15 10:20 ` Uwe Kleine-König
2026-10-15 10:20 ` Uwe Kleine-König
2026-10-15 10:27 ` Krzysztof Kozlowski
2026-10-15 10:27 ` Krzysztof Kozlowski
2026-10-16 2:12 ` Hal Feng
2026-10-16 2:12 ` Hal Feng
2026-10-16 12:55 ` Uwe Kleine-König
2026-10-16 12:55 ` Uwe Kleine-König
2026-10-16 13:54 ` Krzysztof Kozlowski [this message]
2026-10-16 13:54 ` Krzysztof Kozlowski
2026-10-14 11:04 ` [PATCH v23 2/2] pwm: Add OpenCores PTC PWM driver Hal Feng
2026-10-14 11:04 ` Hal Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f052b1b3-87fe-48e6-aa02-df47517ef8d0@kernel.org \
--to=krzk@kernel.org \
--cc=aou@eecs.berkeley.edu \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=emil.renner.berthing@canonical.com \
--cc=hal.feng@starfivetech.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=p.zabel@pengutronix.de \
--cc=palmer@dabbelt.com \
--cc=pjw@kernel.org \
--cc=robh@kernel.org \
--cc=ukleinek@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.