Decimated subseconds in smbinfo filebasicinfo timestamp output

Decimated subseconds in smbinfo filebasicinfo timestamp output

[Sam Denison]

[-- Attachment #1: Type: text/plain, Size: 643 bytes --]

Okay, like this?

I’ve attached the patch kindly written by ChenXiaoSong, if I understand the intention this is simply to allow me to take credit and do little to no work! I only edited the dates and times in the patches header and examples. I haven’t ran a single Git command! Hope the patch still works.

I’ve CCed linux-cifs@vger.kernel.org and samba-technical@lists.samba.org as requested

Sam


On Tuesday, 20 January 2026 at 15:40, Steve French <smfrench@gmail.com> wrote:

> You can send your patch as an attachment to us, you shouldn't need to change your email address or worry about smtp.
> 
> Thanks,
> 
> Steve

[-- Attachment #2: 0001-smbinfo-fix-decimated-subseconds-in-smbinfo-filebasi.patch --]
[-- Type: application/octet-stream, Size: 1532 bytes --]

From 7913c1a24b03b8c3475efebbb78cac5bfb44be73 Mon Sep 17 00:00:00 2001
From: Sam Denison <dev@denisons.org>
Date: Sun, 25 Jan 2026 19:15:01 +0000
Subject: [PATCH] smbinfo: fix decimated subseconds in smbinfo filebasicinfo
 timestamp output

The output of `./smbinfo filebasicinfo /mnt/file` is as follows:

  Creation Time: 2026-01-25 19:15:01.070729
  Last Access Time: 2026-01-25 19:15:01.070729
  Last Write Time: 2026-01-25 19:15:01.070729
  Last Change Time: 2026-01-25 19:15:01.070729

The output of `stat /mnt/file` is as follows:

  Access: 2026-01-25 19:15:01.707294600 +0000
  Modify: 2026-01-25 19:15:01.707294600 +0000
  Change: 2026-01-25 19:15:01.707294600 +0000
   Birth: 2026-01-25 19:15:01.707294600 +0000

In `win_to_datetime()`, when converting `usec` to a value in seconds,
one zero needs to be removed from the divisor.

Signed-off-by: Sam Denison <dev@denisons.org>
Signed-off-by: ChenXiaoSong <chenxiaosong@kylinos.cn>
---
 smbinfo | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/smbinfo b/smbinfo
index 57e8a0a..a168186 100755
--- a/smbinfo
+++ b/smbinfo
@@ -428,7 +428,7 @@ def cmd_fileallinfo(args):
 def win_to_datetime(smb2_time):
     usec = (smb2_time / 10) % 1000000
     sec  = (smb2_time - 116444736000000000) // 10000000
-    return datetime.datetime.fromtimestamp(sec + usec/10000000)
+    return datetime.datetime.fromtimestamp(sec + usec/1000000)
 
 def cmd_filebasicinfo(args):
     qi = QueryInfoStruct(info_type=0x1, file_info_class=4, input_buffer_length=40)
-- 
2.43.0

Re: Decimated subseconds in smbinfo filebasicinfo timestamp output

[ChenXiaoSong]

Acked-by: ChenXiaoSong <chenxiaosong@kylinos.cn>

Thanks,
ChenXiaoSong <chenxiaosong@kylinos.cn>

On 1/26/26 03:26, Sam Denison wrote:
> From: Sam Denison <dev@denisons.org>
> Date: Sun, 25 Jan 2026 19:15:01 +0000
> Subject: [PATCH] smbinfo: fix decimated subseconds in smbinfo filebasicinfo
>  timestamp output
> 
> The output of `./smbinfo filebasicinfo /mnt/file` is as follows:
> 
>   Creation Time: 2026-01-25 19:15:01.070729
>   Last Access Time: 2026-01-25 19:15:01.070729
>   Last Write Time: 2026-01-25 19:15:01.070729
>   Last Change Time: 2026-01-25 19:15:01.070729
> 
> The output of `stat /mnt/file` is as follows:
> 
>   Access: 2026-01-25 19:15:01.707294600 +0000
>   Modify: 2026-01-25 19:15:01.707294600 +0000
>   Change: 2026-01-25 19:15:01.707294600 +0000
>    Birth: 2026-01-25 19:15:01.707294600 +0000
> 
> In `win_to_datetime()`, when converting `usec` to a value in seconds,
> one zero needs to be removed from the divisor.
> 
> Signed-off-by: Sam Denison <dev@denisons.org>
> Signed-off-by: ChenXiaoSong <chenxiaosong@kylinos.cn>
> ---
>  smbinfo | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/smbinfo b/smbinfo
> index 57e8a0a..a168186 100755
> --- a/smbinfo
> +++ b/smbinfo
> @@ -428,7 +428,7 @@ def cmd_fileallinfo(args):
>  def win_to_datetime(smb2_time):
>      usec = (smb2_time / 10) % 1000000
>      sec  = (smb2_time - 116444736000000000) // 10000000
> -    return datetime.datetime.fromtimestamp(sec + usec/10000000)
> +    return datetime.datetime.fromtimestamp(sec + usec/1000000)
>  
>  def cmd_filebasicinfo(args):
>      qi = QueryInfoStruct(info_type=0x1, file_info_class=4, input_buffer_length=40)
> -- 
> 2.43.0

Re: Decimated subseconds in smbinfo filebasicinfo timestamp output

[Steve French]

merged into cifs-utils for-next

On Sun, Jan 25, 2026 at 1:26 PM Sam Denison <dev@denisons.org> wrote:
>
> Okay, like this?
>
> I’ve attached the patch kindly written by ChenXiaoSong, if I understand the intention this is simply to allow me to take credit and do little to no work! I only edited the dates and times in the patches header and examples. I haven’t ran a single Git command! Hope the patch still works.
>
> I’ve CCed linux-cifs@vger.kernel.org and samba-technical@lists.samba.org as requested
>
> Sam
>
>
> On Tuesday, 20 January 2026 at 15:40, Steve French <smfrench@gmail.com> wrote:
>
> > You can send your patch as an attachment to us, you shouldn't need to change your email address or worry about smtp.
> >
> > Thanks,
> >
> > Steve



-- 
Thanks,

Steve