All of lore.kernel.org
 help / color / mirror / Atom feed
From: "liaochang (A)" <liaochang1@huawei.com>
To: <guoren@kernel.org>, <arnd@arndb.de>, <palmer@rivosinc.com>,
	<tglx@linutronix.de>, <peterz@infradead.org>, <luto@kernel.org>,
	<conor.dooley@microchip.com>, <heiko@sntech.de>,
	<jszhang@kernel.org>, <lazyparser@gmail.com>,
	<falcon@tinylab.org>, <chenhuacai@kernel.org>,
	<apatel@ventanamicro.com>, <atishp@atishpatra.org>,
	<palmer@dabbelt.com>, <paul.walmsley@sifive.com>,
	<mark.rutland@arm.com>, <zouyipeng@huawei.com>,
	<bigeasy@linutronix.de>, <David.Laight@aculab.com>,
	<chenzhongjin@huawei.com>
Cc: <linux-arch@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-riscv@lists.infradead.org>,
	Guo Ren <guoren@linux.alibaba.com>,
	kernel test robot <lkp@intel.com>
Subject: Re: [PATCH V6 01/11] riscv: elf_kexec: Fixup compile warning
Date: Tue, 25 Oct 2022 09:20:19 +0800	[thread overview]
Message-ID: <f0785930-8f2a-9d09-4dbf-545d11994cbe@huawei.com> (raw)
In-Reply-To: <20221002012451.2351127-2-guoren@kernel.org>



在 2022/10/2 9:24, guoren@kernel.org 写道:
> From: Guo Ren <guoren@linux.alibaba.com>
> 
> If CRYTPO or CRYPTO_SHA256 or KEXE_FILE is not enabled, then:
> 
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1
> O=build_dir ARCH=riscv SHELL=/bin/bash arch/riscv/
> 
> ../arch/riscv/kernel/elf_kexec.c: In function 'elf_kexec_load':
> ../arch/riscv/kernel/elf_kexec.c:185:23: warning: variable
> 'kernel_start' set but not used [-Wunused-but-set-variable]
>   185 |         unsigned long kernel_start;
>       |                       ^~~~~~~~~~~~
> 
> Fixes: 838b3e28488f ("RISC-V: Load purgatory in kexec_file")
> Signed-off-by: Guo Ren <guoren@linux.alibaba.com>
> Signed-off-by: Guo Ren <guoren@kernel.org>
> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
> Reported-by: kernel test robot <lkp@intel.com>
> ---
>  arch/riscv/kernel/elf_kexec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/riscv/kernel/elf_kexec.c b/arch/riscv/kernel/elf_kexec.c
> index 0cb94992c15b..4b9264340b78 100644
> --- a/arch/riscv/kernel/elf_kexec.c
> +++ b/arch/riscv/kernel/elf_kexec.c
> @@ -198,7 +198,7 @@ static void *elf_kexec_load(struct kimage *image, char *kernel_buf,
>  	if (ret)
>  		goto out;
>  	kernel_start = image->start;
> -	pr_notice("The entry point of kernel at 0x%lx\n", image->start);
> +	pr_notice("The entry point of kernel at 0x%lx\n", kernel_start);
>  
>  	/* Add the kernel binary to the image */
>  	ret = riscv_kexec_elf_load(image, &ehdr, &elf_info,

LGTM

Reviewed-by: Liao Chang <liaochang1@huawei.com>

-- 
BR,
Liao, Chang

WARNING: multiple messages have this Message-ID (diff)
From: "liaochang (A)" <liaochang1@huawei.com>
To: <guoren@kernel.org>, <arnd@arndb.de>, <palmer@rivosinc.com>,
	<tglx@linutronix.de>, <peterz@infradead.org>, <luto@kernel.org>,
	<conor.dooley@microchip.com>, <heiko@sntech.de>,
	<jszhang@kernel.org>, <lazyparser@gmail.com>,
	<falcon@tinylab.org>, <chenhuacai@kernel.org>,
	<apatel@ventanamicro.com>, <atishp@atishpatra.org>,
	<palmer@dabbelt.com>, <paul.walmsley@sifive.com>,
	<mark.rutland@arm.com>, <zouyipeng@huawei.com>,
	<bigeasy@linutronix.de>, <David.Laight@aculab.com>,
	<chenzhongjin@huawei.com>
Cc: <linux-arch@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-riscv@lists.infradead.org>,
	Guo Ren <guoren@linux.alibaba.com>,
	kernel test robot <lkp@intel.com>
Subject: Re: [PATCH V6 01/11] riscv: elf_kexec: Fixup compile warning
Date: Tue, 25 Oct 2022 09:20:19 +0800	[thread overview]
Message-ID: <f0785930-8f2a-9d09-4dbf-545d11994cbe@huawei.com> (raw)
In-Reply-To: <20221002012451.2351127-2-guoren@kernel.org>



在 2022/10/2 9:24, guoren@kernel.org 写道:
> From: Guo Ren <guoren@linux.alibaba.com>
> 
> If CRYTPO or CRYPTO_SHA256 or KEXE_FILE is not enabled, then:
> 
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1
> O=build_dir ARCH=riscv SHELL=/bin/bash arch/riscv/
> 
> ../arch/riscv/kernel/elf_kexec.c: In function 'elf_kexec_load':
> ../arch/riscv/kernel/elf_kexec.c:185:23: warning: variable
> 'kernel_start' set but not used [-Wunused-but-set-variable]
>   185 |         unsigned long kernel_start;
>       |                       ^~~~~~~~~~~~
> 
> Fixes: 838b3e28488f ("RISC-V: Load purgatory in kexec_file")
> Signed-off-by: Guo Ren <guoren@linux.alibaba.com>
> Signed-off-by: Guo Ren <guoren@kernel.org>
> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
> Reported-by: kernel test robot <lkp@intel.com>
> ---
>  arch/riscv/kernel/elf_kexec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/riscv/kernel/elf_kexec.c b/arch/riscv/kernel/elf_kexec.c
> index 0cb94992c15b..4b9264340b78 100644
> --- a/arch/riscv/kernel/elf_kexec.c
> +++ b/arch/riscv/kernel/elf_kexec.c
> @@ -198,7 +198,7 @@ static void *elf_kexec_load(struct kimage *image, char *kernel_buf,
>  	if (ret)
>  		goto out;
>  	kernel_start = image->start;
> -	pr_notice("The entry point of kernel at 0x%lx\n", image->start);
> +	pr_notice("The entry point of kernel at 0x%lx\n", kernel_start);
>  
>  	/* Add the kernel binary to the image */
>  	ret = riscv_kexec_elf_load(image, &ehdr, &elf_info,

LGTM

Reviewed-by: Liao Chang <liaochang1@huawei.com>

-- 
BR,
Liao, Chang

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  reply	other threads:[~2022-10-25  1:40 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-02  1:24 [PATCH V6 00/11] riscv: Add GENERIC_ENTRY support and related features guoren
2022-10-02  1:24 ` guoren
2022-10-02  1:24 ` [PATCH V6 01/11] riscv: elf_kexec: Fixup compile warning guoren
2022-10-02  1:24   ` guoren
2022-10-25  1:20   ` liaochang (A) [this message]
2022-10-25  1:20     ` liaochang (A)
2022-10-25  2:36     ` Guo Ren
2022-10-25  2:36       ` Guo Ren
2022-10-02  1:24 ` [PATCH V6 02/11] riscv: compat_syscall_table: " guoren
2022-10-02  1:24   ` guoren
2022-10-02  1:24 ` [PATCH V6 03/11] riscv: ptrace: Remove duplicate operation guoren
2022-10-02  1:24   ` guoren
2022-10-02  1:24 ` [PATCH V6 04/11] compiler_types.h: Add __noinstr_section() for noinstr guoren
2022-10-02  1:24   ` guoren
2022-10-03 11:38   ` Mark Rutland
2022-10-03 11:38     ` Mark Rutland
2022-10-08  1:54     ` Guo Ren
2022-10-08  1:54       ` Guo Ren
2022-10-20  9:15       ` Mark Rutland
2022-10-20  9:15         ` Mark Rutland
2022-10-20 12:29         ` Guo Ren
2022-10-20 12:29           ` Guo Ren
2022-10-24 11:56           ` Mark Rutland
2022-10-24 11:56             ` Mark Rutland
2022-10-24 12:06             ` Peter Zijlstra
2022-10-24 12:06               ` Peter Zijlstra
2022-10-24 12:14               ` Mark Rutland
2022-10-24 12:14                 ` Mark Rutland
2022-10-25  2:51                 ` Guo Ren
2022-10-25  2:51                   ` Guo Ren
2022-10-25  9:47                   ` Mark Rutland
2022-10-25  9:47                     ` Mark Rutland
2022-10-02  1:24 ` [PATCH V6 05/11] riscv: traps: Add noinstr to prevent instrumentation inserted guoren
2022-10-02  1:24   ` guoren
2022-10-03 11:40   ` Mark Rutland
2022-10-03 11:40     ` Mark Rutland
2022-10-08  2:16     ` Guo Ren
2022-10-08  2:16       ` Guo Ren
2022-10-02  1:24 ` [PATCH V6 06/11] riscv: convert to generic entry guoren
2022-10-02  1:24   ` guoren
2022-10-02  1:24 ` [PATCH V6 07/11] riscv: Support HAVE_IRQ_EXIT_ON_IRQ_STACK guoren
2022-10-02  1:24   ` guoren
2022-10-02  1:24 ` [PATCH V6 08/11] riscv: Support HAVE_SOFTIRQ_ON_OWN_STACK guoren
2022-10-02  1:24   ` guoren
2022-10-02  1:24 ` [PATCH V6 09/11] riscv: Add support for STACKLEAK gcc plugin guoren
2022-10-02  1:24   ` guoren
2022-10-03 11:34   ` Mark Rutland
2022-10-03 11:34     ` Mark Rutland
2022-10-08  0:16     ` Guo Ren
2022-10-08  0:16       ` Guo Ren
2022-10-08  3:26     ` Guo Ren
2022-10-08  3:26       ` Guo Ren
2022-10-08  3:44       ` Guo Ren
2022-10-08  3:44         ` Guo Ren
2022-10-02  1:24 ` [PATCH V6 10/11] riscv: Add config of thread stack size guoren
2022-10-02  1:24   ` guoren
2022-10-02  1:24 ` [PATCH V6 11/11] riscv: remove extra level wrappers of trace_hardirqs_{on,off} guoren
2022-10-02  1:24   ` guoren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f0785930-8f2a-9d09-4dbf-545d11994cbe@huawei.com \
    --to=liaochang1@huawei.com \
    --cc=David.Laight@aculab.com \
    --cc=apatel@ventanamicro.com \
    --cc=arnd@arndb.de \
    --cc=atishp@atishpatra.org \
    --cc=bigeasy@linutronix.de \
    --cc=chenhuacai@kernel.org \
    --cc=chenzhongjin@huawei.com \
    --cc=conor.dooley@microchip.com \
    --cc=falcon@tinylab.org \
    --cc=guoren@kernel.org \
    --cc=guoren@linux.alibaba.com \
    --cc=heiko@sntech.de \
    --cc=jszhang@kernel.org \
    --cc=lazyparser@gmail.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=lkp@intel.com \
    --cc=luto@kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=palmer@dabbelt.com \
    --cc=palmer@rivosinc.com \
    --cc=paul.walmsley@sifive.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=zouyipeng@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.