From: Florian Fainelli <f.fainelli@gmail.com>
To: Colin King <colin.king@canonical.com>,
Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
netdev@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: phy: mdio-bcm-unimac: remove redundant !timeout check
Date: Wed, 27 Mar 2019 16:21:23 +0000 [thread overview]
Message-ID: <f0cc34fe-c692-d414-dc1e-9d03c8da8dc2@gmail.com> (raw)
In-Reply-To: <20190327161520.23064-1-colin.king@canonical.com>
On 3/27/19 9:15 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The check for zero timeout is always true at the end of the proceeding
> while loop; the only other exit path in the loop is if the unimac MDIO
> is not busy. Remove the redundant zero timeout check and always
> return -ETIMEDOUT on this timeout return path.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
WARNING: multiple messages have this Message-ID (diff)
From: Florian Fainelli <f.fainelli@gmail.com>
To: Colin King <colin.king@canonical.com>,
Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
netdev@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: phy: mdio-bcm-unimac: remove redundant !timeout check
Date: Wed, 27 Mar 2019 09:21:23 -0700 [thread overview]
Message-ID: <f0cc34fe-c692-d414-dc1e-9d03c8da8dc2@gmail.com> (raw)
In-Reply-To: <20190327161520.23064-1-colin.king@canonical.com>
On 3/27/19 9:15 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The check for zero timeout is always true at the end of the proceeding
> while loop; the only other exit path in the loop is if the unimac MDIO
> is not busy. Remove the redundant zero timeout check and always
> return -ETIMEDOUT on this timeout return path.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
next prev parent reply other threads:[~2019-03-27 16:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-27 16:15 [PATCH] net: phy: mdio-bcm-unimac: remove redundant !timeout check Colin King
2019-03-27 16:21 ` Florian Fainelli [this message]
2019-03-27 16:21 ` Florian Fainelli
2019-03-27 21:27 ` David Miller
2019-03-27 21:27 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0cc34fe-c692-d414-dc1e-9d03c8da8dc2@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=colin.king@canonical.com \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.