Re: [RFC PATCH 2/5] ata: libahci_platform: Adapt the return value changed for disabled blob

From: Damien Le Moal <dlemoal@kernel.org>
To: Inochi Amaoto <inochiama@gmail.com>,
	Hans de Goede <hansg@kernel.org>,
	Niklas Cassel <cassel@kernel.org>,
	Andrzej Hajda <andrzej.hajda@intel.com>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Robert Foss <rfoss@kernel.org>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	Jonas Karlman <jonas@kwiboo.se>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Luca Ceresoli <luca.ceresoli@bootlin.com>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	Minas Harutyunyan <hminas@synopsys.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
	Vinod Koul <vkoul@kernel.org>,
	Manivannan Sadhasivam <mani@kernel.org>,
	Damon Ding <damon.ding@rock-chips.com>,
	Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
	Heiko Stuebner <heiko@sntech.de>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org, linux-usb@vger.kernel.org,
	linux-phy@lists.infradead.org, Yixun Lan <dlan@gentoo.org>,
	Longbin Li <looong.bin@gmail.com>
Subject: Re: [RFC PATCH 2/5] ata: libahci_platform: Adapt the return value changed for disabled blob
Date: Tue, 22 Sep 2026 12:23:54 +0900	[thread overview]
Message-ID: <f0db06a2-08e4-4013-96cb-c6754f673126@kernel.org> (raw)
In-Reply-To: <20260922024724.191412-3-inochiama@gmail.com>

On 9/22/26 11:47, Inochi Amaoto wrote:
> Check EOPNOTSUPP for disabled helper function as the change in phy core.
> 
> Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
> ---
>  drivers/ata/libahci_platform.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/ata/libahci_platform.c b/drivers/ata/libahci_platform.c
> index 6e072d681341..3e8ddbeb49b3 100644
> --- a/drivers/ata/libahci_platform.c
> +++ b/drivers/ata/libahci_platform.c
> @@ -371,11 +371,11 @@ static int ahci_platform_get_phy(struct ahci_host_priv *hpriv, u32 port,
>  
>  	rc = PTR_ERR(hpriv->phys[port]);
>  	switch (rc) {
> -	case -ENOSYS:
> +	case -EOPNOTSUPP:
>  		/* No PHY support. Check if PHY is required. */
>  		if (of_property_present(node, "phys")) {
>  			dev_err(dev,
> -				"couldn't get PHY in node %pOFn: ENOSYS\n",
> +				"couldn't get PHY in node %pOFn: EOPNOTSUPP\n",

I do not see the point in printing an error code name. Instead, let's make the
error message more sensible. Something like:

	dev_err(dev, "Node %pOFn: PHY not supported\n", node);

Or

	dev_err(dev, "PHY not supported on node %pOFn\n", node);

>  				node);
>  			break;
>  		}

-- 
Damien Le Moal
Western Digital Research