* [PATCH] jffs2: remove SLAB_MEM_SPREAD flag usage
@ 2024-02-24 13:49 ` chengming.zhou
0 siblings, 0 replies; 6+ messages in thread
From: chengming.zhou @ 2024-02-24 13:49 UTC (permalink / raw)
To: dwmw2, richard, jack, chuck.lever, dave.kleikamp, amir73il
Cc: zhouchengming, linux-mtd, linux-kernel, linux-mm, vbabka,
roman.gushchin, Xiongwei.Song, chengming.zhou
From: Chengming Zhou <zhouchengming@bytedance.com>
The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove
its usage so we can delete it from slab. No functional change.
Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com>
---
fs/jffs2/super.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/jffs2/super.c b/fs/jffs2/super.c
index f99591a634b4..aede1be4dc0c 100644
--- a/fs/jffs2/super.c
+++ b/fs/jffs2/super.c
@@ -387,7 +387,7 @@ static int __init init_jffs2_fs(void)
jffs2_inode_cachep = kmem_cache_create("jffs2_i",
sizeof(struct jffs2_inode_info),
0, (SLAB_RECLAIM_ACCOUNT|
- SLAB_MEM_SPREAD|SLAB_ACCOUNT),
+ SLAB_ACCOUNT),
jffs2_i_init_once);
if (!jffs2_inode_cachep) {
pr_err("error: Failed to initialise inode cache\n");
--
2.40.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] jffs2: remove SLAB_MEM_SPREAD flag usage
2024-02-24 13:49 ` chengming.zhou
@ 2024-02-26 2:13 ` Zhihao Cheng
-1 siblings, 0 replies; 6+ messages in thread
From: Zhihao Cheng @ 2024-02-26 2:13 UTC (permalink / raw)
To: chengming.zhou, dwmw2, richard, jack, chuck.lever, dave.kleikamp,
amir73il
Cc: zhouchengming, linux-mtd, linux-kernel, linux-mm, vbabka,
roman.gushchin, Xiongwei.Song
在 2024/2/24 21:49, chengming.zhou@linux.dev 写道:
> From: Chengming Zhou <zhouchengming@bytedance.com>
>
> The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove
> its usage so we can delete it from slab. No functional change.
>
> Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com>
> ---
> fs/jffs2/super.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Zhihao Cheng <chengzhihao1@huawei.com>
>
> diff --git a/fs/jffs2/super.c b/fs/jffs2/super.c
> index f99591a634b4..aede1be4dc0c 100644
> --- a/fs/jffs2/super.c
> +++ b/fs/jffs2/super.c
> @@ -387,7 +387,7 @@ static int __init init_jffs2_fs(void)
> jffs2_inode_cachep = kmem_cache_create("jffs2_i",
> sizeof(struct jffs2_inode_info),
> 0, (SLAB_RECLAIM_ACCOUNT|
> - SLAB_MEM_SPREAD|SLAB_ACCOUNT),
> + SLAB_ACCOUNT),
> jffs2_i_init_once);
> if (!jffs2_inode_cachep) {
> pr_err("error: Failed to initialise inode cache\n");
>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] jffs2: remove SLAB_MEM_SPREAD flag usage
@ 2024-02-26 2:13 ` Zhihao Cheng
0 siblings, 0 replies; 6+ messages in thread
From: Zhihao Cheng @ 2024-02-26 2:13 UTC (permalink / raw)
To: chengming.zhou, dwmw2, richard, jack, chuck.lever, dave.kleikamp,
amir73il
Cc: zhouchengming, linux-mtd, linux-kernel, linux-mm, vbabka,
roman.gushchin, Xiongwei.Song
在 2024/2/24 21:49, chengming.zhou@linux.dev 写道:
> From: Chengming Zhou <zhouchengming@bytedance.com>
>
> The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove
> its usage so we can delete it from slab. No functional change.
>
> Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com>
> ---
> fs/jffs2/super.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Zhihao Cheng <chengzhihao1@huawei.com>
>
> diff --git a/fs/jffs2/super.c b/fs/jffs2/super.c
> index f99591a634b4..aede1be4dc0c 100644
> --- a/fs/jffs2/super.c
> +++ b/fs/jffs2/super.c
> @@ -387,7 +387,7 @@ static int __init init_jffs2_fs(void)
> jffs2_inode_cachep = kmem_cache_create("jffs2_i",
> sizeof(struct jffs2_inode_info),
> 0, (SLAB_RECLAIM_ACCOUNT|
> - SLAB_MEM_SPREAD|SLAB_ACCOUNT),
> + SLAB_ACCOUNT),
> jffs2_i_init_once);
> if (!jffs2_inode_cachep) {
> pr_err("error: Failed to initialise inode cache\n");
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] jffs2: remove SLAB_MEM_SPREAD flag usage
2024-02-24 13:49 ` chengming.zhou
@ 2024-02-26 2:45 ` Chengming Zhou
-1 siblings, 0 replies; 6+ messages in thread
From: Chengming Zhou @ 2024-02-26 2:45 UTC (permalink / raw)
To: dwmw2, richard, jack, chuck.lever, dave.kleikamp, amir73il
Cc: zhouchengming, linux-mtd, linux-kernel, vbabka, roman.gushchin,
Xiongwei.Song
On 2024/2/24 21:49, chengming.zhou@linux.dev wrote:
> From: Chengming Zhou <zhouchengming@bytedance.com>
>
> The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove
> its usage so we can delete it from slab. No functional change.
Update changelog to make it clearer:
The SLAB_MEM_SPREAD flag used to be implemented in SLAB, which was
removed as of v6.8-rc1, so it became a dead flag. And the series[1]
went on to mark it obsolete to avoid confusion for users. Here we
can just remove all its users, which has no functional change.
[1] https://lore.kernel.org/all/20240223-slab-cleanup-flags-v2-1-02f1753e8303@suse.cz/
Thanks!
>
> Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com>
> ---
> fs/jffs2/super.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/jffs2/super.c b/fs/jffs2/super.c
> index f99591a634b4..aede1be4dc0c 100644
> --- a/fs/jffs2/super.c
> +++ b/fs/jffs2/super.c
> @@ -387,7 +387,7 @@ static int __init init_jffs2_fs(void)
> jffs2_inode_cachep = kmem_cache_create("jffs2_i",
> sizeof(struct jffs2_inode_info),
> 0, (SLAB_RECLAIM_ACCOUNT|
> - SLAB_MEM_SPREAD|SLAB_ACCOUNT),
> + SLAB_ACCOUNT),
> jffs2_i_init_once);
> if (!jffs2_inode_cachep) {
> pr_err("error: Failed to initialise inode cache\n");
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] jffs2: remove SLAB_MEM_SPREAD flag usage
@ 2024-02-26 2:45 ` Chengming Zhou
0 siblings, 0 replies; 6+ messages in thread
From: Chengming Zhou @ 2024-02-26 2:45 UTC (permalink / raw)
To: dwmw2, richard, jack, chuck.lever, dave.kleikamp, amir73il
Cc: zhouchengming, linux-mtd, linux-kernel, vbabka, roman.gushchin,
Xiongwei.Song
On 2024/2/24 21:49, chengming.zhou@linux.dev wrote:
> From: Chengming Zhou <zhouchengming@bytedance.com>
>
> The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove
> its usage so we can delete it from slab. No functional change.
Update changelog to make it clearer:
The SLAB_MEM_SPREAD flag used to be implemented in SLAB, which was
removed as of v6.8-rc1, so it became a dead flag. And the series[1]
went on to mark it obsolete to avoid confusion for users. Here we
can just remove all its users, which has no functional change.
[1] https://lore.kernel.org/all/20240223-slab-cleanup-flags-v2-1-02f1753e8303@suse.cz/
Thanks!
>
> Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com>
> ---
> fs/jffs2/super.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/jffs2/super.c b/fs/jffs2/super.c
> index f99591a634b4..aede1be4dc0c 100644
> --- a/fs/jffs2/super.c
> +++ b/fs/jffs2/super.c
> @@ -387,7 +387,7 @@ static int __init init_jffs2_fs(void)
> jffs2_inode_cachep = kmem_cache_create("jffs2_i",
> sizeof(struct jffs2_inode_info),
> 0, (SLAB_RECLAIM_ACCOUNT|
> - SLAB_MEM_SPREAD|SLAB_ACCOUNT),
> + SLAB_ACCOUNT),
> jffs2_i_init_once);
> if (!jffs2_inode_cachep) {
> pr_err("error: Failed to initialise inode cache\n");
^ permalink raw reply [flat|nested] 6+ messages in thread