Re: [PATCH 1/5] drm/panel: have drm_panel_add/remove manage a list reference

From: "Maxime Ripard" <mripard@kernel.org>
To: "Albert Esteve" <aesteve@redhat.com>
Cc: dri-devel@lists.freedesktop.org, imx@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org,
	linux-renesas-soc@vger.kernel.org,
	linux-rockchip@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org,
	"Alain Volmat" <alain.volmat@foss.st.com>,
	"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
	"Alim Akhtar" <alim.akhtar@samsung.com>,
	"Alison Wang" <alison.wang@nxp.com>,
	"Andrzej Hajda" <andrzej.hajda@intel.com>,
	"Andy Yan" <andy.yan@rock-chips.com>,
	"Biju Das" <biju.das.jz@bp.renesas.com>,
	"Chen-Yu Tsai" <wens@kernel.org>,
	"David Airlie" <airlied@gmail.com>,
	"Fabio Estevam" <festevam@gmail.com>,
	"Frank Li" <Frank.Li@nxp.com>,
	"Geert Uytterhoeven" <geert+renesas@glider.be>,
	"Heiko Stübner" <heiko@sntech.de>,
	"Inki Dae" <inki.dae@samsung.com>,
	"Jagan Teki" <jagan@amarulasolutions.com>,
	"Jernej Skrabec" <jernej.skrabec@gmail.com>,
	"Jessica Zhang" <jesszhan0024@gmail.com>,
	"Jingoo Han" <jingoohan1@gmail.com>,
	"Jonas Karlman" <jonas@kwiboo.se>,
	"Jonathan Hunter" <jonathanh@nvidia.com>,
	"Jyri Sarha" <jyri.sarha@iki.fi>,
	"Kieran Bingham" <kieran.bingham+renesas@ideasonboard.com>,
	"Krzysztof Kozlowski" <krzk@kernel.org>,
	"Kyungmin Park" <kyungmin.park@samsung.com>,
	"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>,
	"Laurent Pinchart" <laurent.pinchart+renesas@ideasonboard.com>,
	"Laurentiu Palcu" <laurentiu.palcu@oss.nxp.com>,
	"Linus Walleij" <linusw@kernel.org>,
	"Luca Ceresoli" <luca.ceresoli@bootlin.com>,
	"Lucas Stach" <l.stach@pengutronix.de>,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Magnus Damm" <magnus.damm@gmail.com>,
	"Marek Szyprowski" <m.szyprowski@samsung.com>,
	"Marek Vasut" <marex@denx.de>,
	"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
	"Maxime Ripard" <mripard@kernel.org>,
	"Mikko Perttunen" <mperttunen@nvidia.com>,
	"Neil Armstrong" <neil.armstrong@linaro.org>,
	"Paul Cercueil" <paul@crapouillou.net>,
	"Paul Kocialkowski" <paulk@sys-base.io>,
	"Pengutronix Kernel Team" <kernel@pengutronix.de>,
	"Peter Griffin" <peter.griffin@linaro.org>,
	"Philippe Cornu" <philippe.cornu@foss.st.com>,
	"Raphael Gallais-Pou" <raphael.gallais-pou@foss.st.com>,
	"Raphael Gallais-Pou" <rgallaispou@gmail.com>,
	"Robert Foss" <rfoss@kernel.org>,
	"Samuel Holland" <samuel@sholland.org>,
	"Sandy Huang" <hjc@rock-chips.com>,
	"Sascha Hauer" <s.hauer@pengutronix.de>,
	"Seung-Woo Kim" <sw0312.kim@samsung.com>,
	"Simona Vetter" <simona@ffwll.ch>,
	"Stefan Agner" <stefan@agner.ch>,
	"Thierry Reding" <thierry.reding@kernel.org>,
	"Thomas Zimmermann" <tzimmermann@suse.de>,
	"Tomi Valkeinen" <tomi.valkeinen@ideasonboard.com>,
	"Yannick Fertre" <yannick.fertre@foss.st.com>
Subject: Re: [PATCH 1/5] drm/panel: have drm_panel_add/remove manage a list reference
Date: Fri, 26 Jun 2026 12:47:28 +0000	[thread overview]
Message-ID: <f183d0ba167f71e0555814f7447f46e0@kernel.org> (raw)
In-Reply-To: <20260626-drm_refcount_wiring-v1-1-cca1a7b3bdef@redhat.com>

On Fri, 26 Jun 2026 14:03:23 +0200, Albert Esteve wrote:
> The global panel_list holds raw pointers to drm_panel objects.
> Nothing prevents a panel from being freed while it is still linked
> in the list: if a driver's probe calls drm_panel_add() and then
> fails at a later step, panel->list remains in panel_list. Any
> subsequent call to of_drm_find_panel() that iterates the list will
> 
> [ ... ]

Reviewed-by: Maxime Ripard <mripard@kernel.org>

Thanks!
Maxime