From: Krzysztof Kozlowski <krzk@kernel.org>
To: Yixun Lan <dlan@gentoo.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Conor Dooley <conor@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>, Yangyu Chen <cyy@cyyself.name>,
Jisheng Zhang <jszhang@kernel.org>,
Inochi Amaoto <inochiama@outlook.com>,
Icenowy Zheng <uwu@icenowy.me>,
Meng Zhang <zhangmeng.kevin@spacemit.com>,
Meng Zhang <kevin.z.m@hotmail.com>,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org
Subject: Re: [PATCH 1/3] dt-bindings: gpio: spacemit: add support for K1 SoC
Date: Wed, 4 Sep 2024 09:42:10 +0200 [thread overview]
Message-ID: <f27dc213-e5a0-41d7-9522-ed29567f0097@kernel.org> (raw)
In-Reply-To: <20240904070520-GYA107481@gentoo>
On 04/09/2024 09:05, Yixun Lan wrote:
> Hi Krzysztof
>>> + "#interrupt-cells":
>>> + const: 2
>>> + description: |
>>> + The first cell is the GPIO number, the second should specify
>>> + flags. The following subset of flags is supported:
>>> + - bits[3:0] trigger type flags (no level trigger type support)
>>> + 1 = low-to-high edge triggered
>>> + 2 = high-to-low edge triggered
>>> + Valid combinations are 1, 2, 3
>>
>> Hm? No, you must use standard interrupt flags, not custom ones.
>>
> It should be same as standard flags, my intention here was try to say
> the controller support edge trigger only, but no level trigger flags (4, 8)
> should I just replace number to macro, and put it like this:
Then just say that level interrupts are not supported. Do not refer to
some bits (bits of what?).
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Yixun Lan <dlan@gentoo.org>
Cc: linux-riscv@lists.infradead.org, Rob Herring <robh@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Albert Ou <aou@eecs.berkeley.edu>,
Meng Zhang <kevin.z.m@hotmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
linux-kernel@vger.kernel.org, Conor Dooley <conor@kernel.org>,
Yangyu Chen <cyy@cyyself.name>,
devicetree@vger.kernel.org, linux-gpio@vger.kernel.org,
Palmer Dabbelt <palmer@dabbelt.com>,
Jisheng Zhang <jszhang@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Inochi Amaoto <inochiama@outlook.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Meng Zhang <zhangmeng.kevin@spacemit.com>
Subject: Re: [PATCH 1/3] dt-bindings: gpio: spacemit: add support for K1 SoC
Date: Wed, 4 Sep 2024 09:42:10 +0200 [thread overview]
Message-ID: <f27dc213-e5a0-41d7-9522-ed29567f0097@kernel.org> (raw)
In-Reply-To: <20240904070520-GYA107481@gentoo>
On 04/09/2024 09:05, Yixun Lan wrote:
> Hi Krzysztof
>>> + "#interrupt-cells":
>>> + const: 2
>>> + description: |
>>> + The first cell is the GPIO number, the second should specify
>>> + flags. The following subset of flags is supported:
>>> + - bits[3:0] trigger type flags (no level trigger type support)
>>> + 1 = low-to-high edge triggered
>>> + 2 = high-to-low edge triggered
>>> + Valid combinations are 1, 2, 3
>>
>> Hm? No, you must use standard interrupt flags, not custom ones.
>>
> It should be same as standard flags, my intention here was try to say
> the controller support edge trigger only, but no level trigger flags (4, 8)
> should I just replace number to macro, and put it like this:
Then just say that level interrupts are not supported. Do not refer to
some bits (bits of what?).
Best regards,
Krzysztof
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2024-09-04 7:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-04 0:27 [PATCH 0/3] riscv: spacemit: add gpio support for K1 SoC Yixun Lan
2024-09-04 0:27 ` Yixun Lan
2024-09-04 0:27 ` [PATCH 1/3] dt-bindings: gpio: spacemit: add " Yixun Lan
2024-09-04 0:27 ` Yixun Lan
2024-09-04 6:46 ` Krzysztof Kozlowski
2024-09-04 6:46 ` Krzysztof Kozlowski
2024-09-04 7:05 ` Yixun Lan
2024-09-04 7:05 ` Yixun Lan
2024-09-04 7:42 ` Krzysztof Kozlowski [this message]
2024-09-04 7:42 ` Krzysztof Kozlowski
2024-09-04 8:39 ` Yixun Lan
2024-09-04 8:39 ` Yixun Lan
2024-09-04 0:27 ` [PATCH 2/3] " Yixun Lan
2024-09-04 0:27 ` Yixun Lan
2024-09-04 0:27 ` [PATCH 3/3] riscv: dts: spacemit: add gpio " Yixun Lan
2024-09-04 0:27 ` Yixun Lan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f27dc213-e5a0-41d7-9522-ed29567f0097@kernel.org \
--to=krzk@kernel.org \
--cc=aou@eecs.berkeley.edu \
--cc=brgl@bgdev.pl \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=cyy@cyyself.name \
--cc=devicetree@vger.kernel.org \
--cc=dlan@gentoo.org \
--cc=inochiama@outlook.com \
--cc=jszhang@kernel.org \
--cc=kevin.z.m@hotmail.com \
--cc=krzk+dt@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh@kernel.org \
--cc=uwu@icenowy.me \
--cc=zhangmeng.kevin@spacemit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.