From: Dan Carpenter <dan.carpenter@linaro.org>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: kernel-janitors@vger.kernel.org, smatch@vger.kernel.org,
Eric Dumazet <edumazet@google.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
intel-wired-lan@lists.osuosl.org,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com>,
Jiri Pirko <jiri@resnulli.us>, Kees Cook <keescook@chromium.org>,
Lukasz Czapnik <lukasz.czapnik@intel.com>,
Dan Williams <dan.j.williams@intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
netdev@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Julia Lawall <julia.lawall@inria.fr>,
Alexander Lobakin <aleksander.lobakin@intel.com>,
David Laight <David.Laight@aculab.com>,
"David S. Miller" <davem@davemloft.net>,
Jonathan Cameron <jic23@kernel.org>
Subject: Re: [Intel-wired-lan] [PATCH v2 net] ice: Fix freeing uninitialized pointers
Date: Sun, 24 Mar 2024 13:43:12 +0300 [thread overview]
Message-ID: <f292facc-8a22-42e1-9a41-5ec8bd665cb7@moroto.mountain> (raw)
In-Reply-To: <08c9f970-3007-461a-b9f9-9ab414024f68@web.de>
On Sat, Mar 23, 2024 at 05:56:29PM +0100, Markus Elfring wrote:
> > Automatically cleaned up pointers need to be initialized before exiting
> > their scope. In this case, they need to be initialized to NULL before
> > any return statement.
>
> * May we expect that compilers should report that affected variables
> were only declared here instead of appropriately defined
> (despite of attempts for scope-based resource management)?
>
We disabled GCC's check for uninitialized variables a long time ago
because it had too many false positives.
> * Did you extend detection support in the source code analysis tool “Smatch”
> for a questionable implementation detail?
Yes. Smatch detects this as an uninitialized variable.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@linaro.org>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: kernel-janitors@vger.kernel.org, netdev@vger.kernel.org,
intel-wired-lan@lists.osuosl.org, smatch@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
Alexander Lobakin <aleksander.lobakin@intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
David Laight <David.Laight@aculab.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
Jiri Pirko <jiri@resnulli.us>,
Jonathan Cameron <jic23@kernel.org>,
Julia Lawall <julia.lawall@inria.fr>,
Kees Cook <keescook@chromium.org>,
Lukasz Czapnik <lukasz.czapnik@intel.com>,
Paolo Abeni <pabeni@redhat.com>,
Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com>,
Dan Williams <dan.j.williams@intel.com>,
Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>
Subject: Re: [PATCH v2 net] ice: Fix freeing uninitialized pointers
Date: Sun, 24 Mar 2024 13:43:12 +0300 [thread overview]
Message-ID: <f292facc-8a22-42e1-9a41-5ec8bd665cb7@moroto.mountain> (raw)
In-Reply-To: <08c9f970-3007-461a-b9f9-9ab414024f68@web.de>
On Sat, Mar 23, 2024 at 05:56:29PM +0100, Markus Elfring wrote:
> > Automatically cleaned up pointers need to be initialized before exiting
> > their scope. In this case, they need to be initialized to NULL before
> > any return statement.
>
> * May we expect that compilers should report that affected variables
> were only declared here instead of appropriately defined
> (despite of attempts for scope-based resource management)?
>
We disabled GCC's check for uninitialized variables a long time ago
because it had too many false positives.
> * Did you extend detection support in the source code analysis tool “Smatch”
> for a questionable implementation detail?
Yes. Smatch detects this as an uninitialized variable.
regards,
dan carpenter
next prev parent reply other threads:[~2024-03-24 10:43 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-21 14:42 [Intel-wired-lan] [PATCH v2 net] ice: Fix freeing uninitialized pointers Dan Carpenter
2024-03-21 14:42 ` Dan Carpenter
2024-03-21 15:34 ` [Intel-wired-lan] " Jiri Pirko
2024-03-21 15:34 ` Jiri Pirko
2024-03-21 15:49 ` [Intel-wired-lan] " Dan Carpenter
2024-03-21 15:49 ` Dan Carpenter
2024-03-21 20:05 ` [Intel-wired-lan] " Markus Elfring
2024-03-21 20:05 ` Markus Elfring
2024-03-22 5:32 ` [Intel-wired-lan] " Dan Carpenter
2024-03-22 5:32 ` Dan Carpenter
2024-03-22 10:10 ` [Intel-wired-lan] [v2] " Markus Elfring
2024-03-22 10:10 ` Markus Elfring
2024-03-22 12:57 ` [Intel-wired-lan] [PATCH v2 net] " Simon Horman
2024-03-22 12:57 ` Simon Horman
2024-03-23 16:56 ` [Intel-wired-lan] " Markus Elfring
2024-03-23 16:56 ` Markus Elfring
2024-03-24 10:43 ` Dan Carpenter [this message]
2024-03-24 10:43 ` Dan Carpenter
2024-03-24 13:22 ` [Intel-wired-lan] [v2] " Markus Elfring
2024-03-24 13:22 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f292facc-8a22-42e1-9a41-5ec8bd665cb7@moroto.mountain \
--to=dan.carpenter@linaro.org \
--cc=David.Laight@aculab.com \
--cc=Markus.Elfring@web.de \
--cc=aleksander.lobakin@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=dan.j.williams@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=himasekharx.reddy.pucha@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jic23@kernel.org \
--cc=jiri@resnulli.us \
--cc=julia.lawall@inria.fr \
--cc=keescook@chromium.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukasz.czapnik@intel.com \
--cc=maciej.fijalkowski@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=smatch@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.