From: Jiaxi Chen <jiaxi.chen@linux.intel.com>
To: Dave Hansen <dave.hansen@intel.com>
Cc: kvm@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com,
bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org,
hpa@zytor.com, seanjc@google.com, pbonzini@redhat.com,
ndesaulniers@google.com, alexandre.belloni@bootlin.com,
peterz@infradead.org, jpoimboe@kernel.org,
chang.seok.bae@intel.com, pawan.kumar.gupta@linux.intel.com,
babu.moger@amd.com, jmattson@google.com, sandipan.das@amd.com,
tony.luck@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com,
fenghua.yu@intel.com, keescook@chromium.org, nathan@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/6] x86: KVM: Advertise CMPccXADD CPUID to user space
Date: Wed, 23 Nov 2022 14:33:32 +0800 [thread overview]
Message-ID: <f2cf136e-bf38-54ce-a0dc-31b0192d1dd6@linux.intel.com> (raw)
In-Reply-To: <6d7fae50-ef3c-dc1e-336c-691095007117@intel.com>
On 11/21/2022 11:29 PM, Dave Hansen wrote:
> On 11/21/22 06:46, Jiaxi Chen wrote:
>> Features which has been enabled in kernel usually should be added to
>> /proc/cpuinfo.
>
> Features that the kernel *itself* is actually using always get in there.
> Things like "smep".
>
> But, things that the kernel "enables" but that only get used by
> userspace don't generally show up in /proc/cpuinfo.
>
> KVM is kinda a weird case. The kernel is making the feature available
> to guests, but it's not _using_ it in any meaningful way. To me, this
> seems much more akin to the features that are just available to
> userspace than something that the kernel is truly using.
>
> Also, these feature names are just long and ugly, and the "flags" line
> is already a human-*un*readable mess. I think we should just leave them
> out.
True and agree. As for these cpuids are not truly used by kernel except
for advertising to kvm userspace, we can hide them in /proc/cpuinfo by
overriding their name with "".
--
Regards,
Jiaxi
next prev parent reply other threads:[~2022-11-23 6:33 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-18 14:15 [PATCH v4 0/6] x86: KVM: Advertise CPUID of new Intel platform instructions to user space Jiaxi Chen
2022-11-18 14:15 ` [PATCH v4 1/6] x86: KVM: Advertise CMPccXADD CPUID " Jiaxi Chen
2022-11-18 16:47 ` Dave Hansen
2022-11-18 18:34 ` Borislav Petkov
2022-11-21 14:46 ` Jiaxi Chen
2022-11-21 15:29 ` Dave Hansen
2022-11-21 15:48 ` Sean Christopherson
2022-11-21 15:53 ` Borislav Petkov
2022-11-21 17:28 ` Sean Christopherson
2022-11-21 19:50 ` Borislav Petkov
2022-11-23 6:33 ` Jiaxi Chen [this message]
2022-11-21 15:38 ` Borislav Petkov
2022-11-23 7:46 ` Jiaxi Chen
2022-11-18 14:15 ` [PATCH v4 2/6] x86: KVM: Advertise AMX-FP16 " Jiaxi Chen
2022-11-18 14:15 ` [PATCH v4 3/6] x86: KVM: Advertise AVX-IFMA " Jiaxi Chen
2022-11-18 16:08 ` Sean Christopherson
2022-11-21 14:46 ` Jiaxi Chen
2022-11-18 14:15 ` [PATCH v4 4/6] x86: KVM: Advertise AVX-VNNI-INT8 " Jiaxi Chen
2022-11-18 17:17 ` Sean Christopherson
2022-11-21 15:06 ` Jiaxi Chen
2022-11-18 14:15 ` [PATCH v4 5/6] x86: KVM: Advertise AVX-NE-CONVERT " Jiaxi Chen
2022-11-18 14:15 ` [PATCH v4 6/6] x86: KVM: Advertise PREFETCHIT0/1 " Jiaxi Chen
2022-11-18 15:11 ` [PATCH v4 0/6] x86: KVM: Advertise CPUID of new Intel platform instructions " Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2cf136e-bf38-54ce-a0dc-31b0192d1dd6@linux.intel.com \
--to=jiaxi.chen@linux.intel.com \
--cc=alexandre.belloni@bootlin.com \
--cc=babu.moger@amd.com \
--cc=bp@alien8.de \
--cc=chang.seok.bae@intel.com \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=jmattson@google.com \
--cc=jpoimboe@kernel.org \
--cc=keescook@chromium.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=pawan.kumar.gupta@linux.intel.com \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=sandipan.das@amd.com \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.