* [PATCH v8 0/4] xen/arm: scmi: introduce SCI SCMI SMC single-agent support
@ 2025-09-03 13:18 Oleksii Moisieiev
2025-09-03 13:18 ` [PATCH v8 1/4] xen/arm: add generic SCI subsystem Oleksii Moisieiev
` (4 more replies)
0 siblings, 5 replies; 9+ messages in thread
From: Oleksii Moisieiev @ 2025-09-03 13:18 UTC (permalink / raw)
To: xen-devel@lists.xenproject.org
Cc: Andrew Cooper, Anthony PERARD, Bertrand Marquis, Jan Beulich,
Juergen Gross, Julien Grall, Michal Orzel, Oleksii Moisieiev,
Roger Pau Monné, Stefano Stabellini, Volodymyr Babchuk,
Grygorii Strashko
Inroducing V8 patch series on top of the Xen version 4.20-rc2
which includes implementation of the SCI SCMI SMC single-agent support.
This patch series is the first chunk of the
"xen/arm: scmi: introduce SCI SCMI SMC multi-agent support" which can
be found at [0]
SCMI-multiagent support will be provided as the followup patch series.
[0] https://lore.kernel.org/xen-devel/cover.1753184487.git.oleksii_moisieiev@epam.com/
Patch 1 "xen/arm: add generic SCI subsystem"
- rebased and refactored
- introduced DEVICE_ARM_SCI DT device class and used for SCI drivers probing
instead of custom,
linker sections based implementation.
- added SCI API for Dom0 DT handling, instead of manipulating with ARM arch
dom0 code directly.
- RFC changes in XEN_DOMCTL_assign_device OP processing
- Introduce arch_handle_passthrough_prop call to handle arm specific
nodes
Patch 2 "xen/arm: scmi-smc: update to be used under sci subsystem"
- update driver introduced by commit 3e322bef8bc0 ("xen/arm: firmware: Add SCMI
over SMC calls
handling layer") be used under sci subsystem.
- no functional changes in general
Patch 3 "xen/arm: scmi-smc: passthrough SCMI SMC to guest domain
This is new change which allows passthrough SCMI SMC, single agent interface to
guest domain
cover use case "thin Dom0 with guest domain, which serves as Driver domain".
See patch commit message for full description.
Patch 4 - docs: arm: add docs for SCMI over SMC calls forwarding
driver
- add documentation section for Simple Arm SCMI over SMC calls
forwarding driver.
Code can be found at:
https://github.com/oleksiimoisieiev/xen/tree/scmi_upstrv5
[1] RFC v2:
http://patchwork.kernel.org/project/xen-devel/cover/cover.1644341635.git.oleksii_moisieiev@epam.com/
[2] RFC v3:
https://patchwork.kernel.org/project/xen-devel/patch/20250311111618.1850927-1-grygorii_strashko@epam.com
SCMI spec:
https://developer.arm.com/documentation/den0056/e/?lang=en
SCMI bindings:
https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/firmware/arm,scmi.yaml
https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/access-controllers/access-controllers.yaml
Reference EL3 FW:
RPI5: https://github.com/xen-troops/arm-trusted-firmware/commits/rpi5_dev/
Renesas v4h:
https://github.com/GrygiriiS/arm-trusted-firmware/commits/rcar_gen4_v2.7_v4x-scmi_upd/
base-commit: dbe60f244c (Update Xen to 4.21, 2025-02-21)
Changes in v8:
- reneregated {helpers/types}.gen.go, dropped unneeded parameters
Changes in v7:
- fix sci_handl_call to make changes more readable
- fix build error when DOM0LESS_BUILD is disabled (removed
arch_handle_passthrough_prop from the header)
- sort headers in alphabetical order in sci.h
- sort headers in scmi-smc.c file
- Fix commit description.
- Move scmi-smc-passthrough definition to match alphaberical order
- remove unneeded initialization with NULL
- changed u64 to uint64_t
- Send warning if iomem permit access was failed
- fixed typos
Changes in v6:
- rebase on top of the latest master
- fix return value of sci_dt_finalize() call
- add R-b tag
- added generated helpers and types go files
- rename cmdline parameter to scmi-smc-passthrough
- fix goto tag in parse_arm_sci_config
- add link to the scmi bindings used in the doc
- remove mentions about HVC calls from doc
- rename cmdline parameter to scmi-smc-passthrough
Changes in v5:
- update Maintainers file. Set role as a Reviewer
- rebased on the latest master branch
- Introduce arch_handle_passthrough_prop call to handle arm specific nodes
- rename dom0_scmi_smc_passthrough to scmi_smc_passthrough
- rename dom0_scmi_smc_passthrough in documentation
Changes in v4:
- fix SPDX-License
- rename DEVICE_ARM_SCI DT device class to FIRMWARE_DEVICE
- move XEN_DOMCTL_assign_device code in separate patch
- Add documentation for SCI SCMI drivers
- xl.cfg doc
- fix comments from Stefano Stabellini
- fix toolstack code as sugested by Anthony PERARD
- use MATCH_OPTION()
- move arm_sci struct and cfg params in "arch_arm"
- add SCMI passthrough for dom0less case
Grygorii Strashko (3):
xen/arm: scmi-smc: update to be used under sci subsystem
xen/arm: scmi-smc: passthrough SCMI SMC to domain, single agent
docs: arm: add docs for SCMI over SMC calls forwarding driver
Oleksii Moisieiev (1):
xen/arm: add generic SCI subsystem
MAINTAINERS | 6 +
.../arm/firmware/arm-scmi.rst | 180 ++++++++++++++++
docs/hypervisor-guide/arm/index.rst | 9 +
docs/hypervisor-guide/index.rst | 1 +
docs/man/xl.cfg.5.pod.in | 34 +++
docs/misc/arm/device-tree/booting.txt | 15 ++
docs/misc/xen-command-line.pandoc | 9 +
tools/golang/xenlight/helpers.gen.go | 35 +++
tools/golang/xenlight/types.gen.go | 11 +
tools/include/libxl.h | 5 +
tools/libs/light/libxl_arm.c | 14 ++
tools/libs/light/libxl_types.idl | 10 +
tools/xl/xl_parse.c | 36 ++++
xen/arch/arm/device.c | 5 +
xen/arch/arm/dom0less-build.c | 40 ++++
xen/arch/arm/domain.c | 12 +-
xen/arch/arm/domain_build.c | 8 +
xen/arch/arm/firmware/Kconfig | 25 ++-
xen/arch/arm/firmware/Makefile | 1 +
xen/arch/arm/firmware/sci.c | 154 ++++++++++++++
xen/arch/arm/firmware/scmi-smc.c | 194 +++++++++++++----
xen/arch/arm/include/asm/domain.h | 5 +
xen/arch/arm/include/asm/firmware/sci.h | 200 ++++++++++++++++++
xen/arch/arm/include/asm/firmware/scmi-smc.h | 41 ----
xen/arch/arm/vsmc.c | 4 +-
xen/common/device-tree/dom0less-build.c | 4 +
xen/include/asm-generic/device.h | 1 +
xen/include/public/arch-arm.h | 5 +
xen/include/xen/dom0less-build.h | 3 +
29 files changed, 982 insertions(+), 85 deletions(-)
create mode 100644 docs/hypervisor-guide/arm/firmware/arm-scmi.rst
create mode 100644 docs/hypervisor-guide/arm/index.rst
create mode 100644 xen/arch/arm/firmware/sci.c
create mode 100644 xen/arch/arm/include/asm/firmware/sci.h
delete mode 100644 xen/arch/arm/include/asm/firmware/scmi-smc.h
--
2.34.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v8 1/4] xen/arm: add generic SCI subsystem
2025-09-03 13:18 [PATCH v8 0/4] xen/arm: scmi: introduce SCI SCMI SMC single-agent support Oleksii Moisieiev
@ 2025-09-03 13:18 ` Oleksii Moisieiev
2025-09-03 13:18 ` [PATCH v8 4/4] docs: arm: add docs for SCMI over SMC calls forwarding driver Oleksii Moisieiev
` (3 subsequent siblings)
4 siblings, 0 replies; 9+ messages in thread
From: Oleksii Moisieiev @ 2025-09-03 13:18 UTC (permalink / raw)
To: xen-devel@lists.xenproject.org
Cc: Andrew Cooper, Anthony PERARD, Bertrand Marquis, Jan Beulich,
Juergen Gross, Julien Grall, Michal Orzel, Oleksii Moisieiev,
Roger Pau Monné, Stefano Stabellini, Volodymyr Babchuk,
Grygorii Strashko
This patch adds the basic framework for ARM SCI mediator. SCI is System
Control Interface, which is designed to redirect requests from the Domains
to ARM specific Firmware (for example SCMI). This will allow the devices,
passed-through to the different Domains, to access to the System resources
(such as clocks/resets etc) by sending requests to the firmware.
ARM SCI subsystem allows to implement different SCI drivers to handle
specific ARM firmware interfaces (like ARM SCMI) and mediate requests
-between the Domains and the Firmware. Also it allows SCI drivers to perform
proper action during Domain creation/destruction which is vital for
handling use cases like Domain reboot.
This patch introduces new DEVICE_FIRMWARE device subclass for probing SCI
drivers basing on device tree, SCI drivers register itself with
DT_DEVICE_START/END macro. On init - the SCI drivers should register its
SCI ops with sci_register(). Only one SCI driver can be supported.
At run-time, the following SCI API calls are introduced:
- sci_domain_sanitise_config() called from arch_sanitise_domain_config()
- sci_domain_init() called from arch_domain_create()
- sci_relinquish_resources() called from domain_relinquish_resources()
- sci_domain_destroy() called from arch_domain_destroy()
- sci_handle_call() called from vsmccc_handle_call()
- sci_dt_handle_node()
- sci_dt_finalize() called from handle_node() (Dom0 DT)
Signed-off-by: Oleksii Moisieiev <oleksii_moisieiev@epam.com>
Signed-off-by: Grygorii Strashko <grygorii_strashko@epam.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
---
(no changes since v7)
Changes in v7:
- fix sci_handl_call to make changes more readable
- fix build error when DOM0LESS_BUILD is disabled (removed
arch_handle_passthrough_prop from the header)
- sort headers in alphabetical order in sci.h
Changes in v6:
- rebase on top of the latest master
- fix return value of sci_dt_finalize() call
Changes in v5:
- update Maintainers file. Set role as a Reviewer
- rebased on the latest master branch
- Introduce arch_handle_passthrough_prop call to handle arm specific nodes
Changes in v4:
- fix SPDX-License
- rename DEVICE_ARM_SCI DT device class to FIRMWARE_DEVICE
- move XEN_DOMCTL_assign_device code in separate patch
- Add documentation for SCI SCMI drivers
MAINTAINERS | 6 +
xen/arch/arm/device.c | 5 +
xen/arch/arm/dom0less-build.c | 8 +
xen/arch/arm/domain.c | 12 +-
xen/arch/arm/domain_build.c | 8 +
xen/arch/arm/firmware/Kconfig | 8 +
xen/arch/arm/firmware/Makefile | 1 +
xen/arch/arm/firmware/sci.c | 154 ++++++++++++++++++
xen/arch/arm/include/asm/domain.h | 5 +
xen/arch/arm/include/asm/firmware/sci.h | 200 ++++++++++++++++++++++++
xen/arch/arm/vsmc.c | 3 +-
xen/common/device-tree/dom0less-build.c | 4 +
xen/include/asm-generic/device.h | 1 +
xen/include/public/arch-arm.h | 4 +
xen/include/xen/dom0less-build.h | 3 +
15 files changed, 420 insertions(+), 2 deletions(-)
create mode 100644 xen/arch/arm/firmware/sci.c
create mode 100644 xen/arch/arm/include/asm/firmware/sci.h
diff --git a/MAINTAINERS b/MAINTAINERS
index c4886c1159..31dbba54bb 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -509,6 +509,12 @@ R: George Dunlap <gwd@xenproject.org>
S: Supported
F: xen/common/sched/
+SCI MEDIATORS
+R: Oleksii Moisieiev <oleksii_moisieiev@epam.com>
+S: Supported
+F: xen/arch/arm/firmware/sci.c
+F: xen/arch/arm/include/asm/firmware/sci.h
+
SEABIOS UPSTREAM
M: Wei Liu <wl@xen.org>
S: Supported
diff --git a/xen/arch/arm/device.c b/xen/arch/arm/device.c
index 11523750ae..74b54cad34 100644
--- a/xen/arch/arm/device.c
+++ b/xen/arch/arm/device.c
@@ -13,6 +13,7 @@
#include <xen/iocap.h>
#include <xen/lib.h>
+#include <asm/firmware/sci.h>
#include <asm/setup.h>
int map_irq_to_domain(struct domain *d, unsigned int irq,
@@ -303,6 +304,10 @@ int handle_device(struct domain *d, struct dt_device_node *dev, p2m_type_t p2mt,
return res;
}
}
+
+ res = sci_assign_dt_device(d, dev);
+ if ( res )
+ return res;
}
res = map_device_irqs_to_domain(d, dev, own_device, irq_ranges);
diff --git a/xen/arch/arm/dom0less-build.c b/xen/arch/arm/dom0less-build.c
index c8d07213e2..0094cf9e40 100644
--- a/xen/arch/arm/dom0less-build.c
+++ b/xen/arch/arm/dom0less-build.c
@@ -22,6 +22,7 @@
#include <asm/arm64/sve.h>
#include <asm/domain_build.h>
+#include <asm/firmware/sci.h>
#include <asm/grant_table.h>
#include <asm/setup.h>
@@ -272,6 +273,12 @@ int __init init_vuart(struct domain *d, struct kernel_info *kinfo,
return rc;
}
+int __init arch_handle_passthrough_prop(struct kernel_info *kinfo,
+ struct dt_device_node *node)
+{
+ return sci_assign_dt_device(kinfo->bd.d, node);
+}
+
int __init arch_parse_dom0less_node(struct dt_device_node *node,
struct boot_domain *bd)
{
@@ -281,6 +288,7 @@ int __init arch_parse_dom0less_node(struct dt_device_node *node,
d_cfg->arch.gic_version = XEN_DOMCTL_CONFIG_GIC_NATIVE;
d_cfg->flags |= XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap;
+ d_cfg->arch.arm_sci_type = XEN_DOMCTL_CONFIG_ARM_SCI_NONE;
if ( !dt_property_read_u32(node, "nr_spis", &d_cfg->arch.nr_spis) )
{
diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
index 863ae18157..1a8585d02b 100644
--- a/xen/arch/arm/domain.c
+++ b/xen/arch/arm/domain.c
@@ -24,6 +24,7 @@
#include <asm/platform.h>
#include <asm/procinfo.h>
#include <asm/regs.h>
+#include <asm/firmware/sci.h>
#include <asm/tee/tee.h>
#include <asm/vfp.h>
#include <asm/vgic.h>
@@ -699,7 +700,7 @@ int arch_sanitise_domain_config(struct xen_domctl_createdomain *config)
return -EINVAL;
}
- return 0;
+ return sci_domain_sanitise_config(config);
}
int arch_domain_create(struct domain *d,
@@ -791,6 +792,9 @@ int arch_domain_create(struct domain *d,
d->arch.sve_vl = config->arch.sve_vl;
#endif
+ if ( (rc = sci_domain_init(d, config)) != 0 )
+ goto fail;
+
return 0;
fail:
@@ -851,6 +855,7 @@ void arch_domain_destroy(struct domain *d)
domain_vgic_free(d);
domain_vuart_free(d);
free_xenheap_page(d->shared_info);
+ sci_domain_destroy(d);
#ifdef CONFIG_ACPI
free_xenheap_pages(d->arch.efi_acpi_table,
get_order_from_bytes(d->arch.efi_acpi_len));
@@ -1044,6 +1049,7 @@ enum {
PROG_p2m_root,
PROG_p2m,
PROG_p2m_pool,
+ PROG_sci,
PROG_done,
};
@@ -1103,6 +1109,10 @@ int domain_relinquish_resources(struct domain *d)
ret = relinquish_p2m_mapping(d);
if ( ret )
return ret;
+ PROGRESS(sci):
+ ret = sci_relinquish_resources(d);
+ if ( ret )
+ return ret;
PROGRESS(p2m_root):
/*
diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index a9e4153e3c..039aa71439 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -28,6 +28,7 @@
#include <asm/setup.h>
#include <asm/tee/tee.h>
#include <asm/pci.h>
+#include <asm/firmware/sci.h>
#include <asm/platform.h>
#include <asm/psci.h>
#include <asm/setup.h>
@@ -1640,6 +1641,9 @@ static int __init handle_node(struct domain *d, struct kernel_info *kinfo,
return 0;
}
+ if ( sci_dt_handle_node(d, node) )
+ return 0;
+
/*
* The vGIC does not support routing hardware PPIs to guest. So
* we need to skip any node using PPIs.
@@ -1740,6 +1744,10 @@ static int __init handle_node(struct domain *d, struct kernel_info *kinfo,
if ( res )
return res;
+ res = sci_dt_finalize(d, kinfo->fdt);
+ if ( res )
+ return res;
+
/*
* Create a second memory node to store the ranges covering
* reserved-memory regions.
diff --git a/xen/arch/arm/firmware/Kconfig b/xen/arch/arm/firmware/Kconfig
index 817da745fd..fc7918c7fc 100644
--- a/xen/arch/arm/firmware/Kconfig
+++ b/xen/arch/arm/firmware/Kconfig
@@ -1,3 +1,11 @@
+config ARM_SCI
+ bool
+ depends on ARM
+ help
+ This option enables generic Arm SCI (System Control Interface) mediators
+ support. It allows domains to control system resources via one of
+ Arm SCI mediators drivers implemented in XEN, like SCMI.
+
menu "Firmware Drivers"
config SCMI_SMC
diff --git a/xen/arch/arm/firmware/Makefile b/xen/arch/arm/firmware/Makefile
index a5e4542666..71bdefc24a 100644
--- a/xen/arch/arm/firmware/Makefile
+++ b/xen/arch/arm/firmware/Makefile
@@ -1 +1,2 @@
+obj-$(CONFIG_ARM_SCI) += sci.o
obj-$(CONFIG_SCMI_SMC) += scmi-smc.o
diff --git a/xen/arch/arm/firmware/sci.c b/xen/arch/arm/firmware/sci.c
new file mode 100644
index 0000000000..e1522e10e2
--- /dev/null
+++ b/xen/arch/arm/firmware/sci.c
@@ -0,0 +1,154 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+/*
+ * Generic part of the SCI (System Control Interface) subsystem.
+ *
+ * Oleksii Moisieiev <oleksii_moisieiev@epam.com>
+ * Copyright (c) 2025 EPAM Systems
+ */
+
+#include <xen/acpi.h>
+#include <xen/errno.h>
+#include <xen/init.h>
+#include <xen/sched.h>
+#include <xen/types.h>
+
+#include <asm/firmware/sci.h>
+
+static const struct sci_mediator_ops __read_mostly *cur_mediator;
+
+int sci_register(const struct sci_mediator_ops *ops)
+{
+ if ( cur_mediator )
+ return -EEXIST;
+
+ if ( !ops->domain_init || !ops->domain_destroy || !ops->handle_call )
+ return -EINVAL;
+
+ cur_mediator = ops;
+
+ return 0;
+};
+
+bool sci_handle_call(struct cpu_user_regs *args)
+{
+ if ( unlikely(!cur_mediator) )
+ return false;
+
+ return cur_mediator->handle_call(args);
+}
+
+int sci_domain_init(struct domain *d, struct xen_domctl_createdomain *config)
+{
+ if ( !cur_mediator )
+ return 0;
+
+ return cur_mediator->domain_init(d, config);
+}
+
+int sci_domain_sanitise_config(struct xen_domctl_createdomain *config)
+{
+ if ( !cur_mediator )
+ return 0;
+
+ if ( !cur_mediator->domain_sanitise_config )
+ return 0;
+
+ return cur_mediator->domain_sanitise_config(config);
+}
+
+void sci_domain_destroy(struct domain *d)
+{
+ if ( !cur_mediator )
+ return;
+
+ cur_mediator->domain_destroy(d);
+}
+
+int sci_relinquish_resources(struct domain *d)
+{
+ if ( !cur_mediator )
+ return 0;
+
+ if ( !cur_mediator->relinquish_resources )
+ return 0;
+
+ return cur_mediator->relinquish_resources(d);
+}
+
+bool sci_dt_handle_node(struct domain *d, struct dt_device_node *node)
+{
+ if ( !cur_mediator )
+ return 0;
+
+ if ( !cur_mediator->dom0_dt_handle_node )
+ return 0;
+
+ return cur_mediator->dom0_dt_handle_node(d, node);
+}
+
+int sci_dt_finalize(struct domain *d, void *fdt)
+{
+ if ( !cur_mediator )
+ return 0;
+
+ if ( !cur_mediator->dom0_dt_finalize )
+ return 0;
+
+ return cur_mediator->dom0_dt_finalize(d, fdt);
+}
+
+int sci_assign_dt_device(struct domain *d, struct dt_device_node *dev)
+{
+ struct dt_phandle_args ac_spec;
+ int index = 0;
+ int ret;
+
+ if ( !cur_mediator )
+ return 0;
+
+ if ( !cur_mediator->assign_dt_device )
+ return 0;
+
+ while ( !dt_parse_phandle_with_args(dev, "access-controllers",
+ "#access-controller-cells", index,
+ &ac_spec) )
+ {
+ printk(XENLOG_DEBUG "sci: assign device %s to %pd\n",
+ dt_node_full_name(dev), d);
+
+ ret = cur_mediator->assign_dt_device(d, &ac_spec);
+ if ( ret )
+ return ret;
+
+ index++;
+ }
+
+ return 0;
+}
+
+static int __init sci_init(void)
+{
+ struct dt_device_node *np;
+ unsigned int num_sci = 0;
+ int rc;
+
+ dt_for_each_device_node(dt_host, np)
+ {
+ rc = device_init(np, DEVICE_FIRMWARE, NULL);
+ if ( !rc && num_sci )
+ {
+ printk(XENLOG_ERR
+ "SCMI: Only one SCI controller is supported. found second %s\n",
+ np->name);
+ return -EOPNOTSUPP;
+ }
+ else if ( !rc )
+ num_sci++;
+ else if ( rc != -EBADF && rc != -ENODEV )
+ return rc;
+ }
+
+ return 0;
+}
+
+__initcall(sci_init);
diff --git a/xen/arch/arm/include/asm/domain.h b/xen/arch/arm/include/asm/domain.h
index a3487ca713..af3e168374 100644
--- a/xen/arch/arm/include/asm/domain.h
+++ b/xen/arch/arm/include/asm/domain.h
@@ -120,6 +120,11 @@ struct arch_domain
#ifdef CONFIG_TEE
void *tee;
#endif
+#ifdef CONFIG_ARM_SCI
+ bool sci_enabled;
+ /* ARM SCI driver's specific data */
+ void *sci_data;
+#endif
} __cacheline_aligned;
diff --git a/xen/arch/arm/include/asm/firmware/sci.h b/xen/arch/arm/include/asm/firmware/sci.h
new file mode 100644
index 0000000000..66c88cec3c
--- /dev/null
+++ b/xen/arch/arm/include/asm/firmware/sci.h
@@ -0,0 +1,200 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+/*
+ * Generic ARM SCI (System Control Interface) subsystem.
+ *
+ * Oleksii Moisieiev <oleksii_moisieiev@epam.com>
+ * Copyright (c) 2025 EPAM Systems
+ */
+
+#ifndef __ASM_ARM_SCI_H
+#define __ASM_ARM_SCI_H
+
+#include <xen/device_tree.h>
+#include <xen/errno.h>
+#include <xen/lib.h>
+#include <xen/sched.h>
+#include <xen/types.h>
+
+#ifdef CONFIG_ARM_SCI
+
+struct sci_mediator_ops {
+ /*
+ * Called during domain construction. If it is requested to enable
+ * SCI support, so SCI driver can create own structures for the new domain
+ * and inform firmware about new domain (if required).
+ * Mandatory.
+ */
+ int (*domain_init)(struct domain *d,
+ struct xen_domctl_createdomain *config);
+
+ /*
+ * Called during domain construction. The SCI driver uses
+ * it to sanitize domain SCI configuration parameters.
+ * Optional.
+ */
+ int (*domain_sanitise_config)(struct xen_domctl_createdomain *config);
+
+ /*
+ * Called during domain destruction, releases all resources, that
+ * were allocated for domain.
+ * Mandatory.
+ */
+ void (*domain_destroy)(struct domain *d);
+
+ /*
+ * Called during domain destruction to relinquish resources used
+ * by SCI driver itself and request resources releasing from firmware.
+ * Optional.
+ */
+ int (*relinquish_resources)(struct domain *d);
+
+ /* SMC/HVC Handle callback */
+ bool (*handle_call)(struct cpu_user_regs *regs);
+
+ /*
+ * Dom0 DT nodes handling callback so SCI driver can detect DT nodes it
+ * need to handle and decide if those nodes need to be provided to Dom0.
+ * Optional.
+ */
+ bool (*dom0_dt_handle_node)(struct domain *d, struct dt_device_node *node);
+
+ /*
+ * SCI driver callback called at the end of Dom0 DT generation, so
+ * it can perform steps to modify DT to enable/disable SCI
+ * functionality for Dom0.
+ */
+ int (*dom0_dt_finalize)(struct domain *d, void *fdt);
+
+ /*
+ * SCI driver callback called when DT device is passed through to guest,
+ * so SCI driver can enable device access to the domain if SCI FW provides
+ * Device specific access control functionality.
+ * Optional.
+ */
+ int (*assign_dt_device)(struct domain *d, struct dt_phandle_args *ac_spec);
+};
+
+
+static inline bool sci_domain_is_enabled(struct domain *d)
+{
+ return d->arch.sci_enabled;
+}
+
+/*
+ * Register SCI subsystem ops.
+ *
+ * Register SCI drivers operation and so enable SCI functionality.
+ * Only one SCI driver is supported.
+ */
+int sci_register(const struct sci_mediator_ops *ops);
+
+/*
+ * Initialize SCI functionality for domain if configured.
+ *
+ * Initialization routine to enable SCI functionality for the domain.
+ * The SCI configuration data and decision about enabling SCI functionality
+ * for the domain is SCI driver specific.
+ */
+int sci_domain_init(struct domain *d, struct xen_domctl_createdomain *config);
+
+/*
+ * Sanitise domain configuration parameters.
+ *
+ */
+int sci_domain_sanitise_config(struct xen_domctl_createdomain *config);
+
+/*
+ * Destroy SCI domain instance.
+ */
+void sci_domain_destroy(struct domain *d);
+
+/*
+ * Free resources assigned to the certain domain.
+ */
+int sci_relinquish_resources(struct domain *d);
+
+/*
+ * SMC/HVC Handle callback.
+ *
+ * SCI driver acts as SMC/HVC server for the registered domains and
+ * does redirection of the domain calls to the SCI firmware,
+ * such as ARM TF-A or similar.
+ */
+bool sci_handle_call(struct cpu_user_regs *regs);
+
+/*
+ * Dom0 DT nodes handling function.
+ *
+ * Allows SCI driver to detect DT nodes it need to handle and decide if
+ * those nodes need to be provided to Dom0.
+ */
+bool sci_dt_handle_node(struct domain *d, struct dt_device_node *node);
+
+/*
+ * Dom0 DT generation finalize.
+ *
+ * Called at the end of Dom0 DT generation, so SCI driver can perform steps
+ * to modify DT to enable/disable SCI functionality for Dom0.
+ */
+int sci_dt_finalize(struct domain *d, void *fdt);
+
+/*
+ * Assign DT device to domain.
+ *
+ * Called when DT device is passed through to guest, so SCI driver can enable
+ * device access to the domain if SCI FW provides "Device specific access
+ * control" functionality.
+ */
+int sci_assign_dt_device(struct domain *d, struct dt_device_node *dev);
+#else
+
+static inline bool sci_domain_is_enabled(struct domain *d)
+{
+ return false;
+}
+
+static inline int sci_domain_init(struct domain *d,
+ struct xen_domctl_createdomain *config)
+{
+ return 0;
+}
+
+static inline int
+sci_domain_sanitise_config(struct xen_domctl_createdomain *config)
+{
+ return 0;
+}
+
+static inline void sci_domain_destroy(struct domain *d)
+{}
+
+static inline int sci_relinquish_resources(struct domain *d)
+{
+ return 0;
+}
+
+static inline bool sci_handle_call(struct cpu_user_regs *args)
+{
+ return false;
+}
+
+static inline bool sci_dt_handle_node(struct domain *d,
+ struct dt_device_node *node)
+{
+ return false;
+}
+
+static inline int sci_dt_finalize(struct domain *d, void *fdt)
+{
+ return 0;
+}
+
+static inline int sci_assign_dt_device(struct domain *d,
+ struct dt_device_node *dev)
+{
+ return 0;
+}
+
+#endif /* CONFIG_ARM_SCI */
+
+#endif /* __ASM_ARM_SCI_H */
diff --git a/xen/arch/arm/vsmc.c b/xen/arch/arm/vsmc.c
index 6081f14ed0..4095171533 100644
--- a/xen/arch/arm/vsmc.c
+++ b/xen/arch/arm/vsmc.c
@@ -12,6 +12,7 @@
#include <public/arch-arm/smccc.h>
#include <asm/cpuerrata.h>
#include <asm/cpufeature.h>
+#include <asm/firmware/sci.h>
#include <asm/monitor.h>
#include <asm/regs.h>
#include <asm/smccc.h>
@@ -232,7 +233,7 @@ static bool handle_sip(struct cpu_user_regs *regs)
if ( platform_smc(regs) )
return true;
- return scmi_handle_smc(regs);
+ return (scmi_handle_smc(regs)) ? true : sci_handle_call(regs);
}
/*
diff --git a/xen/common/device-tree/dom0less-build.c b/xen/common/device-tree/dom0less-build.c
index badc227031..aaa5e9b22c 100644
--- a/xen/common/device-tree/dom0less-build.c
+++ b/xen/common/device-tree/dom0less-build.c
@@ -228,6 +228,10 @@ static int __init handle_passthrough_prop(struct kernel_info *kinfo,
if ( res < 0 )
return res;
+ res = arch_handle_passthrough_prop(kinfo, node);
+ if ( res )
+ return res;
+
/* If xen_force, we allow assignment of devices without IOMMU protection. */
if ( xen_force && !dt_device_is_protected(node) )
return 0;
diff --git a/xen/include/asm-generic/device.h b/xen/include/asm-generic/device.h
index 3bd97e33c5..cb13f7faea 100644
--- a/xen/include/asm-generic/device.h
+++ b/xen/include/asm-generic/device.h
@@ -18,6 +18,7 @@ enum device_class
DEVICE_IOMMU,
DEVICE_INTERRUPT_CONTROLLER,
DEVICE_PCI_HOSTBRIDGE,
+ DEVICE_FIRMWARE,
/* Use for error */
DEVICE_UNKNOWN,
};
diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h
index e2412a1747..e7a17ede3e 100644
--- a/xen/include/public/arch-arm.h
+++ b/xen/include/public/arch-arm.h
@@ -327,6 +327,8 @@ DEFINE_XEN_GUEST_HANDLE(vcpu_guest_context_t);
#define XEN_DOMCTL_CONFIG_TEE_OPTEE 1
#define XEN_DOMCTL_CONFIG_TEE_FFA 2
+#define XEN_DOMCTL_CONFIG_ARM_SCI_NONE 0
+
struct xen_arch_domainconfig {
/* IN/OUT */
uint8_t gic_version;
@@ -350,6 +352,8 @@ struct xen_arch_domainconfig {
*
*/
uint32_t clock_frequency;
+ /* IN */
+ uint8_t arm_sci_type;
};
#endif /* __XEN__ || __XEN_TOOLS__ */
diff --git a/xen/include/xen/dom0less-build.h b/xen/include/xen/dom0less-build.h
index 408859e325..faaf660424 100644
--- a/xen/include/xen/dom0less-build.h
+++ b/xen/include/xen/dom0less-build.h
@@ -62,6 +62,9 @@ void set_domain_type(struct domain *d, struct kernel_info *kinfo);
int init_intc_phandle(struct kernel_info *kinfo, const char *name,
const int node_next, const void *pfdt);
+int arch_handle_passthrough_prop(struct kernel_info *kinfo,
+ struct dt_device_node *node);
+
#else /* !CONFIG_DOM0LESS_BOOT */
static inline void create_domUs(void) {}
--
2.34.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH v8 2/4] xen/arm: scmi-smc: update to be used under sci subsystem
2025-09-03 13:18 [PATCH v8 0/4] xen/arm: scmi: introduce SCI SCMI SMC single-agent support Oleksii Moisieiev
` (2 preceding siblings ...)
2025-09-03 13:18 ` [PATCH v8 3/4] xen/arm: scmi-smc: passthrough SCMI SMC to domain, single agent Oleksii Moisieiev
@ 2025-09-03 13:18 ` Oleksii Moisieiev
2025-09-03 21:24 ` [PATCH v8 0/4] xen/arm: scmi: introduce SCI SCMI SMC single-agent support Stefano Stabellini
4 siblings, 0 replies; 9+ messages in thread
From: Oleksii Moisieiev @ 2025-09-03 13:18 UTC (permalink / raw)
To: xen-devel@lists.xenproject.org
Cc: Andrew Cooper, Anthony PERARD, Bertrand Marquis, Jan Beulich,
Juergen Gross, Julien Grall, Michal Orzel, Oleksii Moisieiev,
Roger Pau Monné, Stefano Stabellini, Volodymyr Babchuk,
Grygorii Strashko
From: Grygorii Strashko <grygorii_strashko@epam.com>
The introduced SCI (System Control Interface) subsystem provides unified
interface to integrate in Xen SCI drivers which adds support for ARM
firmware (EL3, SCP) based software interfaces (like SCMI) that are used in
system management. The SCI subsystem allows to add drivers for different FW
interfaces or have different drivers for the same FW interface (for example,
SCMI with different transports).
This patch updates SCMI over SMC calls handling layer, introduced by
commit 3e322bef8bc0 ("xen/arm: firmware: Add SCMI over SMC calls handling
layer"), to be SCI driver:
- convert to DT device;
- convert to SCI Xen interface.
There are no functional changes in general, the driver is just adopted
to the SCI interface.
Signed-off-by: Grygorii Strashko <grygorii_strashko@epam.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
Signed-off-by: Oleksii Moisieiev <oleksii_moisieiev@epam.com>
---
(no changes since v7)
Changes in v7:
- sort headers in scmi-smc.c file
Changes in v6:
- add R-b tag
xen/arch/arm/firmware/Kconfig | 13 ++-
xen/arch/arm/firmware/scmi-smc.c | 93 +++++++++++---------
xen/arch/arm/include/asm/firmware/scmi-smc.h | 41 ---------
xen/arch/arm/vsmc.c | 3 +-
xen/include/public/arch-arm.h | 1 +
5 files changed, 64 insertions(+), 87 deletions(-)
delete mode 100644 xen/arch/arm/include/asm/firmware/scmi-smc.h
diff --git a/xen/arch/arm/firmware/Kconfig b/xen/arch/arm/firmware/Kconfig
index fc7918c7fc..bbf88fbb9a 100644
--- a/xen/arch/arm/firmware/Kconfig
+++ b/xen/arch/arm/firmware/Kconfig
@@ -8,9 +8,18 @@ config ARM_SCI
menu "Firmware Drivers"
+choice
+ prompt "ARM SCI driver type"
+ default SCMI_SMC
+ help
+ Choose which ARM SCI driver to enable.
+
+config ARM_SCI_NONE
+ bool "none"
+
config SCMI_SMC
bool "Forward SCMI over SMC calls from hwdom to EL3 firmware"
- default y
+ select ARM_SCI
help
This option enables basic awareness for SCMI calls using SMC as
doorbell mechanism and Shared Memory for transport ("arm,scmi-smc"
@@ -18,4 +27,6 @@ config SCMI_SMC
firmware node is used to trap and forward corresponding SCMI SMCs
to firmware running at EL3, for calls coming from the hardware domain.
+endchoice
+
endmenu
diff --git a/xen/arch/arm/firmware/scmi-smc.c b/xen/arch/arm/firmware/scmi-smc.c
index 33473c04b1..4c5df714c2 100644
--- a/xen/arch/arm/firmware/scmi-smc.c
+++ b/xen/arch/arm/firmware/scmi-smc.c
@@ -16,12 +16,12 @@
#include <xen/sched.h>
#include <xen/types.h>
+#include <asm/device.h>
+#include <asm/firmware/sci.h>
#include <asm/smccc.h>
-#include <asm/firmware/scmi-smc.h>
#define SCMI_SMC_ID_PROP "arm,smc-id"
-static bool __ro_after_init scmi_enabled;
static uint32_t __ro_after_init scmi_smc_id;
/*
@@ -41,14 +41,11 @@ static bool scmi_is_valid_smc_id(uint32_t fid)
*
* Returns true if SMC was handled (regardless of response), false otherwise.
*/
-bool scmi_handle_smc(struct cpu_user_regs *regs)
+static bool scmi_handle_smc(struct cpu_user_regs *regs)
{
uint32_t fid = (uint32_t)get_user_reg(regs, 0);
struct arm_smccc_res res;
- if ( !scmi_enabled )
- return false;
-
if ( !scmi_is_valid_smc_id(fid) )
return false;
@@ -78,49 +75,45 @@ bool scmi_handle_smc(struct cpu_user_regs *regs)
return true;
}
-static int __init scmi_check_smccc_ver(void)
+static int scmi_smc_domain_init(struct domain *d,
+ struct xen_domctl_createdomain *config)
{
- if ( smccc_ver < ARM_SMCCC_VERSION_1_1 )
- {
- printk(XENLOG_WARNING
- "SCMI: No SMCCC 1.1 support, SCMI calls forwarding disabled\n");
- return -ENOSYS;
- }
+ if ( !is_hardware_domain(d) )
+ return 0;
+ d->arch.sci_enabled = true;
+ printk(XENLOG_DEBUG "SCMI: %pd init\n", d);
return 0;
}
-static int __init scmi_dt_init_smccc(void)
+static void scmi_smc_domain_destroy(struct domain *d)
{
- static const struct dt_device_match scmi_ids[] __initconst =
- {
- /* We only support "arm,scmi-smc" binding for now */
- DT_MATCH_COMPATIBLE("arm,scmi-smc"),
- { /* sentinel */ },
- };
- const struct dt_device_node *scmi_node;
- int ret;
+ if ( !is_hardware_domain(d) )
+ return;
- /* If no SCMI firmware node found, fail silently as it's not mandatory */
- scmi_node = dt_find_matching_node(NULL, scmi_ids);
- if ( !scmi_node )
- return -EOPNOTSUPP;
+ printk(XENLOG_DEBUG "SCMI: %pd destroy\n", d);
+}
- ret = dt_property_read_u32(scmi_node, SCMI_SMC_ID_PROP, &scmi_smc_id);
- if ( !ret )
+static int __init scmi_check_smccc_ver(void)
+{
+ if ( smccc_ver < ARM_SMCCC_VERSION_1_1 )
{
- printk(XENLOG_ERR "SCMI: No valid \"%s\" property in \"%s\" DT node\n",
- SCMI_SMC_ID_PROP, scmi_node->full_name);
- return -ENOENT;
+ printk(XENLOG_WARNING
+ "SCMI: No SMCCC 1.1 support, SCMI calls forwarding disabled\n");
+ return -ENOSYS;
}
- scmi_enabled = true;
-
return 0;
}
+static const struct sci_mediator_ops scmi_smc_ops = {
+ .handle_call = scmi_handle_smc,
+ .domain_init = scmi_smc_domain_init,
+ .domain_destroy = scmi_smc_domain_destroy,
+};
+
/* Initialize the SCMI layer based on SMCs and Device-tree */
-static int __init scmi_init(void)
+static int __init scmi_dom0_init(struct dt_device_node *dev, const void *data)
{
int ret;
@@ -134,22 +127,36 @@ static int __init scmi_init(void)
if ( ret )
return ret;
- ret = scmi_dt_init_smccc();
- if ( ret == -EOPNOTSUPP )
- return ret;
+ ret = dt_property_read_u32(dev, SCMI_SMC_ID_PROP, &scmi_smc_id);
+ if ( !ret )
+ {
+ printk(XENLOG_ERR "SCMI: No valid \"%s\" property in \"%s\" DT node\n",
+ SCMI_SMC_ID_PROP, dt_node_full_name(dev));
+ return -ENOENT;
+ }
+
+ ret = sci_register(&scmi_smc_ops);
if ( ret )
- goto err;
+ {
+ printk(XENLOG_ERR "SCMI: mediator already registered (ret = %d)\n",
+ ret);
+ return ret;
+ }
printk(XENLOG_INFO "Using SCMI with SMC ID: 0x%x\n", scmi_smc_id);
return 0;
-
- err:
- printk(XENLOG_ERR "SCMI: Initialization failed (ret = %d)\n", ret);
- return ret;
}
-__initcall(scmi_init);
+static const struct dt_device_match scmi_smc_match[] __initconst = {
+ DT_MATCH_COMPATIBLE("arm,scmi-smc"),
+ { /* sentinel */ },
+};
+
+DT_DEVICE_START(scmi_smc, "SCMI SMC DOM0", DEVICE_FIRMWARE)
+ .dt_match = scmi_smc_match,
+ .init = scmi_dom0_init,
+DT_DEVICE_END
/*
* Local variables:
diff --git a/xen/arch/arm/include/asm/firmware/scmi-smc.h b/xen/arch/arm/include/asm/firmware/scmi-smc.h
deleted file mode 100644
index 6b1a164a40..0000000000
--- a/xen/arch/arm/include/asm/firmware/scmi-smc.h
+++ /dev/null
@@ -1,41 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0-only */
-/*
- * xen/arch/arm/include/asm/firmware/scmi-smc.h
- *
- * ARM System Control and Management Interface (SCMI) over SMC
- * Generic handling layer
- *
- * Andrei Cherechesu <andrei.cherechesu@nxp.com>
- * Copyright 2024 NXP
- */
-
-#ifndef __ASM_SCMI_SMC_H__
-#define __ASM_SCMI_SMC_H__
-
-#include <xen/types.h>
-
-struct cpu_user_regs;
-
-#ifdef CONFIG_SCMI_SMC
-
-bool scmi_handle_smc(struct cpu_user_regs *regs);
-
-#else
-
-static inline bool scmi_handle_smc(struct cpu_user_regs *regs)
-{
- return false;
-}
-
-#endif /* CONFIG_SCMI_SMC */
-
-#endif /* __ASM_SCMI_H__ */
-
-/*
- * Local variables:
- * mode: C
- * c-file-style: "BSD"
- * c-basic-offset: 4
- * indent-tabs-mode: nil
- * End:
- */
diff --git a/xen/arch/arm/vsmc.c b/xen/arch/arm/vsmc.c
index 4095171533..78d5bdf56f 100644
--- a/xen/arch/arm/vsmc.c
+++ b/xen/arch/arm/vsmc.c
@@ -21,7 +21,6 @@
#include <asm/traps.h>
#include <asm/vpsci.h>
#include <asm/platform.h>
-#include <asm/firmware/scmi-smc.h>
/* Number of functions currently supported by Hypervisor Service. */
#define XEN_SMCCC_FUNCTION_COUNT 3
@@ -233,7 +232,7 @@ static bool handle_sip(struct cpu_user_regs *regs)
if ( platform_smc(regs) )
return true;
- return (scmi_handle_smc(regs)) ? true : sci_handle_call(regs);
+ return sci_handle_call(regs);
}
/*
diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h
index e7a17ede3e..b31324f8d4 100644
--- a/xen/include/public/arch-arm.h
+++ b/xen/include/public/arch-arm.h
@@ -328,6 +328,7 @@ DEFINE_XEN_GUEST_HANDLE(vcpu_guest_context_t);
#define XEN_DOMCTL_CONFIG_TEE_FFA 2
#define XEN_DOMCTL_CONFIG_ARM_SCI_NONE 0
+#define XEN_DOMCTL_CONFIG_ARM_SCI_SCMI_SMC 1
struct xen_arch_domainconfig {
/* IN/OUT */
--
2.34.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH v8 4/4] docs: arm: add docs for SCMI over SMC calls forwarding driver
2025-09-03 13:18 [PATCH v8 0/4] xen/arm: scmi: introduce SCI SCMI SMC single-agent support Oleksii Moisieiev
2025-09-03 13:18 ` [PATCH v8 1/4] xen/arm: add generic SCI subsystem Oleksii Moisieiev
@ 2025-09-03 13:18 ` Oleksii Moisieiev
2025-09-03 13:18 ` [PATCH v8 3/4] xen/arm: scmi-smc: passthrough SCMI SMC to domain, single agent Oleksii Moisieiev
` (2 subsequent siblings)
4 siblings, 0 replies; 9+ messages in thread
From: Oleksii Moisieiev @ 2025-09-03 13:18 UTC (permalink / raw)
To: xen-devel@lists.xenproject.org
Cc: Andrew Cooper, Anthony PERARD, Bertrand Marquis, Jan Beulich,
Juergen Gross, Julien Grall, Michal Orzel, Oleksii Moisieiev,
Roger Pau Monné, Stefano Stabellini, Volodymyr Babchuk,
Grygorii Strashko
From: Grygorii Strashko <grygorii_strashko@epam.com>
Add documentation section for Simple Arm SCMI over SMC calls forwarding
driver (EL3).
Signed-off-by: Grygorii Strashko <grygorii_strashko@epam.com>
Signed-off-by: Oleksii Moisieiev <oleksii_moisieiev@epam.com>
---
(no changes since v7)
Changes in v7:
- fixed typos
Changes in v6:
- add link to the scmi bindings used in the doc
- remove mentions about HVC calls from doc
- rename cmdline parameter to scmi-smc-passthrough
Changes in v5:
- rename dom0_scmi_smc_passthrough in documentation
.../arm/firmware/arm-scmi.rst | 180 ++++++++++++++++++
docs/hypervisor-guide/arm/index.rst | 9 +
docs/hypervisor-guide/index.rst | 1 +
3 files changed, 190 insertions(+)
create mode 100644 docs/hypervisor-guide/arm/firmware/arm-scmi.rst
create mode 100644 docs/hypervisor-guide/arm/index.rst
diff --git a/docs/hypervisor-guide/arm/firmware/arm-scmi.rst b/docs/hypervisor-guide/arm/firmware/arm-scmi.rst
new file mode 100644
index 0000000000..d65ce35acb
--- /dev/null
+++ b/docs/hypervisor-guide/arm/firmware/arm-scmi.rst
@@ -0,0 +1,180 @@
+.. SPDX-License-Identifier: CC-BY-4.0
+
+ARM System Control and Management Interface (SCMI)
+==================================================
+
+The System Control and Management Interface (SCMI) [1], which is a set of operating
+system-independent software interfaces that are used in system management. SCMI currently
+provides interfaces for:
+
+- Discovery and self-description of the interfaces it supports
+- Power domain management
+- Clock management
+- Reset domain management
+- Voltage domain management
+- Sensor management
+- Performance management
+- Power capping and monitoring
+- Pin control protocol.
+
+The SCMI compliant firmware could run:
+
+- as part of EL3 secure world software (like Trusted Firmware-A) with
+ ARM SMC shared-memory transport;
+- on dedicated System Control Processor (SCP) with HW mailbox shared-memory transport
+
+The major purpose of enabling SCMI support in Xen is to enable guest domains access to the SCMI
+interfaces for performing management actions on passed-through devices (such as clocks/resets etc)
+without accessing directly to the System control HW (like clock controllers) which in most cases
+can't be shared/split between domains. Or, at minimum, allow SCMI access for dom0/hwdom (or guest
+domain serving as Driver domain).
+
+The below sections describe SCMI support options available for Xen.
+
+| [1] `Arm SCMI <https://developer.arm.com/documentation/den0056/latest/>`_
+| [2] `System Control and Management Interface (SCMI) bindings <https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/firmware/arm,scmi.yaml>`_
+
+Simple SCMI over SMC calls forwarding driver (EL3)
+------------------------------------------------------
+
+The EL3 SCMI firmware (TF-A) with a single SCMI OSPM agent support is pretty generic case for
+the default vendors SDK and new platforms with SCMI support. Such EL3 SCMI firmware supports only
+single SCMI OSPM transport (agent) with Shared memory based transport and SMC calls as doorbell.
+
+The SCMI over SMC calls forwarding driver solves major problem for this case by allowing
+SMC calls to be forwarded from guest to the EL3 SCMI firmware.
+
+By default, the SCMI over SMC calls forwarding is enabled for Dom0/hwdom.
+
+::
+
+ +--------------------------+
+ | |
+ | EL3 SCMI FW (TF-A) |
+ ++-------+--^--------------+
+ |shmem | | smc-id
+ +----^--+ |
+ | |
+ +----|-+---+---+----------+
+ | | | FWD | Xen |
+ | | +---^---+ |
+ +----|-----|--------------+
+ | | smc-id
+ +----v-----+--+ +---------+
+ | | | |
+ | Dom0/hwdom | | DomU |
+ | | | |
+ | | | |
+ +-------------+ +---------+
+
+
+The SCMI messages are passed directly through SCMI shared-memory (zero-copy) and driver only
+forwards SMC calls.
+
+Compiling
+^^^^^^^^^
+
+To build with the SCMI over SMC calls forwarding enabled support, enable Kconfig option
+
+::
+
+ SCMI_SMC
+
+The ``CONFIG_SCMI_SMC`` is enabled by default.
+
+Pass-through SCMI SMC to domain which serves as Driver domain
+^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+
+This section describes how to configure the SCMI over SMC calls forwarding driver to handle use
+case "thin Dom0 with guest domain, which serves as Driver domain". In this case HW need to be
+enabled in Driver domain and dom0 is performing only control functions (without accessing FW) and so,
+the SCMI need to be enabled in Driver domain.
+
+::
+
+ +--------------------------+
+ |EL3 SCMI FW (TF-A) |
+ | |
+ +-------------^--+-------+-+
+ smc-id| |shmem0 |
+ | +----^--+
+ +-------------++------+|----+
+ |Xen | FWD || |
+ | +--^----+| |
+ +----------------|-----|----+
+ smc-id | |
+ +-----------+ +--+-----v-----+
+ | | | |
+ | Dom0 | | Driver |
+ | Control | | domain |
+ | | | |
+ +-----------+ +--------------+
+
+The SCMI can be enabled for one and only one guest domain.
+
+First, configure Dom0 to enable SCMI pass-through using Xen Command Line
+**"scmi-smc-passthrough"** option. This will disable SCMI for Dom0/hwdom and SCMI nodes will
+be removed from Dom0/hwdom device tree.
+
+**Configure SCMI pass-through for guest domain with toolstack**
+
+* In domain's xl.cfg file add **"arm_sci"** option as below
+
+::
+
+ arm_sci = "type=scmi_smc"
+
+* In domain's xl.cfg file enable access to the "arm,scmi-shmem"
+
+::
+
+ iomem = [
+ "47ff0,1@22001",
+ ]
+
+.. note:: It's up to the user to select guest IPA for mapping SCMI shared-memory.
+
+* Add SCMI nodes to the Driver domain partial device tree as in the below example:
+
+.. code::
+
+ passthrough {
+ scmi_shm_0: sram@22001000 {
+ compatible = "arm,scmi-shmem";
+ reg = <0x0 0x22001000 0x0 0x1000>;
+ };
+
+ firmware {
+ compatible = "simple-bus";
+ scmi: scmi {
+ compatible = "arm,scmi-smc";
+ shmem = <&scmi_shm_0>;
+ ...
+ }
+ }
+ }
+
+Please refer to [2] for details of SCMI DT bindings.
+
+In general, the configuration is similar to any other HW pass-through, except explicitly
+enabling SCMI with "arm_sci" xl.cfg option.
+
+**Configure SCMI pass-through for predefined domain (dom0less)**
+
+* add "xen,sci_type" property for required DomU ("xen,domain") node
+
+::
+
+ xen,sci_type="scmi_smc"
+
+* add scmi nodes to the Driver domain partial device tree the same way as above and enable access
+ to the "arm,scmi-shmem" according to dom0less documentation. For example:
+
+.. code::
+
+ scmi_shm_0: sram@22001000 {
+ compatible = "arm,scmi-shmem";
+ reg = <0x00 0x22001000 0x00 0x1000>;
+ -> xen,reg = <0x0 0x47ff0000 0x0 0x1000 0x0 0x22001000>;
+ -> xen,force-assign-without-iommu;
+ };
diff --git a/docs/hypervisor-guide/arm/index.rst b/docs/hypervisor-guide/arm/index.rst
new file mode 100644
index 0000000000..7aae4a0a03
--- /dev/null
+++ b/docs/hypervisor-guide/arm/index.rst
@@ -0,0 +1,9 @@
+.. SPDX-License-Identifier: CC-BY-4.0
+
+ARM
+===
+
+.. toctree::
+ :maxdepth: 2
+
+ firmware/arm-scmi
diff --git a/docs/hypervisor-guide/index.rst b/docs/hypervisor-guide/index.rst
index e4393b0697..520fe01554 100644
--- a/docs/hypervisor-guide/index.rst
+++ b/docs/hypervisor-guide/index.rst
@@ -9,3 +9,4 @@ Hypervisor documentation
code-coverage
x86/index
+ arm/index
\ No newline at end of file
--
2.34.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH v8 3/4] xen/arm: scmi-smc: passthrough SCMI SMC to domain, single agent
2025-09-03 13:18 [PATCH v8 0/4] xen/arm: scmi: introduce SCI SCMI SMC single-agent support Oleksii Moisieiev
2025-09-03 13:18 ` [PATCH v8 1/4] xen/arm: add generic SCI subsystem Oleksii Moisieiev
2025-09-03 13:18 ` [PATCH v8 4/4] docs: arm: add docs for SCMI over SMC calls forwarding driver Oleksii Moisieiev
@ 2025-09-03 13:18 ` Oleksii Moisieiev
2025-09-03 13:18 ` [PATCH v8 2/4] xen/arm: scmi-smc: update to be used under sci subsystem Oleksii Moisieiev
2025-09-03 21:24 ` [PATCH v8 0/4] xen/arm: scmi: introduce SCI SCMI SMC single-agent support Stefano Stabellini
4 siblings, 0 replies; 9+ messages in thread
From: Oleksii Moisieiev @ 2025-09-03 13:18 UTC (permalink / raw)
To: xen-devel@lists.xenproject.org
Cc: Andrew Cooper, Anthony PERARD, Bertrand Marquis, Jan Beulich,
Juergen Gross, Julien Grall, Michal Orzel, Oleksii Moisieiev,
Roger Pau Monné, Stefano Stabellini, Volodymyr Babchuk,
Grygorii Strashko
From: Grygorii Strashko <grygorii_strashko@epam.com>
The commit 3e322bef8bc0 ("xen/arm: firmware: Add SCMI over SMC calls
handling layer") introduces simple driver which forwards SCMI over SMC
calls from hwdom/dom0 to EL3 firmware (TF-A) with a single SCMI OSPM agent
support. While it is working gracefully for hwdom/dom0 use case it doesn't
cover "thin Dom0 with guest domain, which serves as Driver domain"
use-case. In this case HW need to be enable in Driver domain and dom0 is
performing only control functions.
The EL3 SCMI firmware (TF-A) with a single SCMI OSPM agent support is
pretty generic case for the default vendors SDK and new platforms.
This patch enables passthrough of SCMI SMC single agent interface to the
one guest domain serving as Driver domain.
Configure Dom0 to enable SCMI passthrough:
- dom0: add scmi-smc-passthrough to the Xen Command Line
Enabled SCMI passthrough for guest using toolstack in the following way:
- domD: xl.cfg add "arm_sci" option as below
arm_sci = "type=scmi_smc"
- domD: xl.cfg enable access to the "arm,scmi-shmem"
iomem = [
"47ff0,1@22001",
]
- domD: add SCMI nodes to the Driver domain partial device tree as in the
below example:
passthrough {
scmi_shm_0: sram@22001000 {
compatible = "arm,scmi-shmem";
reg = <0x0 0x22001000 0x0 0x1000>;
};
firmware {
compatible = "simple-bus";
scmi: scmi {
compatible = "arm,scmi-smc";
shmem = <&scmi_shm_0>;
...
}
}
}
dom0less case configuration:
- add "xen,sci_type" property for required DomU ("xen,domain") node
xen,sci_type="scmi_smc"
- add scmi nodes to the Driver domain partial device tree the same way
as above and enable access to the "arm,scmi-shmem" according to
dom0less documentation. For example:
scmi_shm_0: sram@22001000 {
compatible = "arm,scmi-shmem";
reg = <0x00 0x22001000 0x00 0x1000>;
-> xen,reg = <0x0 0x47ff0000 0x0 0x1000 0x0 0x22001000>;
-> xen,force-assign-without-iommu;
};
The SCMI SMC single agent interface can be enabled for one and only one
domain. In general, the configuration is similar to any other HW
passthrough, except explicitly enabling SCMI with "arm_sci" xl.cfg option.
Note that "arm,scmi-smc" and "arm,scmi-shmem" nodes will be removed from
dom0/hwdom DT when "scmi-smc-passthrough" cmdline parameter was provided.
Signed-off-by: Grygorii Strashko <grygorii_strashko@epam.com>
Signed-off-by: Oleksii Moisieiev <oleksii_moisieiev@epam.com>
Acked-by: Anthony PERARD <anthony.perard@vates.tech> # tools
---
Changes in v8:
- reneregated {helpers/types}.gen.go, dropped unneeded parameters
Changes in v7:
- Fix commit description.
- Move scmi-smc-passthrough definition to match alphaberical order
- remove unneeded initialization with NULL
- changed u64 to uint64_t
- Send warning if iomem permit access was failed
Changes in v6:
- added generated helpers and types go files
- rename cmdline parameter to scmi-smc-passthrough
- fix goto tag in parse_arm_sci_config
Changes in v5:
- rename dom0_scmi_smc_passthrough to scmi_smc_passthrough
Changes in v4:
- xl.cfg doc
- fix comments from Stefano Stabellini
- fix toolstack code as sugested by Anthony PERARD
- use MATCH_OPTION()
- move arm_sci struct and cfg params in "arch_arm"
- add SCMI passthrough for dom0less case
docs/man/xl.cfg.5.pod.in | 34 ++++++++
docs/misc/arm/device-tree/booting.txt | 15 ++++
docs/misc/xen-command-line.pandoc | 9 ++
tools/golang/xenlight/helpers.gen.go | 35 ++++++++
tools/golang/xenlight/types.gen.go | 11 +++
tools/include/libxl.h | 5 ++
tools/libs/light/libxl_arm.c | 14 ++++
tools/libs/light/libxl_types.idl | 10 +++
tools/xl/xl_parse.c | 36 ++++++++
xen/arch/arm/dom0less-build.c | 34 +++++++-
xen/arch/arm/firmware/Kconfig | 4 +-
xen/arch/arm/firmware/scmi-smc.c | 115 +++++++++++++++++++++++++-
12 files changed, 317 insertions(+), 5 deletions(-)
diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in
index acff45d308..3b18bcc095 100644
--- a/docs/man/xl.cfg.5.pod.in
+++ b/docs/man/xl.cfg.5.pod.in
@@ -3123,6 +3123,40 @@ writes will be ignored.
This option is only implemented for Arm where the default is enabled.
+=item B<arm_sci="ARM_SCI_STRING">
+
+Set ARM_SCI specific options for the guest. ARM SCI is System
+Control Protocol allows domain to manage various functions that are provided
+by HW platform firmware.
+
+B<ARM_SCI_STRING> is a comma separated list of C<KEY=VALUE> settings,
+from the following list:
+
+=over 4
+
+=item B<type=STRING>
+
+Specifies an ARM SCI type for the guest.
+
+=over 4
+
+=item B<none>
+
+Don't allow guest to use ARM SCI if present on the platform. This is the
+default value.
+
+=item B<scmi_smc>
+
+Enables ARM SCMI SMC support for the guest by enabling SCMI over SMC calls
+forwarding from domain to the EL3 firmware (like Trusted Firmware-A) with a
+single SCMI OSPM agent support.
+Should be used together with B<scmi-smc-passthrough> Xen command line
+option.
+
+=back
+
+=back
+
=back
=head3 x86
diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt
index 07acc7ba64..977b428608 100644
--- a/docs/misc/arm/device-tree/booting.txt
+++ b/docs/misc/arm/device-tree/booting.txt
@@ -307,6 +307,21 @@ with the following properties:
passed through. This option is the default if this property is missing
and the user does not provide the device partial device tree for the domain.
+- xen,sci_type
+
+ A string property specifying an ARM SCI type for the guest.
+
+ - "none"
+ Don't allow guest to use ARM SCI if present on the platform. This is the
+ default value.
+
+ - "scmi_smc"
+ Enables ARM SCMI SMC support for the guest by enabling SCMI over SMC calls
+ forwarding from domain to the EL3 firmware (like Trusted Firmware-A) with a
+ single SCMI OSPM agent support.
+ Should be used together with scmi-smc-passthrough Xen command line
+ option.
+
Under the "xen,domain" compatible node, one or more sub-nodes are present
for the DomU kernel and ramdisk.
diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc
index 4adcd7e762..518e42d965 100644
--- a/docs/misc/xen-command-line.pandoc
+++ b/docs/misc/xen-command-line.pandoc
@@ -2382,6 +2382,15 @@ sockets, &c. This will reduce performance somewhat, particularly on
systems with hyperthreading enabled, but should reduce power by
enabling more sockets and cores to go into deeper sleep states.
+### scmi-smc-passthrough (ARM)
+> `= <boolean>`
+
+The option is available when `CONFIG_SCMI_SMC` is compiled in, and allows to
+enable SCMI SMC single agent interface for any, but only one guest domain,
+which serves as Driver domain. The SCMI will be disabled for Dom0/hwdom and
+SCMI nodes removed from Dom0/hwdom device tree.
+(for example, thin Dom0 with Driver domain use-case).
+
### scrub-domheap
> `= <boolean>`
diff --git a/tools/golang/xenlight/helpers.gen.go b/tools/golang/xenlight/helpers.gen.go
index 667030cbd7..8909fe8a1b 100644
--- a/tools/golang/xenlight/helpers.gen.go
+++ b/tools/golang/xenlight/helpers.gen.go
@@ -938,6 +938,35 @@ return fmt.Errorf("converting field Vcpus: %v", err)
return nil
}
+// NewArmSci returns an instance of ArmSci initialized with defaults.
+func NewArmSci() (*ArmSci, error) {
+var (
+x ArmSci
+xc C.libxl_arm_sci)
+
+C.libxl_arm_sci_init(&xc)
+defer C.libxl_arm_sci_dispose(&xc)
+
+if err := x.fromC(&xc); err != nil {
+return nil, err }
+
+return &x, nil}
+
+func (x *ArmSci) fromC(xc *C.libxl_arm_sci) error {
+ x.Type = ArmSciType(xc._type)
+
+ return nil}
+
+func (x *ArmSci) toC(xc *C.libxl_arm_sci) (err error){defer func(){
+if err != nil{
+C.libxl_arm_sci_dispose(xc)}
+}()
+
+xc._type = C.libxl_arm_sci_type(x.Type)
+
+ return nil
+ }
+
// NewRdmReserve returns an instance of RdmReserve initialized with defaults.
func NewRdmReserve() (*RdmReserve, error) {
var (
@@ -1163,6 +1192,9 @@ x.ArchArm.GicVersion = GicVersion(xc.arch_arm.gic_version)
x.ArchArm.Vuart = VuartType(xc.arch_arm.vuart)
x.ArchArm.SveVl = SveType(xc.arch_arm.sve_vl)
x.ArchArm.NrSpis = uint32(xc.arch_arm.nr_spis)
+if err := x.ArchArm.ArmSci.fromC(&xc.arch_arm.arm_sci);err != nil {
+return fmt.Errorf("converting field ArchArm.ArmSci: %v", err)
+}
if err := x.ArchX86.MsrRelaxed.fromC(&xc.arch_x86.msr_relaxed);err != nil {
return fmt.Errorf("converting field ArchX86.MsrRelaxed: %v", err)
}
@@ -1699,6 +1731,9 @@ xc.arch_arm.gic_version = C.libxl_gic_version(x.ArchArm.GicVersion)
xc.arch_arm.vuart = C.libxl_vuart_type(x.ArchArm.Vuart)
xc.arch_arm.sve_vl = C.libxl_sve_type(x.ArchArm.SveVl)
xc.arch_arm.nr_spis = C.uint32_t(x.ArchArm.NrSpis)
+if err := x.ArchArm.ArmSci.toC(&xc.arch_arm.arm_sci); err != nil {
+return fmt.Errorf("converting field ArchArm.ArmSci: %v", err)
+}
if err := x.ArchX86.MsrRelaxed.toC(&xc.arch_x86.msr_relaxed); err != nil {
return fmt.Errorf("converting field ArchX86.MsrRelaxed: %v", err)
}
diff --git a/tools/golang/xenlight/types.gen.go b/tools/golang/xenlight/types.gen.go
index e26b3cdfc7..ab9d4ca7b4 100644
--- a/tools/golang/xenlight/types.gen.go
+++ b/tools/golang/xenlight/types.gen.go
@@ -520,6 +520,16 @@ SveType1920 SveType = 1920
SveType2048 SveType = 2048
)
+type ArmSciType int
+const(
+ArmSciTypeNone ArmSciType = 0
+ArmSciTypeScmiSmc ArmSciType = 1
+)
+
+type ArmSci struct {
+Type ArmSciType
+}
+
type RdmReserve struct {
Strategy RdmReserveStrategy
Policy RdmReservePolicy
@@ -599,6 +609,7 @@ GicVersion GicVersion
Vuart VuartType
SveVl SveType
NrSpis uint32
+ArmSci ArmSci
}
ArchX86 struct {
MsrRelaxed Defbool
diff --git a/tools/include/libxl.h b/tools/include/libxl.h
index 185f74d8a8..bc35e412da 100644
--- a/tools/include/libxl.h
+++ b/tools/include/libxl.h
@@ -313,6 +313,11 @@
*/
#define LIBXL_HAVE_BUILDINFO_ARCH_NR_SPIS 1
+/*
+ * libxl_domain_build_info has the arch_arm.sci* fields.
+ */
+#define LIBXL_HAVE_BUILDINFO_ARCH_ARM_SCI 1
+
/*
* LIBXL_HAVE_SOFT_RESET indicates that libxl supports performing
* 'soft reset' for domains and there is 'soft_reset' shutdown reason
diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c
index 4a19a8d22b..7e9f8a1bc3 100644
--- a/tools/libs/light/libxl_arm.c
+++ b/tools/libs/light/libxl_arm.c
@@ -233,6 +233,20 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc,
config->arch.sve_vl = d_config->b_info.arch_arm.sve_vl / 128U;
}
+ switch (d_config->b_info.arch_arm.arm_sci.type) {
+ case LIBXL_ARM_SCI_TYPE_NONE:
+ config->arch.arm_sci_type = XEN_DOMCTL_CONFIG_ARM_SCI_NONE;
+ break;
+ case LIBXL_ARM_SCI_TYPE_SCMI_SMC:
+ config->arch.arm_sci_type = XEN_DOMCTL_CONFIG_ARM_SCI_SCMI_SMC;
+ break;
+ default:
+ LOG(ERROR, "Unknown ARM_SCI type %d",
+ d_config->b_info.arch_arm.arm_sci.type);
+ return ERROR_FAIL;
+ }
+ LOG(DEBUG, " - SCI type=%u", config->arch.arm_sci_type);
+
return 0;
}
diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl
index a6030a2dbd..b53e013a44 100644
--- a/tools/libs/light/libxl_types.idl
+++ b/tools/libs/light/libxl_types.idl
@@ -551,6 +551,15 @@ libxl_sve_type = Enumeration("sve_type", [
(2048, "2048")
], init_val = "LIBXL_SVE_TYPE_DISABLED")
+libxl_arm_sci_type = Enumeration("arm_sci_type", [
+ (0, "none"),
+ (1, "scmi_smc")
+ ], init_val = "LIBXL_ARM_SCI_TYPE_NONE")
+
+libxl_arm_sci = Struct("arm_sci", [
+ ("type", libxl_arm_sci_type),
+ ])
+
libxl_rdm_reserve = Struct("rdm_reserve", [
("strategy", libxl_rdm_reserve_strategy),
("policy", libxl_rdm_reserve_policy),
@@ -725,6 +734,7 @@ libxl_domain_build_info = Struct("domain_build_info",[
("vuart", libxl_vuart_type),
("sve_vl", libxl_sve_type),
("nr_spis", uint32, {'init_val': 'LIBXL_NR_SPIS_DEFAULT'}),
+ ("arm_sci", libxl_arm_sci),
])),
("arch_x86", Struct(None, [("msr_relaxed", libxl_defbool),
])),
diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c
index 90c9386f5b..af86d3186d 100644
--- a/tools/xl/xl_parse.c
+++ b/tools/xl/xl_parse.c
@@ -1284,6 +1284,36 @@ out:
if (rc) exit(EXIT_FAILURE);
}
+static int parse_arm_sci_config(XLU_Config *cfg, libxl_arm_sci *arm_sci,
+ const char *str)
+{
+ int ret = 0;
+ char *buf2, *ptr;
+ char *oparg;
+
+ if (NULL == (buf2 = ptr = strdup(str)))
+ return ERROR_NOMEM;
+
+ ptr = strtok(buf2, ",");
+ while (ptr != NULL)
+ {
+ if (MATCH_OPTION("type", ptr, oparg)) {
+ ret = libxl_arm_sci_type_from_string(oparg, &arm_sci->type);
+ if (ret) {
+ fprintf(stderr, "Unknown ARM_SCI type: %s\n", oparg);
+ ret = ERROR_INVAL;
+ goto out;
+ }
+ }
+
+ ptr = strtok(NULL, ",");
+ }
+
+out:
+ free(buf2);
+ return ret;
+}
+
void parse_config_data(const char *config_source,
const char *config_data,
int config_len,
@@ -2989,6 +3019,12 @@ skip_usbdev:
xlu_cfg_get_defbool(config, "trap_unmapped_accesses",
&b_info->trap_unmapped_accesses, 0);
+ if (!xlu_cfg_get_string(config, "arm_sci", &buf, 1)) {
+ if (parse_arm_sci_config(config, &b_info->arch_arm.arm_sci, buf)) {
+ exit(EXIT_FAILURE);
+ }
+ }
+
parse_vkb_list(config, d_config);
d_config->virtios = NULL;
diff --git a/xen/arch/arm/dom0less-build.c b/xen/arch/arm/dom0less-build.c
index 0094cf9e40..418657eed0 100644
--- a/xen/arch/arm/dom0less-build.c
+++ b/xen/arch/arm/dom0less-build.c
@@ -279,6 +279,36 @@ int __init arch_handle_passthrough_prop(struct kernel_info *kinfo,
return sci_assign_dt_device(kinfo->bd.d, node);
}
+int __init domu_dt_sci_parse(struct dt_device_node *node,
+ struct xen_domctl_createdomain *d_cfg)
+{
+ const char *sci_type;
+ int ret;
+
+ d_cfg->arch.arm_sci_type = XEN_DOMCTL_CONFIG_ARM_SCI_NONE;
+
+ if ( !IS_ENABLED(CONFIG_ARM_SCI) ||
+ !dt_property_read_bool(node, "xen,sci_type") )
+ return 0;
+
+ ret = dt_property_read_string(node, "xen,sci_type", &sci_type);
+ if ( ret )
+ return ret;
+
+ if ( !strcmp(sci_type, "none") )
+ d_cfg->arch.arm_sci_type = XEN_DOMCTL_CONFIG_ARM_SCI_NONE;
+ else if ( !strcmp(sci_type, "scmi_smc") )
+ d_cfg->arch.arm_sci_type = XEN_DOMCTL_CONFIG_ARM_SCI_SCMI_SMC;
+ else
+ {
+ printk(XENLOG_ERR "xen,sci_type in not valid (%s) for domain %s\n",
+ sci_type, dt_node_name(node));
+ return -EINVAL;
+ }
+
+ return 0;
+}
+
int __init arch_parse_dom0less_node(struct dt_device_node *node,
struct boot_domain *bd)
{
@@ -288,7 +318,9 @@ int __init arch_parse_dom0less_node(struct dt_device_node *node,
d_cfg->arch.gic_version = XEN_DOMCTL_CONFIG_GIC_NATIVE;
d_cfg->flags |= XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap;
- d_cfg->arch.arm_sci_type = XEN_DOMCTL_CONFIG_ARM_SCI_NONE;
+
+ if ( domu_dt_sci_parse(node, d_cfg) )
+ panic("Error getting SCI configuration\n");
if ( !dt_property_read_u32(node, "nr_spis", &d_cfg->arch.nr_spis) )
{
diff --git a/xen/arch/arm/firmware/Kconfig b/xen/arch/arm/firmware/Kconfig
index bbf88fbb9a..5c5f0880c4 100644
--- a/xen/arch/arm/firmware/Kconfig
+++ b/xen/arch/arm/firmware/Kconfig
@@ -25,7 +25,9 @@ config SCMI_SMC
doorbell mechanism and Shared Memory for transport ("arm,scmi-smc"
compatible only). The value of "arm,smc-id" DT property from SCMI
firmware node is used to trap and forward corresponding SCMI SMCs
- to firmware running at EL3, for calls coming from the hardware domain.
+ to firmware running at EL3, for calls coming from the hardware domain or
+ driver domain.
+ Use with EL3 firmware which supports only single SCMI OSPM agent.
endchoice
diff --git a/xen/arch/arm/firmware/scmi-smc.c b/xen/arch/arm/firmware/scmi-smc.c
index 4c5df714c2..0835ddeeec 100644
--- a/xen/arch/arm/firmware/scmi-smc.c
+++ b/xen/arch/arm/firmware/scmi-smc.c
@@ -13,6 +13,8 @@
#include <xen/device_tree.h>
#include <xen/errno.h>
#include <xen/init.h>
+#include <xen/iocap.h>
+#include <xen/param.h>
#include <xen/sched.h>
#include <xen/types.h>
@@ -22,7 +24,11 @@
#define SCMI_SMC_ID_PROP "arm,smc-id"
+static bool __ro_after_init opt_scmi_smc_passthrough;
+boolean_param("scmi-smc-passthrough", opt_scmi_smc_passthrough);
+
static uint32_t __ro_after_init scmi_smc_id;
+static struct domain __read_mostly *scmi_dom;
/*
* Check if provided SMC Function Identifier matches the one known by the SCMI
@@ -50,7 +56,7 @@ static bool scmi_handle_smc(struct cpu_user_regs *regs)
return false;
/* Only the hardware domain should use SCMI calls */
- if ( !is_hardware_domain(current->domain) )
+ if ( scmi_dom != current->domain )
{
gdprintk(XENLOG_WARNING, "SCMI: Unprivileged access attempt\n");
return false;
@@ -75,12 +81,45 @@ static bool scmi_handle_smc(struct cpu_user_regs *regs)
return true;
}
+static int
+scmi_smc_domain_sanitise_config(struct xen_domctl_createdomain *config)
+{
+ if ( config->arch.arm_sci_type != XEN_DOMCTL_CONFIG_ARM_SCI_NONE &&
+ config->arch.arm_sci_type != XEN_DOMCTL_CONFIG_ARM_SCI_SCMI_SMC )
+ return -EINVAL;
+
+ return 0;
+}
+
static int scmi_smc_domain_init(struct domain *d,
struct xen_domctl_createdomain *config)
{
- if ( !is_hardware_domain(d) )
+ /*
+ * scmi_passthrough is not enabled:
+ * - proceed only for hw_domain
+ * - fail if guest domain has SCMI enabled.
+ */
+ if ( !opt_scmi_smc_passthrough && !is_hardware_domain(d) )
+ {
+ if ( config->arch.arm_sci_type == XEN_DOMCTL_CONFIG_ARM_SCI_SCMI_SMC )
+ return -EINVAL;
+ else
+ return 0;
+ }
+ /*
+ * scmi_passthrough is enabled:
+ * - ignore hw_domain
+ * - proceed only for domain with SCMI enabled.
+ */
+ if ( opt_scmi_smc_passthrough &&
+ (config->arch.arm_sci_type == XEN_DOMCTL_CONFIG_ARM_SCI_NONE ||
+ is_hardware_domain(d)) )
return 0;
+ if ( scmi_dom )
+ return -EEXIST;
+
+ scmi_dom = d;
d->arch.sci_enabled = true;
printk(XENLOG_DEBUG "SCMI: %pd init\n", d);
return 0;
@@ -88,12 +127,80 @@ static int scmi_smc_domain_init(struct domain *d,
static void scmi_smc_domain_destroy(struct domain *d)
{
- if ( !is_hardware_domain(d) )
+ if ( scmi_dom && scmi_dom != d )
return;
+ scmi_dom = NULL;
+ d->arch.sci_enabled = false;
printk(XENLOG_DEBUG "SCMI: %pd destroy\n", d);
}
+/*
+ * Handle Dom0 SCMI SMC specific DT nodes
+ *
+ * if scmi_smc_passthrough=false:
+ * - Copy SCMI nodes into Dom0 device tree.
+ * if scmi_smc_passthrough=true:
+ * - skip SCMI nodes from Dom0 DT
+ * - give dom0 control access to SCMI shmem MMIO, so SCMI can be passed
+ * through to guest.
+ */
+static bool scmi_smc_dt_handle_node(struct domain *d,
+ struct dt_device_node *node)
+{
+ static const struct dt_device_match shmem_matches[] __initconst = {
+ DT_MATCH_COMPATIBLE("arm,scmi-shmem"),
+ { /* sentinel */ },
+ };
+ static const struct dt_device_match scmi_matches[] __initconst = {
+ DT_MATCH_PATH("/firmware/scmi"),
+ { /* sentinel */ },
+ };
+
+ /* skip scmi shmem node for dom0 if scmi not enabled */
+ if ( dt_match_node(shmem_matches, node) && !sci_domain_is_enabled(d) )
+ {
+ dt_dprintk("Skip scmi shmem node\n");
+ return true;
+ }
+
+ /*
+ * skip scmi node for dom0 if scmi not enabled, but give dom0 control
+ * access to SCMI shmem
+ */
+ if ( dt_match_node(scmi_matches, node) && !sci_domain_is_enabled(d) )
+ {
+ struct dt_device_node *shmem_node;
+ const __be32 *prop;
+ uint64_t paddr, size;
+ int ret;
+
+ /* give dom0 control access to SCMI shmem */
+ prop = dt_get_property(node, "shmem", NULL);
+ if ( !prop )
+ return true;
+
+ shmem_node = dt_find_node_by_phandle(be32_to_cpu(*prop));
+ if ( !shmem_node )
+ return true;
+
+ ret = dt_device_get_address(shmem_node, 0, &paddr, &size);
+ if ( ret )
+ return true;
+
+ ret = iomem_permit_access(d, paddr_to_pfn(paddr),
+ paddr_to_pfn(paddr + size - 1));
+ if ( ret )
+ printk(XENLOG_WARNING
+ "SCMI: Failed to give access to SCMI shmem with code: %d\n", ret);
+
+ dt_dprintk("Skip scmi node\n");
+ return true;
+ }
+
+ return false;
+}
+
static int __init scmi_check_smccc_ver(void)
{
if ( smccc_ver < ARM_SMCCC_VERSION_1_1 )
@@ -108,8 +215,10 @@ static int __init scmi_check_smccc_ver(void)
static const struct sci_mediator_ops scmi_smc_ops = {
.handle_call = scmi_handle_smc,
+ .domain_sanitise_config = scmi_smc_domain_sanitise_config,
.domain_init = scmi_smc_domain_init,
.domain_destroy = scmi_smc_domain_destroy,
+ .dom0_dt_handle_node = scmi_smc_dt_handle_node,
};
/* Initialize the SCMI layer based on SMCs and Device-tree */
--
2.34.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v8 0/4] xen/arm: scmi: introduce SCI SCMI SMC single-agent support
2025-09-03 13:18 [PATCH v8 0/4] xen/arm: scmi: introduce SCI SCMI SMC single-agent support Oleksii Moisieiev
` (3 preceding siblings ...)
2025-09-03 13:18 ` [PATCH v8 2/4] xen/arm: scmi-smc: update to be used under sci subsystem Oleksii Moisieiev
@ 2025-09-03 21:24 ` Stefano Stabellini
2025-09-03 21:47 ` Volodymyr Babchuk
2025-09-04 14:11 ` Oleksii Moisieiev
4 siblings, 2 replies; 9+ messages in thread
From: Stefano Stabellini @ 2025-09-03 21:24 UTC (permalink / raw)
To: Oleksii Moisieiev
Cc: xen-devel@lists.xenproject.org, Andrew Cooper, Anthony PERARD,
Bertrand Marquis, Jan Beulich, Juergen Gross, Julien Grall,
Michal Orzel, Roger Pau Monné, Stefano Stabellini,
Volodymyr Babchuk, Grygorii Strashko
Hi Oleksii,
It is still not passing the ci-loop, this time due to MISRA. See the two
new 8.3 and 8.4 violations (previously zero) and also new additional
12.2, 13.1 violations:
https://gitlab.com/xen-project/people/sstabellini/xen/-/pipelines/2020545544
https://eclair-analysis-logs.xenproject.org/fs/var/local/eclair/xen-project.ecdf/xen-project/people/sstabellini/xen/ECLAIR_normal/ppp2/ARM64/11238076156/PROJECT.ecd;/by_service.html#service&kind
per comparison, this is the baseline:
https://eclair-analysis-logs.xenproject.org/fs/var/local/eclair/xen-project.ecdf/xen-project/hardware/xen/ECLAIR_normal/staging/ARM64/11232061644/PROJECT.ecd;/by_service.html#service&kind
These are the new 8.3 and 8.4 violations:
https://eclair-analysis-logs.xenproject.org/fs/var/local/eclair/xen-project.ecdf/xen-project/people/sstabellini/xen/ECLAIR_normal/ppp2/ARM64/11238076156/PROJECT.ecd;/by_service/MC3A2.R8.3.html#{%22select%22:true,%22selection%22:{%22hiddenAreaKinds%22:[],%22hiddenSubareaKinds%22:[],%22show%22:false,%22selector%22:{%22enabled%22:true,%22negated%22:true,%22kind%22:0,%22domain%22:%22kind%22,%22inputs%22:[{%22enabled%22:true,%22text%22:%22violation%22}]}}}
https://eclair-analysis-logs.xenproject.org/fs/var/local/eclair/xen-project.ecdf/xen-project/people/sstabellini/xen/ECLAIR_normal/ppp2/ARM64/11238076156/PROJECT.ecd;/by_service/MC3A2.R8.4.html#{%22select%22:true,%22selection%22:{%22hiddenAreaKinds%22:[],%22hiddenSubareaKinds%22:[],%22show%22:false,%22selector%22:{%22enabled%22:true,%22negated%22:true,%22kind%22:0,%22domain%22:%22kind%22,%22inputs%22:[{%22enabled%22:true,%22text%22:%22violation%22}]}}}
Cheers,
Stefano
On Wed, 3 Sep 2025, Oleksii Moisieiev wrote:
>
> Inroducing V8 patch series on top of the Xen version 4.20-rc2
> which includes implementation of the SCI SCMI SMC single-agent support.
>
> This patch series is the first chunk of the
> "xen/arm: scmi: introduce SCI SCMI SMC multi-agent support" which can
> be found at [0]
>
> SCMI-multiagent support will be provided as the followup patch series.
>
> [0] https://lore.kernel.org/xen-devel/cover.1753184487.git.oleksii_moisieiev@epam.com/
>
> Patch 1 "xen/arm: add generic SCI subsystem"
> - rebased and refactored
> - introduced DEVICE_ARM_SCI DT device class and used for SCI drivers probing
> instead of custom,
> linker sections based implementation.
> - added SCI API for Dom0 DT handling, instead of manipulating with ARM arch
> dom0 code directly.
> - RFC changes in XEN_DOMCTL_assign_device OP processing
> - Introduce arch_handle_passthrough_prop call to handle arm specific
> nodes
>
> Patch 2 "xen/arm: scmi-smc: update to be used under sci subsystem"
> - update driver introduced by commit 3e322bef8bc0 ("xen/arm: firmware: Add SCMI
> over SMC calls
> handling layer") be used under sci subsystem.
> - no functional changes in general
>
> Patch 3 "xen/arm: scmi-smc: passthrough SCMI SMC to guest domain
> This is new change which allows passthrough SCMI SMC, single agent interface to
> guest domain
> cover use case "thin Dom0 with guest domain, which serves as Driver domain".
> See patch commit message for full description.
>
> Patch 4 - docs: arm: add docs for SCMI over SMC calls forwarding
> driver
> - add documentation section for Simple Arm SCMI over SMC calls
> forwarding driver.
>
> Code can be found at:
> https://github.com/oleksiimoisieiev/xen/tree/scmi_upstrv5
>
> [1] RFC v2:
> http://patchwork.kernel.org/project/xen-devel/cover/cover.1644341635.git.oleksii_moisieiev@epam.com/
> [2] RFC v3:
> https://patchwork.kernel.org/project/xen-devel/patch/20250311111618.1850927-1-grygorii_strashko@epam.com
> SCMI spec:
> https://developer.arm.com/documentation/den0056/e/?lang=en
>
> SCMI bindings:
> https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/firmware/arm,scmi.yaml
> https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/access-controllers/access-controllers.yaml
>
> Reference EL3 FW:
> RPI5: https://github.com/xen-troops/arm-trusted-firmware/commits/rpi5_dev/
> Renesas v4h:
> https://github.com/GrygiriiS/arm-trusted-firmware/commits/rcar_gen4_v2.7_v4x-scmi_upd/
>
> base-commit: dbe60f244c (Update Xen to 4.21, 2025-02-21)
>
> Changes in v8:
> - reneregated {helpers/types}.gen.go, dropped unneeded parameters
>
> Changes in v7:
> - fix sci_handl_call to make changes more readable
> - fix build error when DOM0LESS_BUILD is disabled (removed
> arch_handle_passthrough_prop from the header)
> - sort headers in alphabetical order in sci.h
> - sort headers in scmi-smc.c file
> - Fix commit description.
> - Move scmi-smc-passthrough definition to match alphaberical order
> - remove unneeded initialization with NULL
> - changed u64 to uint64_t
> - Send warning if iomem permit access was failed
> - fixed typos
>
> Changes in v6:
> - rebase on top of the latest master
> - fix return value of sci_dt_finalize() call
> - add R-b tag
> - added generated helpers and types go files
> - rename cmdline parameter to scmi-smc-passthrough
> - fix goto tag in parse_arm_sci_config
> - add link to the scmi bindings used in the doc
> - remove mentions about HVC calls from doc
> - rename cmdline parameter to scmi-smc-passthrough
>
> Changes in v5:
> - update Maintainers file. Set role as a Reviewer
> - rebased on the latest master branch
> - Introduce arch_handle_passthrough_prop call to handle arm specific nodes
> - rename dom0_scmi_smc_passthrough to scmi_smc_passthrough
> - rename dom0_scmi_smc_passthrough in documentation
>
> Changes in v4:
> - fix SPDX-License
> - rename DEVICE_ARM_SCI DT device class to FIRMWARE_DEVICE
> - move XEN_DOMCTL_assign_device code in separate patch
> - Add documentation for SCI SCMI drivers
> - xl.cfg doc
> - fix comments from Stefano Stabellini
> - fix toolstack code as sugested by Anthony PERARD
> - use MATCH_OPTION()
> - move arm_sci struct and cfg params in "arch_arm"
> - add SCMI passthrough for dom0less case
>
> Grygorii Strashko (3):
> xen/arm: scmi-smc: update to be used under sci subsystem
> xen/arm: scmi-smc: passthrough SCMI SMC to domain, single agent
> docs: arm: add docs for SCMI over SMC calls forwarding driver
>
> Oleksii Moisieiev (1):
> xen/arm: add generic SCI subsystem
>
> MAINTAINERS | 6 +
> .../arm/firmware/arm-scmi.rst | 180 ++++++++++++++++
> docs/hypervisor-guide/arm/index.rst | 9 +
> docs/hypervisor-guide/index.rst | 1 +
> docs/man/xl.cfg.5.pod.in | 34 +++
> docs/misc/arm/device-tree/booting.txt | 15 ++
> docs/misc/xen-command-line.pandoc | 9 +
> tools/golang/xenlight/helpers.gen.go | 35 +++
> tools/golang/xenlight/types.gen.go | 11 +
> tools/include/libxl.h | 5 +
> tools/libs/light/libxl_arm.c | 14 ++
> tools/libs/light/libxl_types.idl | 10 +
> tools/xl/xl_parse.c | 36 ++++
> xen/arch/arm/device.c | 5 +
> xen/arch/arm/dom0less-build.c | 40 ++++
> xen/arch/arm/domain.c | 12 +-
> xen/arch/arm/domain_build.c | 8 +
> xen/arch/arm/firmware/Kconfig | 25 ++-
> xen/arch/arm/firmware/Makefile | 1 +
> xen/arch/arm/firmware/sci.c | 154 ++++++++++++++
> xen/arch/arm/firmware/scmi-smc.c | 194 +++++++++++++----
> xen/arch/arm/include/asm/domain.h | 5 +
> xen/arch/arm/include/asm/firmware/sci.h | 200 ++++++++++++++++++
> xen/arch/arm/include/asm/firmware/scmi-smc.h | 41 ----
> xen/arch/arm/vsmc.c | 4 +-
> xen/common/device-tree/dom0less-build.c | 4 +
> xen/include/asm-generic/device.h | 1 +
> xen/include/public/arch-arm.h | 5 +
> xen/include/xen/dom0less-build.h | 3 +
> 29 files changed, 982 insertions(+), 85 deletions(-)
> create mode 100644 docs/hypervisor-guide/arm/firmware/arm-scmi.rst
> create mode 100644 docs/hypervisor-guide/arm/index.rst
> create mode 100644 xen/arch/arm/firmware/sci.c
> create mode 100644 xen/arch/arm/include/asm/firmware/sci.h
> delete mode 100644 xen/arch/arm/include/asm/firmware/scmi-smc.h
>
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v8 0/4] xen/arm: scmi: introduce SCI SCMI SMC single-agent support
2025-09-03 21:24 ` [PATCH v8 0/4] xen/arm: scmi: introduce SCI SCMI SMC single-agent support Stefano Stabellini
@ 2025-09-03 21:47 ` Volodymyr Babchuk
2025-09-04 7:10 ` Nicola Vetrini
2025-09-04 14:11 ` Oleksii Moisieiev
1 sibling, 1 reply; 9+ messages in thread
From: Volodymyr Babchuk @ 2025-09-03 21:47 UTC (permalink / raw)
To: Stefano Stabellini
Cc: Oleksii Moisieiev, xen-devel@lists.xenproject.org, Andrew Cooper,
Anthony PERARD, Bertrand Marquis, Jan Beulich, Juergen Gross,
Julien Grall, Michal Orzel, Roger Pau Monné,
Grygorii Strashko
Hi Stefano,
Stefano Stabellini <sstabellini@kernel.org> writes:
> Hi Oleksii,
>
> It is still not passing the ci-loop, this time due to MISRA. See the two
> new 8.3 and 8.4 violations (previously zero) and also new additional
> 12.2, 13.1 violations:
>
Is there any way to run this kind of tests locally? (I suppose that
answer is "no")
Or at least maybe it is possible to use gitlab CI without sending
patches to the ML? Maybe via opening MRs at gitlab?
--
WBR, Volodymyr
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v8 0/4] xen/arm: scmi: introduce SCI SCMI SMC single-agent support
2025-09-03 21:47 ` Volodymyr Babchuk
@ 2025-09-04 7:10 ` Nicola Vetrini
0 siblings, 0 replies; 9+ messages in thread
From: Nicola Vetrini @ 2025-09-04 7:10 UTC (permalink / raw)
To: Volodymyr Babchuk
Cc: Stefano Stabellini, Oleksii Moisieiev, xen-devel, Andrew Cooper,
Anthony PERARD, Bertrand Marquis, Jan Beulich, Juergen Gross,
Julien Grall, Michal Orzel, Roger Pau Monné,
Grygorii Strashko
On 2025-09-03 23:47, Volodymyr Babchuk wrote:
> Hi Stefano,
>
> Stefano Stabellini <sstabellini@kernel.org> writes:
>
>> Hi Oleksii,
>>
>> It is still not passing the ci-loop, this time due to MISRA. See the
>> two
>> new 8.3 and 8.4 violations (previously zero) and also new additional
>> 12.2, 13.1 violations:
>>
>
> Is there any way to run this kind of tests locally? (I suppose that
> answer is "no")
>
> Or at least maybe it is possible to use gitlab CI without sending
> patches to the ML? Maybe via opening MRs at gitlab?
Hi Volodymyr,
you can manually run these on branches in sub-repos after creating the
pipeline, I believe.
--
Nicola Vetrini, B.Sc.
Software Engineer
BUGSENG (https://bugseng.com)
LinkedIn: https://www.linkedin.com/in/nicola-vetrini-a42471253
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v8 0/4] xen/arm: scmi: introduce SCI SCMI SMC single-agent support
2025-09-03 21:24 ` [PATCH v8 0/4] xen/arm: scmi: introduce SCI SCMI SMC single-agent support Stefano Stabellini
2025-09-03 21:47 ` Volodymyr Babchuk
@ 2025-09-04 14:11 ` Oleksii Moisieiev
1 sibling, 0 replies; 9+ messages in thread
From: Oleksii Moisieiev @ 2025-09-04 14:11 UTC (permalink / raw)
To: Stefano Stabellini
Cc: xen-devel@lists.xenproject.org, Andrew Cooper, Anthony PERARD,
Bertrand Marquis, Jan Beulich, Juergen Gross, Julien Grall,
Michal Orzel, Roger Pau Monné, Volodymyr Babchuk,
Grygorii Strashko
Hi Stefano,
I fixed MISRA rules violation and now Pipeline passes with no regressions:
https://gitlab.com/xen-project/people/dimaprkp4k/xen/-/pipelines/2022022013
I will send V9 with updates.
BR,
Oleksii
On 04/09/2025 00:24, Stefano Stabellini wrote:
> Hi Oleksii,
>
> It is still not passing the ci-loop, this time due to MISRA. See the two
> new 8.3 and 8.4 violations (previously zero) and also new additional
> 12.2, 13.1 violations:
>
> https://gitlab.com/xen-project/people/sstabellini/xen/-/pipelines/2020545544
>
> https://eclair-analysis-logs.xenproject.org/fs/var/local/eclair/xen-project.ecdf/xen-project/people/sstabellini/xen/ECLAIR_normal/ppp2/ARM64/11238076156/PROJECT.ecd;/by_service.html#service&kind
>
> per comparison, this is the baseline:
> https://eclair-analysis-logs.xenproject.org/fs/var/local/eclair/xen-project.ecdf/xen-project/hardware/xen/ECLAIR_normal/staging/ARM64/11232061644/PROJECT.ecd;/by_service.html#service&kind
>
> These are the new 8.3 and 8.4 violations:
>
> https://eclair-analysis-logs.xenproject.org/fs/var/local/eclair/xen-project.ecdf/xen-project/people/sstabellini/xen/ECLAIR_normal/ppp2/ARM64/11238076156/PROJECT.ecd;/by_service/MC3A2.R8.3.html#{%22select%22:true,%22selection%22:{%22hiddenAreaKinds%22:[],%22hiddenSubareaKinds%22:[],%22show%22:false,%22selector%22:{%22enabled%22:true,%22negated%22:true,%22kind%22:0,%22domain%22:%22kind%22,%22inputs%22:[{%22enabled%22:true,%22text%22:%22violation%22}]}}}
>
> https://eclair-analysis-logs.xenproject.org/fs/var/local/eclair/xen-project.ecdf/xen-project/people/sstabellini/xen/ECLAIR_normal/ppp2/ARM64/11238076156/PROJECT.ecd;/by_service/MC3A2.R8.4.html#{%22select%22:true,%22selection%22:{%22hiddenAreaKinds%22:[],%22hiddenSubareaKinds%22:[],%22show%22:false,%22selector%22:{%22enabled%22:true,%22negated%22:true,%22kind%22:0,%22domain%22:%22kind%22,%22inputs%22:[{%22enabled%22:true,%22text%22:%22violation%22}]}}}
>
> Cheers,
>
> Stefano
>
> On Wed, 3 Sep 2025, Oleksii Moisieiev wrote:
>> Inroducing V8 patch series on top of the Xen version 4.20-rc2
>> which includes implementation of the SCI SCMI SMC single-agent support.
>>
>> This patch series is the first chunk of the
>> "xen/arm: scmi: introduce SCI SCMI SMC multi-agent support" which can
>> be found at [0]
>>
>> SCMI-multiagent support will be provided as the followup patch series.
>>
>> [0] https://lore.kernel.org/xen-devel/cover.1753184487.git.oleksii_moisieiev@epam.com/
>>
>> Patch 1 "xen/arm: add generic SCI subsystem"
>> - rebased and refactored
>> - introduced DEVICE_ARM_SCI DT device class and used for SCI drivers probing
>> instead of custom,
>> linker sections based implementation.
>> - added SCI API for Dom0 DT handling, instead of manipulating with ARM arch
>> dom0 code directly.
>> - RFC changes in XEN_DOMCTL_assign_device OP processing
>> - Introduce arch_handle_passthrough_prop call to handle arm specific
>> nodes
>>
>> Patch 2 "xen/arm: scmi-smc: update to be used under sci subsystem"
>> - update driver introduced by commit 3e322bef8bc0 ("xen/arm: firmware: Add SCMI
>> over SMC calls
>> handling layer") be used under sci subsystem.
>> - no functional changes in general
>>
>> Patch 3 "xen/arm: scmi-smc: passthrough SCMI SMC to guest domain
>> This is new change which allows passthrough SCMI SMC, single agent interface to
>> guest domain
>> cover use case "thin Dom0 with guest domain, which serves as Driver domain".
>> See patch commit message for full description.
>>
>> Patch 4 - docs: arm: add docs for SCMI over SMC calls forwarding
>> driver
>> - add documentation section for Simple Arm SCMI over SMC calls
>> forwarding driver.
>>
>> Code can be found at:
>> https://github.com/oleksiimoisieiev/xen/tree/scmi_upstrv5
>>
>> [1] RFC v2:
>> http://patchwork.kernel.org/project/xen-devel/cover/cover.1644341635.git.oleksii_moisieiev@epam.com/
>> [2] RFC v3:
>> https://patchwork.kernel.org/project/xen-devel/patch/20250311111618.1850927-1-grygorii_strashko@epam.com
>> SCMI spec:
>> https://developer.arm.com/documentation/den0056/e/?lang=en
>>
>> SCMI bindings:
>> https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/firmware/arm,scmi.yaml
>> https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/access-controllers/access-controllers.yaml
>>
>> Reference EL3 FW:
>> RPI5: https://github.com/xen-troops/arm-trusted-firmware/commits/rpi5_dev/
>> Renesas v4h:
>> https://github.com/GrygiriiS/arm-trusted-firmware/commits/rcar_gen4_v2.7_v4x-scmi_upd/
>>
>> base-commit: dbe60f244c (Update Xen to 4.21, 2025-02-21)
>>
>> Changes in v8:
>> - reneregated {helpers/types}.gen.go, dropped unneeded parameters
>>
>> Changes in v7:
>> - fix sci_handl_call to make changes more readable
>> - fix build error when DOM0LESS_BUILD is disabled (removed
>> arch_handle_passthrough_prop from the header)
>> - sort headers in alphabetical order in sci.h
>> - sort headers in scmi-smc.c file
>> - Fix commit description.
>> - Move scmi-smc-passthrough definition to match alphaberical order
>> - remove unneeded initialization with NULL
>> - changed u64 to uint64_t
>> - Send warning if iomem permit access was failed
>> - fixed typos
>>
>> Changes in v6:
>> - rebase on top of the latest master
>> - fix return value of sci_dt_finalize() call
>> - add R-b tag
>> - added generated helpers and types go files
>> - rename cmdline parameter to scmi-smc-passthrough
>> - fix goto tag in parse_arm_sci_config
>> - add link to the scmi bindings used in the doc
>> - remove mentions about HVC calls from doc
>> - rename cmdline parameter to scmi-smc-passthrough
>>
>> Changes in v5:
>> - update Maintainers file. Set role as a Reviewer
>> - rebased on the latest master branch
>> - Introduce arch_handle_passthrough_prop call to handle arm specific nodes
>> - rename dom0_scmi_smc_passthrough to scmi_smc_passthrough
>> - rename dom0_scmi_smc_passthrough in documentation
>>
>> Changes in v4:
>> - fix SPDX-License
>> - rename DEVICE_ARM_SCI DT device class to FIRMWARE_DEVICE
>> - move XEN_DOMCTL_assign_device code in separate patch
>> - Add documentation for SCI SCMI drivers
>> - xl.cfg doc
>> - fix comments from Stefano Stabellini
>> - fix toolstack code as sugested by Anthony PERARD
>> - use MATCH_OPTION()
>> - move arm_sci struct and cfg params in "arch_arm"
>> - add SCMI passthrough for dom0less case
>>
>> Grygorii Strashko (3):
>> xen/arm: scmi-smc: update to be used under sci subsystem
>> xen/arm: scmi-smc: passthrough SCMI SMC to domain, single agent
>> docs: arm: add docs for SCMI over SMC calls forwarding driver
>>
>> Oleksii Moisieiev (1):
>> xen/arm: add generic SCI subsystem
>>
>> MAINTAINERS | 6 +
>> .../arm/firmware/arm-scmi.rst | 180 ++++++++++++++++
>> docs/hypervisor-guide/arm/index.rst | 9 +
>> docs/hypervisor-guide/index.rst | 1 +
>> docs/man/xl.cfg.5.pod.in | 34 +++
>> docs/misc/arm/device-tree/booting.txt | 15 ++
>> docs/misc/xen-command-line.pandoc | 9 +
>> tools/golang/xenlight/helpers.gen.go | 35 +++
>> tools/golang/xenlight/types.gen.go | 11 +
>> tools/include/libxl.h | 5 +
>> tools/libs/light/libxl_arm.c | 14 ++
>> tools/libs/light/libxl_types.idl | 10 +
>> tools/xl/xl_parse.c | 36 ++++
>> xen/arch/arm/device.c | 5 +
>> xen/arch/arm/dom0less-build.c | 40 ++++
>> xen/arch/arm/domain.c | 12 +-
>> xen/arch/arm/domain_build.c | 8 +
>> xen/arch/arm/firmware/Kconfig | 25 ++-
>> xen/arch/arm/firmware/Makefile | 1 +
>> xen/arch/arm/firmware/sci.c | 154 ++++++++++++++
>> xen/arch/arm/firmware/scmi-smc.c | 194 +++++++++++++----
>> xen/arch/arm/include/asm/domain.h | 5 +
>> xen/arch/arm/include/asm/firmware/sci.h | 200 ++++++++++++++++++
>> xen/arch/arm/include/asm/firmware/scmi-smc.h | 41 ----
>> xen/arch/arm/vsmc.c | 4 +-
>> xen/common/device-tree/dom0less-build.c | 4 +
>> xen/include/asm-generic/device.h | 1 +
>> xen/include/public/arch-arm.h | 5 +
>> xen/include/xen/dom0less-build.h | 3 +
>> 29 files changed, 982 insertions(+), 85 deletions(-)
>> create mode 100644 docs/hypervisor-guide/arm/firmware/arm-scmi.rst
>> create mode 100644 docs/hypervisor-guide/arm/index.rst
>> create mode 100644 xen/arch/arm/firmware/sci.c
>> create mode 100644 xen/arch/arm/include/asm/firmware/sci.h
>> delete mode 100644 xen/arch/arm/include/asm/firmware/scmi-smc.h
>>
>> --
>> 2.34.1
>>
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2025-09-04 14:11 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-03 13:18 [PATCH v8 0/4] xen/arm: scmi: introduce SCI SCMI SMC single-agent support Oleksii Moisieiev
2025-09-03 13:18 ` [PATCH v8 1/4] xen/arm: add generic SCI subsystem Oleksii Moisieiev
2025-09-03 13:18 ` [PATCH v8 4/4] docs: arm: add docs for SCMI over SMC calls forwarding driver Oleksii Moisieiev
2025-09-03 13:18 ` [PATCH v8 3/4] xen/arm: scmi-smc: passthrough SCMI SMC to domain, single agent Oleksii Moisieiev
2025-09-03 13:18 ` [PATCH v8 2/4] xen/arm: scmi-smc: update to be used under sci subsystem Oleksii Moisieiev
2025-09-03 21:24 ` [PATCH v8 0/4] xen/arm: scmi: introduce SCI SCMI SMC single-agent support Stefano Stabellini
2025-09-03 21:47 ` Volodymyr Babchuk
2025-09-04 7:10 ` Nicola Vetrini
2025-09-04 14:11 ` Oleksii Moisieiev
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.