All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicolas Ferre <nicolas.ferre@microchip.com>
To: Tudor Ambarus <tudor.ambarus@microchip.com>, <ada@thorsis.com>
Cc: <alexandre.belloni@bootlin.com>,
	<ludovic.desroches@microchip.com>, <robh+dt@kernel.org>,
	<bbrezillon@kernel.org>, <linux-arm-kernel@lists.infradead.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<stable@vger.kernel.org>
Subject: Re: [PATCH v2] ARM: dts: at91: sama5d2: Fix PMERRLOC resource size
Date: Thu, 24 Feb 2022 16:10:03 +0100	[thread overview]
Message-ID: <f3f28a3d-b7ec-e91e-1e8d-9d34da76a2a1@microchip.com> (raw)
In-Reply-To: <20220111132301.906712-1-tudor.ambarus@microchip.com>

On 11/01/2022 at 14:23, Tudor Ambarus wrote:
> PMERRLOC resource size was set to 0x100, which resulted in HSMC_ERRLOCx
> register being truncated to offset x = 21, causing error correction to
> fail if more than 22 bit errors and if 24 or 32 bit error correction
> was supported.
> 
> Fixes: d9c41bf30cf8 ("ARM: dts: at91: Declare EBI/NAND controllers")
> Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
> Cc: <stable@vger.kernel.org> # 4.13.x

Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>

Even if it's a fix, as we have this bug for a long time and that we are 
already at rc5 of the stabilization phase, I take it in at91-dt branch 
for 5.18 and not in another "fixes" batch.

Best regards,
   Nicolas

> ---
> v2:
> - update commit description
> - Cc stable@vger.kernel.org
> 
>   arch/arm/boot/dts/sama5d2.dtsi | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/sama5d2.dtsi b/arch/arm/boot/dts/sama5d2.dtsi
> index 09c741e8ecb8..c700c3b19e4c 100644
> --- a/arch/arm/boot/dts/sama5d2.dtsi
> +++ b/arch/arm/boot/dts/sama5d2.dtsi
> @@ -415,7 +415,7 @@ hsmc: hsmc@f8014000 {
>   				pmecc: ecc-engine@f8014070 {
>   					compatible = "atmel,sama5d2-pmecc";
>   					reg = <0xf8014070 0x490>,
> -					      <0xf8014500 0x100>;
> +					      <0xf8014500 0x200>;
>   				};
>   			};
>   


-- 
Nicolas Ferre

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Ferre <nicolas.ferre@microchip.com>
To: Tudor Ambarus <tudor.ambarus@microchip.com>, <ada@thorsis.com>
Cc: <alexandre.belloni@bootlin.com>,
	<ludovic.desroches@microchip.com>, <robh+dt@kernel.org>,
	<bbrezillon@kernel.org>, <linux-arm-kernel@lists.infradead.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<stable@vger.kernel.org>
Subject: Re: [PATCH v2] ARM: dts: at91: sama5d2: Fix PMERRLOC resource size
Date: Thu, 24 Feb 2022 16:10:03 +0100	[thread overview]
Message-ID: <f3f28a3d-b7ec-e91e-1e8d-9d34da76a2a1@microchip.com> (raw)
In-Reply-To: <20220111132301.906712-1-tudor.ambarus@microchip.com>

On 11/01/2022 at 14:23, Tudor Ambarus wrote:
> PMERRLOC resource size was set to 0x100, which resulted in HSMC_ERRLOCx
> register being truncated to offset x = 21, causing error correction to
> fail if more than 22 bit errors and if 24 or 32 bit error correction
> was supported.
> 
> Fixes: d9c41bf30cf8 ("ARM: dts: at91: Declare EBI/NAND controllers")
> Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
> Cc: <stable@vger.kernel.org> # 4.13.x

Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>

Even if it's a fix, as we have this bug for a long time and that we are 
already at rc5 of the stabilization phase, I take it in at91-dt branch 
for 5.18 and not in another "fixes" batch.

Best regards,
   Nicolas

> ---
> v2:
> - update commit description
> - Cc stable@vger.kernel.org
> 
>   arch/arm/boot/dts/sama5d2.dtsi | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/sama5d2.dtsi b/arch/arm/boot/dts/sama5d2.dtsi
> index 09c741e8ecb8..c700c3b19e4c 100644
> --- a/arch/arm/boot/dts/sama5d2.dtsi
> +++ b/arch/arm/boot/dts/sama5d2.dtsi
> @@ -415,7 +415,7 @@ hsmc: hsmc@f8014000 {
>   				pmecc: ecc-engine@f8014070 {
>   					compatible = "atmel,sama5d2-pmecc";
>   					reg = <0xf8014070 0x490>,
> -					      <0xf8014500 0x100>;
> +					      <0xf8014500 0x200>;
>   				};
>   			};
>   


-- 
Nicolas Ferre

  parent reply	other threads:[~2022-02-24 15:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-11 13:23 [PATCH v2] ARM: dts: at91: sama5d2: Fix PMERRLOC resource size Tudor Ambarus
2022-01-11 13:23 ` Tudor Ambarus
2022-01-11 13:34 ` Alexander Dahl
2022-01-11 13:34   ` Alexander Dahl
2022-02-24 15:10 ` Nicolas Ferre [this message]
2022-02-24 15:10   ` Nicolas Ferre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f3f28a3d-b7ec-e91e-1e8d-9d34da76a2a1@microchip.com \
    --to=nicolas.ferre@microchip.com \
    --cc=ada@thorsis.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=bbrezillon@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ludovic.desroches@microchip.com \
    --cc=robh+dt@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=tudor.ambarus@microchip.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.