From: Krzysztof Kozlowski <krzk@kernel.org>
To: linux-aspeed@lists.ozlabs.org
Subject: [PATCH 1/2] dt-bindings: net: aspeed: Add binding for ASPEED AST2700 MDIO
Date: Thu, 5 Sep 2024 13:49:57 +0200 [thread overview]
Message-ID: <f4883736-7c85-44b8-976f-f98b2d270973@kernel.org> (raw)
In-Reply-To: <20240905114754.519609-2-jacky_chou@aspeedtech.com>
On 05/09/2024 13:47, Jacky Chou wrote:
> Add a new compatible for ASPEED AST2700 MDIO.
You have entire commit msg to explain the differences of the hardware,
including whether they are or are not compatible.
>
> Signed-off-by: Jacky Chou <jacky_chou@aspeedtech.com>
> ---
> .../devicetree/bindings/net/aspeed,ast2600-mdio.yaml | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/net/aspeed,ast2600-mdio.yaml b/Documentation/devicetree/bindings/net/aspeed,ast2600-mdio.yaml
> index d6ef468495c5..6dadca099875 100644
> --- a/Documentation/devicetree/bindings/net/aspeed,ast2600-mdio.yaml
> +++ b/Documentation/devicetree/bindings/net/aspeed,ast2600-mdio.yaml
> @@ -19,7 +19,9 @@ allOf:
>
> properties:
> compatible:
> - const: aspeed,ast2600-mdio
> + enum:
> + - aspeed,ast2600-mdio
> + - aspeed,ast2700-mdio
Your driver says something else...
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jacky Chou <jacky_chou@aspeedtech.com>,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, joel@jms.id.au, andrew@codeconstruct.com.au,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk
Subject: Re: [PATCH 1/2] dt-bindings: net: aspeed: Add binding for ASPEED AST2700 MDIO
Date: Thu, 5 Sep 2024 13:49:57 +0200 [thread overview]
Message-ID: <f4883736-7c85-44b8-976f-f98b2d270973@kernel.org> (raw)
In-Reply-To: <20240905114754.519609-2-jacky_chou@aspeedtech.com>
On 05/09/2024 13:47, Jacky Chou wrote:
> Add a new compatible for ASPEED AST2700 MDIO.
You have entire commit msg to explain the differences of the hardware,
including whether they are or are not compatible.
>
> Signed-off-by: Jacky Chou <jacky_chou@aspeedtech.com>
> ---
> .../devicetree/bindings/net/aspeed,ast2600-mdio.yaml | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/net/aspeed,ast2600-mdio.yaml b/Documentation/devicetree/bindings/net/aspeed,ast2600-mdio.yaml
> index d6ef468495c5..6dadca099875 100644
> --- a/Documentation/devicetree/bindings/net/aspeed,ast2600-mdio.yaml
> +++ b/Documentation/devicetree/bindings/net/aspeed,ast2600-mdio.yaml
> @@ -19,7 +19,9 @@ allOf:
>
> properties:
> compatible:
> - const: aspeed,ast2600-mdio
> + enum:
> + - aspeed,ast2600-mdio
> + - aspeed,ast2700-mdio
Your driver says something else...
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-09-05 11:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-05 11:47 [PATCH 0/2] net: mdio: Add ASPEED AST2700 MDIO compatible Jacky Chou
2024-09-05 11:47 ` Jacky Chou
2024-09-05 11:47 ` [PATCH 1/2] dt-bindings: net: aspeed: Add binding for ASPEED AST2700 MDIO Jacky Chou
2024-09-05 11:47 ` Jacky Chou
2024-09-05 11:49 ` Krzysztof Kozlowski [this message]
2024-09-05 11:49 ` Krzysztof Kozlowski
2024-09-05 11:51 ` Krzysztof Kozlowski
2024-09-05 11:51 ` Krzysztof Kozlowski
2024-09-05 11:47 ` [PATCH 2/2] net: mdio: aspeed: Add AST2700 support Jacky Chou
2024-09-05 11:47 ` Jacky Chou
2024-09-05 11:50 ` Krzysztof Kozlowski
2024-09-05 11:50 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4883736-7c85-44b8-976f-f98b2d270973@kernel.org \
--to=krzk@kernel.org \
--cc=linux-aspeed@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.