All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com>,
	intel-gfx@lists.freedesktop.org
Cc: intel-xe@lists.freedesktop.org, uma.shankar@intel.com,
	shawn.c.lee@intel.com, kai.vehmanen@intel.com,
	ankit.k.nautiyal@intel.com, chaitanya.kumar.borah@intel.com,
	suraj.kandpal@intel.com
Subject: Re: [PATCH v3] drm/i915/audio: treat UHBR SST like MST for cpu_transcoder signalling
Date: Tue, 28 Jul 2026 11:59:53 +0300	[thread overview]
Message-ID: <f4e354724191a8d192eb00610179857ac81cac09@intel.com> (raw)
In-Reply-To: <20260708113558.1863316-1-mitulkumar.ajitkumar.golani@intel.com>

On Wed, 08 Jul 2026, Mitul Golani <mitulkumar.ajitkumar.golani@intel.com> wrote:
> Both DP MST and UHBR SST require the audio component to use a real
> cpu_transcoder (>= 0) value to identify the audio stream on a port.
> For DP MST this was already handled; for UHBR SST it was not, causing
> pin_eld_notify() to signal cpu_transcoder = -1 (the legacy SST sentinel)
> and find_audio_state() to skip the per-transcoder entry for the UHBR
> stream.
>
> After suspend/resume or replug, the ELD lookup fails and audio goes
> silent. Fix by detecting UHBR SST alongside DP MST when deciding
> whether a real cpu_transcoder value must be used for audio state
> addressing, in both the pin_eld_notify() signalling and the
> find_audio_state() lookup paths.

[snip]

Going through some merged patches while writing the pull request...

>  
> -	/* Non-MST */
> +	/* Legacy SST. */

Please be careful about tossing around "legacy". It's the bog standard
DP 1.4 non-UHBR SST that's used absolutely everywere that you're talking
about here. It's not "legacy".

BR,
Jani.


-- 
Jani Nikula, Intel

  parent reply	other threads:[~2026-07-28  9:00 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-08 11:35 [PATCH v3] drm/i915/audio: treat UHBR SST like MST for cpu_transcoder signalling Mitul Golani
2026-07-08 11:52 ` ✗ CI.checkpatch: warning for drm/i915/audio: treat UHBR SST like MST for cpu_transcoder signalling (rev3) Patchwork
2026-07-08 11:53 ` ✓ CI.KUnit: success " Patchwork
2026-07-08 12:37 ` ✓ Xe.CI.BAT: " Patchwork
2026-07-08 14:15 ` ✗ i915.CI.BAT: failure " Patchwork
2026-07-08 14:22 ` ✓ Xe.CI.FULL: success " Patchwork
2026-07-08 15:21 ` ✓ i915.CI.BAT: " Patchwork
2026-07-09  4:52 ` [PATCH v3] drm/i915/audio: treat UHBR SST like MST for cpu_transcoder signalling Golani, Mitulkumar Ajitkumar
2026-07-09  4:53   ` Kandpal, Suraj
2026-07-09 10:12 ` ✗ i915.CI.Full: failure for drm/i915/audio: treat UHBR SST like MST for cpu_transcoder signalling (rev3) Patchwork
2026-07-28  8:59 ` Jani Nikula [this message]
2026-07-28  9:00   ` [PATCH v3] drm/i915/audio: treat UHBR SST like MST for cpu_transcoder signalling Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f4e354724191a8d192eb00610179857ac81cac09@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=ankit.k.nautiyal@intel.com \
    --cc=chaitanya.kumar.borah@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=kai.vehmanen@intel.com \
    --cc=mitulkumar.ajitkumar.golani@intel.com \
    --cc=shawn.c.lee@intel.com \
    --cc=suraj.kandpal@intel.com \
    --cc=uma.shankar@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.