From: Chris Wilson <chris@chris-wilson.co.uk>
To: Paulo Zanoni <przanoni@gmail.com>, intel-gfx@lists.freedesktop.org
Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
Subject: Re: [PATCH 3/5] drm/i915: DDI naming standards cleanup
Date: Thu, 06 Dec 2012 13:32:43 +0000 [thread overview]
Message-ID: <f5ae8a$7nro88@fmsmga002.fm.intel.com> (raw)
In-Reply-To: <1354799562-4060-3-git-send-email-przanoni@gmail.com>
On Thu, 6 Dec 2012 11:12:40 -0200, Paulo Zanoni <przanoni@gmail.com> wrote:
> From: Paulo Zanoni <paulo.r.zanoni@intel.com>
>
> A big part of the Haswell display code is called intel_ddi_something
> while a small part of it is called haswell_something. Being consistent
> with the naming standards is a nice thing, so IMHO we should only use
> one of the naming standards for everything.
>
> So instead of converting everything to haswell_something I converted
> to ddi_something, which seems more appropriate IMHO. Now our code
> looks a little bit more consistent.
>
> The next step is to move everything to intel_ddi.c.
Nak. Now you are really muddying the waters between generation
specific paths and one implementation of a display engine.
A few chunks are good; where you are indeed checking for the digital
ports, but most look silly.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-12-06 13:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-06 13:12 [PATCH 1/5] drm/i915: check for the PCH when setting pch_transcoder Paulo Zanoni
2012-12-06 13:12 ` [PATCH 2/5] drm/i915: remove leftover display.update_wm assignment Paulo Zanoni
2012-12-06 13:12 ` [PATCH 3/5] drm/i915: DDI naming standards cleanup Paulo Zanoni
2012-12-06 13:32 ` Chris Wilson [this message]
2012-12-06 18:24 ` Paulo Zanoni
2012-12-06 13:12 ` [PATCH 4/5] drm/i915: add intel_dp_set_sinal_levels Paulo Zanoni
2012-12-06 18:51 ` [PATCH 4/5] drm/i915: add intel_dp_set_signal_levels Paulo Zanoni
2012-12-06 13:12 ` [PATCH 5/5] drm/i915: add DP aux ctl regs to struct intel_dp Paulo Zanoni
2012-12-06 18:53 ` Paulo Zanoni
2012-12-17 11:45 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='f5ae8a$7nro88@fmsmga002.fm.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=paulo.r.zanoni@intel.com \
--cc=przanoni@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.