Re: [PATCH v5 3/3] ath11k: Add support for beacon tx mode

[Jeff Johnson <jjohnson@codeaurora.org>]

On 2021-08-10 01:56, Maharaja Kennadyrajan wrote:
> Add support to configure the beacon tx mode in
> the driver.
> 
> Beacons can be sent out in burst(continuously in a single shot
> one after another) or staggered (equally spread out over beacon
> interval) mode.
> 
> Use the below configuration in the hostapd/wpa_supplicant
> for AP/MESH mode to configure the beacon tx mode.
> 
> "beacon_tx_mode=N", where N = 1 for STAGGERED beacon mode
> and N = 2 for BURST beacon mode.
> 
> Tested-on: IPQ8074 hw2.0 AHB WLAN.HK.2.5.0.1-00480-QCAHKSWPL_SILICONZ-1
> 
> Signed-off-by: Maharaja Kennadyrajan <mkenna@codeaurora.org>
> ---
>  drivers/net/wireless/ath/ath11k/mac.c | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/wireless/ath/ath11k/mac.c
> b/drivers/net/wireless/ath/ath11k/mac.c
> index e9b3689..2eda788 100644
> --- a/drivers/net/wireless/ath/ath11k/mac.c
> +++ b/drivers/net/wireless/ath/ath11k/mac.c
> @@ -2136,7 +2136,10 @@ static void 
> ath11k_mac_op_bss_info_changed(struct
> ieee80211_hw *hw,
> 
>  	if (changed & BSS_CHANGED_BEACON) {
>  		param_id = WMI_PDEV_PARAM_BEACON_TX_MODE;
> -		param_value = WMI_BEACON_STAGGERED_MODE;
> +		if (info->beacon_tx_mode == NL80211_BEACON_BURST_MODE)
> +			param_value = WMI_BEACON_BURST_MODE;
> +		else
> +			param_value = WMI_BEACON_STAGGERED_MODE;
>  		ret = ath11k_wmi_pdev_set_param(ar, param_id,
>  						param_value,
> ar->pdev->pdev_id);
>  		if (ret)
> @@ -2144,8 +2147,9 @@ static void ath11k_mac_op_bss_info_changed(struct
> ieee80211_hw *hw,
>  				    arvif->vdev_id);
>  		else
>  			ath11k_dbg(ar->ab, ATH11K_DBG_MAC,
> -				   "Set staggered beacon mode for VDEV:
> %d\n",
> -				   arvif->vdev_id);
> +				   "Set %s beacon mode for VDEV: %d mode:
> %d\n",
> +				   param_value ? "burst" : "staggered",

Suggest this should be param_value == WMI_BEACON_BURST_MODE ?
or other similar logic since ideally code should avoid making 
assumptions about the values assigned to enumerators

> +				   arvif->vdev_id, param_value);
> 
>  		ret = ath11k_mac_setup_bcn_tmpl(arvif);
>  		if (ret)
> --
> 2.7.4

-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora 
Forum,
a Linux Foundation Collaborative Project

-- 
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k