[meta-oe][PATCH] influxdb: remove S in recipes that fetch from git via setting BB_GIT_DEFAULT_DESTSUFFIX

[meta-oe][PATCH] influxdb: remove S in recipes that fetch from git via setting BB_GIT_DEFAULT_DESTSUFFIX

[Alper Ak]

Removing all the S = ${WORKDIR}/git assignments works because BB_GIT_DEFAULT_DESTSUFFIX
is set to match S from bitbake.conf (which itself is set to match typical tarball
releases).

ERROR: influxdb-1.8.10-r0 do_unpack: Recipes that set S = "${WORKDIR}/git" or S = "${UNPACKDIR}/git" should remove that assignment, as S set by bitbake.conf in oe-core now works.

Signed-off-by: Alper Ak <alperyasinak1@gmail.com>
---
 meta-oe/recipes-dbs/influxdb/influxdb_1.8.10.bb | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/meta-oe/recipes-dbs/influxdb/influxdb_1.8.10.bb b/meta-oe/recipes-dbs/influxdb/influxdb_1.8.10.bb
index 2ad68d679a..cc305f6e8d 100644
--- a/meta-oe/recipes-dbs/influxdb/influxdb_1.8.10.bb
+++ b/meta-oe/recipes-dbs/influxdb/influxdb_1.8.10.bb
@@ -6,7 +6,7 @@ LIC_FILES_CHKSUM = "file://src/${GO_IMPORT}/LICENSE;md5=f39a8d10930fb37bd59adabb
 require ${BPN}-licenses.inc
 
 SRC_URI = "\
-    git://${GO_IMPORT};protocol=https;branch=1.8;destsuffix=git/src/${GO_IMPORT} \
+    git://${GO_IMPORT};protocol=https;branch=1.8;destsuffix=${BB_GIT_DEFAULT_DESTSUFFIX}/src/${GO_IMPORT} \
     file://0001-Use-v2.1.2-xxhash-to-fix-build-with-go-1.17.patch;patchdir=src/${GO_IMPORT} \
     file://0001-patch-term-module-for-mips-ispeed-ospeed-termios-abs.patch;patchdir=src/${GO_IMPORT} \
     file://influxdb \
@@ -16,8 +16,6 @@ require ${BPN}-go-mods.inc
 
 SRCREV = "688e697c51fd5353725da078555adbeff0363d01"
 
-S = "${WORKDIR}/git"
-
 GO_IMPORT = "github.com/influxdata/influxdb"
 GO_INSTALL = "\
     ${GO_IMPORT}/cmd/influx \
-- 
2.43.0

Re: [oe] [meta-oe][PATCH] influxdb: remove S in recipes that fetch from git via setting BB_GIT_DEFAULT_DESTSUFFIX

[Christian Lindeberg]

On 21/06/2025 11:49, Alper Ak via lists.openembedded.org wrote:
> Removing all the S = ${WORKDIR}/git assignments works because BB_GIT_DEFAULT_DESTSUFFIX
> is set to match S from bitbake.conf (which itself is set to match typical tarball
> releases).
Oh, I should have used GO_SRCURI_DESTSUFFIX instead as in crucible even 
though
the explicit value kind of made sense at the moment together with the patch
git URIs below.

Christian