From: Binbin Wu <binbin.wu@linux.intel.com>
To: "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>
Cc: "Gao, Chao" <chao.gao@intel.com>,
"seanjc@google.com" <seanjc@google.com>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
"kas@kernel.org" <kas@kernel.org>,
"Li, Xiaoyao" <xiaoyao.li@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Maloor, Kishen" <kishen.maloor@intel.com>,
"tony.lindgren@linux.intel.com" <tony.lindgren@linux.intel.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"pbonzini@redhat.com" <pbonzini@redhat.com>,
"nik.borisov@suse.com" <nik.borisov@suse.com>,
"dedekind1@gmail.com" <dedekind1@gmail.com>,
"andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>
Subject: Re: [PATCH v4 3/4] KVM: TDX: Filter configurable CPUID bits
Date: Fri, 9 Oct 2026 17:26:32 +0800 [thread overview]
Message-ID: <f6bfb1f1-18ae-467c-86f6-8e15567281b4@linux.intel.com> (raw)
In-Reply-To: <e7182b3c03a0e39cb60392b4d75111255418d6cf.camel@intel.com>
On 9/23/2026 8:34 AM, Edgecombe, Rick P wrote:
> On Wed, 2026-09-23 at 08:28 +0800, Binbin Wu wrote:
>> Xiaoyao mentioned it in v3 too.
>>
>> Sean suggested in v2 that "Realistically, CPUID.0x1.E{A,B}X are never going to be
>> repurposed to hold feature bits, and so generating a mask of allowed bits adds
>> unnecessary cognitive load and maintenance. Ditto for CPUID 0x4, 0x18, and 0x1F."
>> https://lore.kernel.org/kvm/aj1fi_0SBxMK5WOB@google.com/
>>
>> If we really have concerns, I can change it to exclude reserved bits in the next
>> version.
>
> Could we check the x86 arch folks real quick?
Still waiting on confirmation.
But per the Intel SDM and AMD APM definitions, the following leaves/registers
are defined for specific metadata/parameters and should not be repurposed for
feature flags::
- CPUID.0x1.EAX is defined for Version Information
- CPUID.0x4 is defined for Deterministic Cache Parameters.
- CPUID.0x18 is defined for Deterministic Address Translation Parameters.
- CPUID.0x1f is defined for V2 Extended Topology.
- CPUID.0x80000008.EAX is defined for Long Mode Size Identifiers.
Additionally, CPUID.0x1.EBX has no reserved bit.
> If Sean is ok betting on this
> though, I'm ok too.
next prev parent reply other threads:[~2026-10-09 9:26 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-17 7:25 [PATCH v4 0/4] KVM: TDX: Validate directly configurable CPUID bits Binbin Wu
2026-09-17 7:25 ` [PATCH v4 1/4] KVM: TDX: Track configurable CPUID bits allowed by KVM Binbin Wu
2026-09-23 0:01 ` Edgecombe, Rick P
2026-09-23 0:14 ` Binbin Wu
2026-09-23 0:45 ` Edgecombe, Rick P
2026-09-23 0:57 ` Binbin Wu
2026-09-23 1:09 ` Edgecombe, Rick P
2026-09-23 1:17 ` Binbin Wu
2026-09-23 11:21 ` Xiaoyao Li
2026-09-23 14:25 ` Edgecombe, Rick P
2026-09-24 2:05 ` Xiaoyao Li
2026-09-24 6:36 ` Xiaoyao Li
2026-09-24 7:49 ` Binbin Wu
2026-09-24 9:30 ` Xiaoyao Li
2026-09-24 11:41 ` Binbin Wu
2026-09-24 13:55 ` Xiaoyao Li
2026-09-24 15:10 ` Binbin Wu
2026-09-24 14:33 ` Xiaoyao Li
2026-09-28 8:08 ` Binbin Wu
2026-09-28 23:58 ` Edgecombe, Rick P
2026-09-29 0:19 ` Binbin Wu
2026-09-17 7:25 ` [PATCH v4 2/4] KVM: TDX: Report CORE_CAPABILITIES as configurable Binbin Wu
2026-09-22 21:11 ` Edgecombe, Rick P
2026-09-23 0:03 ` Binbin Wu
2026-09-24 6:44 ` Xiaoyao Li
2026-09-17 7:25 ` [PATCH v4 3/4] KVM: TDX: Filter configurable CPUID bits Binbin Wu
2026-09-23 0:16 ` Edgecombe, Rick P
2026-09-23 0:28 ` Binbin Wu
2026-09-23 0:34 ` Edgecombe, Rick P
2026-10-09 9:26 ` Binbin Wu [this message]
2026-09-17 7:25 ` [PATCH v4 4/4] KVM: TDX: Validate userspace CPUID input for KVM_TDX_INIT_VM Binbin Wu
2026-09-23 0:16 ` Edgecombe, Rick P
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f6bfb1f1-18ae-467c-86f6-8e15567281b4@linux.intel.com \
--to=binbin.wu@linux.intel.com \
--cc=andrew.cooper3@citrix.com \
--cc=chao.gao@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=dedekind1@gmail.com \
--cc=kas@kernel.org \
--cc=kishen.maloor@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nik.borisov@suse.com \
--cc=pbonzini@redhat.com \
--cc=rick.p.edgecombe@intel.com \
--cc=seanjc@google.com \
--cc=tony.lindgren@linux.intel.com \
--cc=xiaoyao.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.