All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] abseil-cpp: readd use of -std=c++14
@ 2024-01-09 12:43 throos
  2024-01-09 13:14 ` [oe] " Petr Chernikov
       [not found] ` <17A8B01D06ADC5D0.21327@lists.openembedded.org>
  0 siblings, 2 replies; 5+ messages in thread
From: throos @ 2024-01-09 12:43 UTC (permalink / raw)
  To: openembedded-devel; +Cc: Thomas Roos

From: Thomas Roos <throos@amazon.de>

Protobuf is compiled with -std=c++14, so abseil-cpp must be as well.
Details can be found here: https://github.com/protocolbuffers/protobuf/issues/10768

Signed-off-by: Thomas Roos <throos@amazon.de>
---
 meta-oe/recipes-devtools/abseil-cpp/abseil-cpp_git.bb | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta-oe/recipes-devtools/abseil-cpp/abseil-cpp_git.bb b/meta-oe/recipes-devtools/abseil-cpp/abseil-cpp_git.bb
index ee62d4b59..1a713e1c5 100644
--- a/meta-oe/recipes-devtools/abseil-cpp/abseil-cpp_git.bb
+++ b/meta-oe/recipes-devtools/abseil-cpp/abseil-cpp_git.bb
@@ -26,6 +26,7 @@ ASNEEDED:class-nativesdk = ""
 inherit cmake
 
 EXTRA_OECMAKE = "-DBUILD_SHARED_LIBS=ON \
+                 -DCMAKE_CXX_STANDARD=14 \
                  -DBUILD_TESTING=OFF    \
                  -DABSL_ENABLE_INSTALL=ON \
                 "
-- 
2.34.1




Amazon Web Services EMEA SARL
38 avenue John F. Kennedy, L-1855 Luxembourg
Sitz der Gesellschaft: L-1855 Luxemburg
eingetragen im Luxemburgischen Handelsregister unter R.C.S. B186284

Amazon Web Services EMEA SARL, Niederlassung Deutschland
Marcel-Breuer-Str. 12, D-80807 Muenchen
Sitz der Zweigniederlassung: Muenchen
eingetragen im Handelsregister des Amtsgerichts Muenchen unter HRB 242240, USt-ID DE317013094






^ permalink raw reply related	[flat|nested] 5+ messages in thread

* RE: [oe] [PATCH] abseil-cpp: readd use of -std=c++14
  2024-01-09 12:43 [PATCH] abseil-cpp: readd use of -std=c++14 throos
@ 2024-01-09 13:14 ` Petr Chernikov
       [not found] ` <17A8B01D06ADC5D0.21327@lists.openembedded.org>
  1 sibling, 0 replies; 5+ messages in thread
From: Petr Chernikov @ 2024-01-09 13:14 UTC (permalink / raw)
  To: throos@amazon.de, openembedded-devel@lists.openembedded.org

Perhaps, better solution is to use c++17 for both packages:
https://github.com/protocolbuffers/protobuf/issues/10768#issuecomment-1773175439

Regards
Pete

-----Original Message-----
From: openembedded-devel@lists.openembedded.org <openembedded-devel@lists.openembedded.org> On Behalf Of Thomas Roos via lists.openembedded.org
Sent: Tuesday, January 9, 2024 3:44 PM
To: openembedded-devel@lists.openembedded.org
Cc: Thomas Roos <throos@amazon.de>
Subject: [oe] [PATCH] abseil-cpp: readd use of -std=c++14

From: Thomas Roos <throos@amazon.de>

Protobuf is compiled with -std=c++14, so abseil-cpp must be as well.
Details can be found here: https://github.com/protocolbuffers/protobuf/issues/10768

Signed-off-by: Thomas Roos <throos@amazon.de>
---
 meta-oe/recipes-devtools/abseil-cpp/abseil-cpp_git.bb | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta-oe/recipes-devtools/abseil-cpp/abseil-cpp_git.bb b/meta-oe/recipes-devtools/abseil-cpp/abseil-cpp_git.bb
index ee62d4b59..1a713e1c5 100644
--- a/meta-oe/recipes-devtools/abseil-cpp/abseil-cpp_git.bb
+++ b/meta-oe/recipes-devtools/abseil-cpp/abseil-cpp_git.bb
@@ -26,6 +26,7 @@ ASNEEDED:class-nativesdk = ""
 inherit cmake

 EXTRA_OECMAKE = "-DBUILD_SHARED_LIBS=ON \
+                 -DCMAKE_CXX_STANDARD=14 \
                  -DBUILD_TESTING=OFF    \
                  -DABSL_ENABLE_INSTALL=ON \
                 "
--
2.34.1




Amazon Web Services EMEA SARL
38 avenue John F. Kennedy, L-1855 Luxembourg Sitz der Gesellschaft: L-1855 Luxemburg eingetragen im Luxemburgischen Handelsregister unter R.C.S. B186284

Amazon Web Services EMEA SARL, Niederlassung Deutschland Marcel-Breuer-Str. 12, D-80807 Muenchen Sitz der Zweigniederlassung: Muenchen eingetragen im Handelsregister des Amtsgerichts Muenchen unter HRB 242240, USt-ID DE317013094





^ permalink raw reply related	[flat|nested] 5+ messages in thread

* RE: [oe] [PATCH] abseil-cpp: readd use of -std=c++14
       [not found] ` <17A8B01D06ADC5D0.21327@lists.openembedded.org>
@ 2024-01-09 13:24   ` Petr Chernikov
       [not found]   ` <17A8B0A1D52DEE2E.21327@lists.openembedded.org>
  1 sibling, 0 replies; 5+ messages in thread
From: Petr Chernikov @ 2024-01-09 13:24 UTC (permalink / raw)
  To: Petr Chernikov, throos@amazon.de,
	openembedded-devel@lists.openembedded.org

Also I'm able to compile protobuf and protobuf-native without any changes on nanbield branch

Regards
Pete

-----Original Message-----
From: openembedded-devel@lists.openembedded.org <openembedded-devel@lists.openembedded.org> On Behalf Of Petr Chernikov
Sent: Tuesday, January 9, 2024 4:15 PM
To: throos@amazon.de; openembedded-devel@lists.openembedded.org
Subject: Re: [oe] [PATCH] abseil-cpp: readd use of -std=c++14

Perhaps, better solution is to use c++17 for both packages:
https://github.com/protocolbuffers/protobuf/issues/10768#issuecomment-1773175439

Regards
Pete

-----Original Message-----
From: openembedded-devel@lists.openembedded.org <openembedded-devel@lists.openembedded.org> On Behalf Of Thomas Roos via lists.openembedded.org
Sent: Tuesday, January 9, 2024 3:44 PM
To: openembedded-devel@lists.openembedded.org
Cc: Thomas Roos <throos@amazon.de>
Subject: [oe] [PATCH] abseil-cpp: readd use of -std=c++14

From: Thomas Roos <throos@amazon.de>

Protobuf is compiled with -std=c++14, so abseil-cpp must be as well.
Details can be found here: https://github.com/protocolbuffers/protobuf/issues/10768

Signed-off-by: Thomas Roos <throos@amazon.de>
---
 meta-oe/recipes-devtools/abseil-cpp/abseil-cpp_git.bb | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta-oe/recipes-devtools/abseil-cpp/abseil-cpp_git.bb b/meta-oe/recipes-devtools/abseil-cpp/abseil-cpp_git.bb
index ee62d4b59..1a713e1c5 100644
--- a/meta-oe/recipes-devtools/abseil-cpp/abseil-cpp_git.bb
+++ b/meta-oe/recipes-devtools/abseil-cpp/abseil-cpp_git.bb
@@ -26,6 +26,7 @@ ASNEEDED:class-nativesdk = ""
 inherit cmake

 EXTRA_OECMAKE = "-DBUILD_SHARED_LIBS=ON \
+                 -DCMAKE_CXX_STANDARD=14 \
                  -DBUILD_TESTING=OFF    \
                  -DABSL_ENABLE_INSTALL=ON \
                 "
--
2.34.1




Amazon Web Services EMEA SARL
38 avenue John F. Kennedy, L-1855 Luxembourg Sitz der Gesellschaft: L-1855 Luxemburg eingetragen im Luxemburgischen Handelsregister unter R.C.S. B186284

Amazon Web Services EMEA SARL, Niederlassung Deutschland Marcel-Breuer-Str. 12, D-80807 Muenchen Sitz der Zweigniederlassung: Muenchen eingetragen im Handelsregister des Amtsgerichts Muenchen unter HRB 242240, USt-ID DE317013094





^ permalink raw reply related	[flat|nested] 5+ messages in thread

* RE: [oe] [PATCH] abseil-cpp: readd use of -std=c++14
       [not found]   ` <17A8B0A1D52DEE2E.21327@lists.openembedded.org>
@ 2024-01-09 13:26     ` Petr Chernikov
  2024-01-09 15:01       ` AW: " Roos, Thomas
  0 siblings, 1 reply; 5+ messages in thread
From: Petr Chernikov @ 2024-01-09 13:26 UTC (permalink / raw)
  To: Petr Chernikov, throos@amazon.de,
	openembedded-devel@lists.openembedded.org

Sorry, typo, on the master branch

Regards
Pete

-----Original Message-----
From: openembedded-devel@lists.openembedded.org <openembedded-devel@lists.openembedded.org> On Behalf Of Petr Chernikov
Sent: Tuesday, January 9, 2024 4:24 PM
To: Petr Chernikov <p.chernikov@yadro.com>; throos@amazon.de; openembedded-devel@lists.openembedded.org
Subject: Re: [oe] [PATCH] abseil-cpp: readd use of -std=c++14

Also I'm able to compile protobuf and protobuf-native without any changes on nanbield branch

Regards
Pete

-----Original Message-----
From: openembedded-devel@lists.openembedded.org <openembedded-devel@lists.openembedded.org> On Behalf Of Petr Chernikov
Sent: Tuesday, January 9, 2024 4:15 PM
To: throos@amazon.de; openembedded-devel@lists.openembedded.org
Subject: Re: [oe] [PATCH] abseil-cpp: readd use of -std=c++14

Perhaps, better solution is to use c++17 for both packages:
https://github.com/protocolbuffers/protobuf/issues/10768#issuecomment-1773175439

Regards
Pete

-----Original Message-----
From: openembedded-devel@lists.openembedded.org <openembedded-devel@lists.openembedded.org> On Behalf Of Thomas Roos via lists.openembedded.org
Sent: Tuesday, January 9, 2024 3:44 PM
To: openembedded-devel@lists.openembedded.org
Cc: Thomas Roos <throos@amazon.de>
Subject: [oe] [PATCH] abseil-cpp: readd use of -std=c++14

From: Thomas Roos <throos@amazon.de>

Protobuf is compiled with -std=c++14, so abseil-cpp must be as well.
Details can be found here: https://github.com/protocolbuffers/protobuf/issues/10768

Signed-off-by: Thomas Roos <throos@amazon.de>
---
 meta-oe/recipes-devtools/abseil-cpp/abseil-cpp_git.bb | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta-oe/recipes-devtools/abseil-cpp/abseil-cpp_git.bb b/meta-oe/recipes-devtools/abseil-cpp/abseil-cpp_git.bb
index ee62d4b59..1a713e1c5 100644
--- a/meta-oe/recipes-devtools/abseil-cpp/abseil-cpp_git.bb
+++ b/meta-oe/recipes-devtools/abseil-cpp/abseil-cpp_git.bb
@@ -26,6 +26,7 @@ ASNEEDED:class-nativesdk = ""
 inherit cmake

 EXTRA_OECMAKE = "-DBUILD_SHARED_LIBS=ON \
+                 -DCMAKE_CXX_STANDARD=14 \
                  -DBUILD_TESTING=OFF    \
                  -DABSL_ENABLE_INSTALL=ON \
                 "
--
2.34.1




Amazon Web Services EMEA SARL
38 avenue John F. Kennedy, L-1855 Luxembourg Sitz der Gesellschaft: L-1855 Luxemburg eingetragen im Luxemburgischen Handelsregister unter R.C.S. B186284

Amazon Web Services EMEA SARL, Niederlassung Deutschland Marcel-Breuer-Str. 12, D-80807 Muenchen Sitz der Zweigniederlassung: Muenchen eingetragen im Handelsregister des Amtsgerichts Muenchen unter HRB 242240, USt-ID DE317013094





^ permalink raw reply related	[flat|nested] 5+ messages in thread

* AW: [oe] [PATCH] abseil-cpp: readd use of -std=c++14
  2024-01-09 13:26     ` Petr Chernikov
@ 2024-01-09 15:01       ` Roos, Thomas
  0 siblings, 0 replies; 5+ messages in thread
From: Roos, Thomas @ 2024-01-09 15:01 UTC (permalink / raw)
  To: Petr Chernikov, openembedded-devel@lists.openembedded.org

[-- Attachment #1: Type: text/plain, Size: 3776 bytes --]


Hi,
good news - I could solve this problem by patching out the hardcoded -std=c++14 in our software (meta-aws).
Sorry for the noise.
Please ignore this patch.

Cheers,
Thomas


________________________________
Von: Petr Chernikov <p.chernikov@yadro.com>
Gesendet: Dienstag, 9. Januar 2024 14:26:20
An: Petr Chernikov; Roos, Thomas; openembedded-devel@lists.openembedded.org
Betreff: RE: [EXTERNAL] [oe] [PATCH] abseil-cpp: readd use of -std=c++14

CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.



Sorry, typo, on the master branch

Regards
Pete

-----Original Message-----
From: openembedded-devel@lists.openembedded.org <openembedded-devel@lists.openembedded.org> On Behalf Of Petr Chernikov
Sent: Tuesday, January 9, 2024 4:24 PM
To: Petr Chernikov <p.chernikov@yadro.com>; throos@amazon.de; openembedded-devel@lists.openembedded.org
Subject: Re: [oe] [PATCH] abseil-cpp: readd use of -std=c++14

Also I'm able to compile protobuf and protobuf-native without any changes on nanbield branch

Regards
Pete

-----Original Message-----
From: openembedded-devel@lists.openembedded.org <openembedded-devel@lists.openembedded.org> On Behalf Of Petr Chernikov
Sent: Tuesday, January 9, 2024 4:15 PM
To: throos@amazon.de; openembedded-devel@lists.openembedded.org
Subject: Re: [oe] [PATCH] abseil-cpp: readd use of -std=c++14

Perhaps, better solution is to use c++17 for both packages:
https://github.com/protocolbuffers/protobuf/issues/10768#issuecomment-1773175439

Regards
Pete

-----Original Message-----
From: openembedded-devel@lists.openembedded.org <openembedded-devel@lists.openembedded.org> On Behalf Of Thomas Roos via lists.openembedded.org
Sent: Tuesday, January 9, 2024 3:44 PM
To: openembedded-devel@lists.openembedded.org
Cc: Thomas Roos <throos@amazon.de>
Subject: [oe] [PATCH] abseil-cpp: readd use of -std=c++14

From: Thomas Roos <throos@amazon.de>

Protobuf is compiled with -std=c++14, so abseil-cpp must be as well.
Details can be found here: https://github.com/protocolbuffers/protobuf/issues/10768

Signed-off-by: Thomas Roos <throos@amazon.de>
---
 meta-oe/recipes-devtools/abseil-cpp/abseil-cpp_git.bb | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta-oe/recipes-devtools/abseil-cpp/abseil-cpp_git.bb b/meta-oe/recipes-devtools/abseil-cpp/abseil-cpp_git.bb
index ee62d4b59..1a713e1c5 100644
--- a/meta-oe/recipes-devtools/abseil-cpp/abseil-cpp_git.bb
+++ b/meta-oe/recipes-devtools/abseil-cpp/abseil-cpp_git.bb
@@ -26,6 +26,7 @@ ASNEEDED:class-nativesdk = ""
 inherit cmake

 EXTRA_OECMAKE = "-DBUILD_SHARED_LIBS=ON \
+                 -DCMAKE_CXX_STANDARD=14 \
                  -DBUILD_TESTING=OFF    \
                  -DABSL_ENABLE_INSTALL=ON \
                 "
--
2.34.1




Amazon Web Services EMEA SARL
38 avenue John F. Kennedy, L-1855 Luxembourg Sitz der Gesellschaft: L-1855 Luxemburg eingetragen im Luxemburgischen Handelsregister unter R.C.S. B186284

Amazon Web Services EMEA SARL, Niederlassung Deutschland Marcel-Breuer-Str. 12, D-80807 Muenchen Sitz der Zweigniederlassung: Muenchen eingetragen im Handelsregister des Amtsgerichts Muenchen unter HRB 242240, USt-ID DE317013094







Amazon Web Services EMEA SARL
38 avenue John F. Kennedy, L-1855 Luxembourg
Sitz der Gesellschaft: L-1855 Luxemburg
eingetragen im Luxemburgischen Handelsregister unter R.C.S. B186284

Amazon Web Services EMEA SARL, Niederlassung Deutschland
Marcel-Breuer-Str. 12, D-80807 Muenchen
Sitz der Zweigniederlassung: Muenchen
eingetragen im Handelsregister des Amtsgerichts Muenchen unter HRB 242240, USt-ID DE317013094




[-- Attachment #2: Type: text/html, Size: 6057 bytes --]

^ permalink raw reply related	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2024-01-09 15:01 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-09 12:43 [PATCH] abseil-cpp: readd use of -std=c++14 throos
2024-01-09 13:14 ` [oe] " Petr Chernikov
     [not found] ` <17A8B01D06ADC5D0.21327@lists.openembedded.org>
2024-01-09 13:24   ` Petr Chernikov
     [not found]   ` <17A8B0A1D52DEE2E.21327@lists.openembedded.org>
2024-01-09 13:26     ` Petr Chernikov
2024-01-09 15:01       ` AW: " Roos, Thomas

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.