From: Florian Fainelli <f.fainelli@gmail.com>
To: Wolfram Sang <wsa@kernel.org>,
linux-kernel@vger.kernel.org, Kamal Dasu <kdasu.kdev@gmail.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
"open list:BROADCOM BRCMSTB I2C DRIVER"
<linux-i2c@vger.kernel.org>,
"moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] i2c: brcmstb: Fixed adapter named with optional interrupts
Date: Mon, 18 Jul 2022 21:06:59 -0700 [thread overview]
Message-ID: <f77038b5-93f5-1a06-c433-2086df8c3f3d@gmail.com> (raw)
In-Reply-To: <YtYrnlmpfRxcWMga@shikoro>
On 7/18/2022 8:57 PM, Wolfram Sang wrote:
>
>> I was not sure if we could change the adapter name reported as one could
>> argue this is now ABI, but if we can, then using dev_name() is probably
>> better. You are the maintainer you so know the rules on what is considered
>> stable ABI and what is not :)
>
> Well, then even removing ":" would break the ABI :)
>
> Please use dev_name. Other drivers changed that string, too. We never
> gave guarantees for that one.
>
Fair enough, sent a v2 using dev_name(), thanks!
--
Florian
WARNING: multiple messages have this Message-ID (diff)
From: Florian Fainelli <f.fainelli@gmail.com>
To: Wolfram Sang <wsa@kernel.org>,
linux-kernel@vger.kernel.org, Kamal Dasu <kdasu.kdev@gmail.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
"open list:BROADCOM BRCMSTB I2C DRIVER"
<linux-i2c@vger.kernel.org>,
"moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] i2c: brcmstb: Fixed adapter named with optional interrupts
Date: Mon, 18 Jul 2022 21:06:59 -0700 [thread overview]
Message-ID: <f77038b5-93f5-1a06-c433-2086df8c3f3d@gmail.com> (raw)
In-Reply-To: <YtYrnlmpfRxcWMga@shikoro>
On 7/18/2022 8:57 PM, Wolfram Sang wrote:
>
>> I was not sure if we could change the adapter name reported as one could
>> argue this is now ABI, but if we can, then using dev_name() is probably
>> better. You are the maintainer you so know the rules on what is considered
>> stable ABI and what is not :)
>
> Well, then even removing ":" would break the ABI :)
>
> Please use dev_name. Other drivers changed that string, too. We never
> gave guarantees for that one.
>
Fair enough, sent a v2 using dev_name(), thanks!
--
Florian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-07-19 4:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-06 17:21 [PATCH] i2c: brcmstb: Fixed adapter named with optional interrupts Florian Fainelli
2022-07-06 17:21 ` Florian Fainelli
2022-07-16 12:40 ` Wolfram Sang
2022-07-16 12:40 ` Wolfram Sang
2022-07-19 0:15 ` Florian Fainelli
2022-07-19 0:15 ` Florian Fainelli
2022-07-19 3:57 ` Wolfram Sang
2022-07-19 3:57 ` Wolfram Sang
2022-07-19 4:06 ` Florian Fainelli [this message]
2022-07-19 4:06 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f77038b5-93f5-1a06-c433-2086df8c3f3d@gmail.com \
--to=f.fainelli@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=kdasu.kdev@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.