* [PATCH][master] poky-tiny: fix PACKAGE_EXCLUDE
@ 2023-11-06 10:35 ross.burton
2023-11-06 10:44 ` [OE-core] " Richard Purdie
0 siblings, 1 reply; 4+ messages in thread
From: ross.burton @ 2023-11-06 10:35 UTC (permalink / raw)
To: openembedded-core; +Cc: nd
From: Ross Burton <ross.burton@arm.com>
poky-tiny does a PACKAGE_EXCLUDE on shadow-base as the kernel doesn't
support multiple users. However it does this by assigning to an
override, which makes it impossible for images or machines to extend
PACKAGE_INCLUDE with their own exclusions.
Signed-off-by: Ross Burton <ross.burton@arm.com>
---
meta-poky/conf/distro/poky-tiny.conf | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta-poky/conf/distro/poky-tiny.conf b/meta-poky/conf/distro/poky-tiny.conf
index 32c2ec3e1fa..24bcbee9bb6 100644
--- a/meta-poky/conf/distro/poky-tiny.conf
+++ b/meta-poky/conf/distro/poky-tiny.conf
@@ -125,4 +125,4 @@ PACKAGECONFIG:remove:pn-opkg-utils = "python"
# If shadow-base is brought into the image, logins will fail because it
# doesn't have the heuristics to work when CONFIG_MULTIUSER is unset.
-PACKAGE_EXCLUDE:poky-tiny = "shadow-base"
+PACKAGE_EXCLUDE += "shadow-base"
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [OE-core] [PATCH][master] poky-tiny: fix PACKAGE_EXCLUDE
2023-11-06 10:35 [PATCH][master] poky-tiny: fix PACKAGE_EXCLUDE ross.burton
@ 2023-11-06 10:44 ` Richard Purdie
2023-11-06 10:55 ` Ross Burton
0 siblings, 1 reply; 4+ messages in thread
From: Richard Purdie @ 2023-11-06 10:44 UTC (permalink / raw)
To: Ross Burton, openembedded-core; +Cc: nd
On Mon, 2023-11-06 at 10:35 +0000, Ross Burton wrote:
> From: Ross Burton <ross.burton@arm.com>
>
> poky-tiny does a PACKAGE_EXCLUDE on shadow-base as the kernel doesn't
> support multiple users. However it does this by assigning to an
> override, which makes it impossible for images or machines to extend
> PACKAGE_INCLUDE with their own exclusions.
PACKAGE_INCLUDE?
>
> Signed-off-by: Ross Burton <ross.burton@arm.com>
> ---
> meta-poky/conf/distro/poky-tiny.conf | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta-poky/conf/distro/poky-tiny.conf b/meta-poky/conf/distro/poky-tiny.conf
> index 32c2ec3e1fa..24bcbee9bb6 100644
> --- a/meta-poky/conf/distro/poky-tiny.conf
> +++ b/meta-poky/conf/distro/poky-tiny.conf
> @@ -125,4 +125,4 @@ PACKAGECONFIG:remove:pn-opkg-utils = "python"
>
> # If shadow-base is brought into the image, logins will fail because it
> # doesn't have the heuristics to work when CONFIG_MULTIUSER is unset.
> -PACKAGE_EXCLUDE:poky-tiny = "shadow-base"
> +PACKAGE_EXCLUDE += "shadow-base"
Does yocto-check-layer still pass?
Cheers,
Richard
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [OE-core] [PATCH][master] poky-tiny: fix PACKAGE_EXCLUDE
2023-11-06 10:44 ` [OE-core] " Richard Purdie
@ 2023-11-06 10:55 ` Ross Burton
2023-11-06 11:05 ` Richard Purdie
0 siblings, 1 reply; 4+ messages in thread
From: Ross Burton @ 2023-11-06 10:55 UTC (permalink / raw)
To: Richard Purdie; +Cc: OE Core mailing list
On 6 Nov 2023, at 10:44, Richard Purdie <richard.purdie@linuxfoundation.org> wrote:
>
> On Mon, 2023-11-06 at 10:35 +0000, Ross Burton wrote:
>> From: Ross Burton <ross.burton@arm.com>
>>
>> poky-tiny does a PACKAGE_EXCLUDE on shadow-base as the kernel doesn't
>> support multiple users. However it does this by assigning to an
>> override, which makes it impossible for images or machines to extend
>> PACKAGE_INCLUDE with their own exclusions.
>
> PACKAGE_INCLUDE?
More coffee needed. V2 incoming.
>> # If shadow-base is brought into the image, logins will fail because it
>> # doesn't have the heuristics to work when CONFIG_MULTIUSER is unset.
>> -PACKAGE_EXCLUDE:poky-tiny = "shadow-base"
>> +PACKAGE_EXCLUDE += "shadow-base"
>
> Does yocto-check-layer still pass?
This is in the distro configuration so it still does nothing when not included, but:
INFO: meta-poky … PASS
Ross
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [OE-core] [PATCH][master] poky-tiny: fix PACKAGE_EXCLUDE
2023-11-06 10:55 ` Ross Burton
@ 2023-11-06 11:05 ` Richard Purdie
0 siblings, 0 replies; 4+ messages in thread
From: Richard Purdie @ 2023-11-06 11:05 UTC (permalink / raw)
To: Ross Burton; +Cc: OE Core mailing list
On Mon, 2023-11-06 at 10:55 +0000, Ross Burton wrote:
> On 6 Nov 2023, at 10:44, Richard Purdie <richard.purdie@linuxfoundation.org> wrote:
> >
> > On Mon, 2023-11-06 at 10:35 +0000, Ross Burton wrote:
> > > From: Ross Burton <ross.burton@arm.com>
> > >
> > > poky-tiny does a PACKAGE_EXCLUDE on shadow-base as the kernel doesn't
> > > support multiple users. However it does this by assigning to an
> > > override, which makes it impossible for images or machines to extend
> > > PACKAGE_INCLUDE with their own exclusions.
> >
> > PACKAGE_INCLUDE?
>
> More coffee needed. V2 incoming.
>
> > > # If shadow-base is brought into the image, logins will fail because it
> > > # doesn't have the heuristics to work when CONFIG_MULTIUSER is unset.
> > > -PACKAGE_EXCLUDE:poky-tiny = "shadow-base"
> > > +PACKAGE_EXCLUDE += "shadow-base"
> >
> > Does yocto-check-layer still pass?
>
> This is in the distro configuration so it still does nothing when not included, but:
>
> INFO: meta-poky … PASS
Of course, that was the detail I was overlooking, thanks :)
Cheers,
Richard
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-11-06 11:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-06 10:35 [PATCH][master] poky-tiny: fix PACKAGE_EXCLUDE ross.burton
2023-11-06 10:44 ` [OE-core] " Richard Purdie
2023-11-06 10:55 ` Ross Burton
2023-11-06 11:05 ` Richard Purdie
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.