From: Klaus Heinrich Kiwi <klausk@br.ibm.com>
To: linux-audit@redhat.com
Subject: Re: [PATCH] Make IPC mode consistent
Date: Mon, 16 Jul 2007 16:11:29 -0300 [thread overview]
Message-ID: <f7gft1$9oa$1@sea.gmane.org> (raw)
In-Reply-To: 200705291039.45328.sgrubb@redhat.com
Steve,
Steve Grubb wrote:
> Hi,
>
> The mode fields for IPC records are not consistent. Some are hex, others
> are octal. This patch makes them all octal.
>
> Signed-off-by: Steve Grubb <sgrubb@redhat.com>
Did this patch got through? There is a Novell BZ (#280257 - unfortunatelly
not public at this time) waiting for this to get upstream.
Thanks,
Klaus
>
> diff -urp linux-2.6.18.i686.orig/kernel/auditsc.c
> linux-2.6.18.i686/kernel/auditsc.c
> --- linux-2.6.18.i686.orig/kernel/auditsc.c 2007-05-29 10:27:13.000000000
> -0400
> +++ linux-2.6.18.i686/kernel/auditsc.c 2007-05-29 10:33:07.000000000 -0400
> @@ -941,7 +941,7 @@ static void audit_log_exit(struct audit_
> case AUDIT_IPC: {
> struct audit_aux_data_ipcctl *axi = (void *)aux;
> audit_log_format(ab,
> - "ouid=%u ogid=%u mode=%x",
> + "ouid=%u ogid=%u mode=%#o",
> axi->uid, axi->gid, axi->mode);
> if (axi->osid != 0) {
> char *ctx = NULL;
> @@ -960,7 +960,7 @@ static void audit_log_exit(struct audit_
> case AUDIT_IPC_SET_PERM: {
> struct audit_aux_data_ipcctl *axi = (void *)aux;
> audit_log_format(ab,
> - "qbytes=%lx ouid=%u ogid=%u mode=%x",
> + "qbytes=%lx ouid=%u ogid=%u mode=%#o",
> axi->qbytes, axi->uid, axi->gid, axi->mode);
> break; }
--
.:klaus h kiwi <klausk@br.ibm.com>:.
prev parent reply other threads:[~2007-07-17 17:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-29 14:39 [PATCH] Make IPC mode consistent Steve Grubb
2007-07-16 19:11 ` Klaus Heinrich Kiwi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='f7gft1$9oa$1@sea.gmane.org' \
--to=klausk@br.ibm.com \
--cc=linux-audit@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.