All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: intel-gfx@lists.freedesktop.org
Cc: Ben Widawsky <ben@bwidawsk.net>
Subject: Re: [PATCH 2/3] drm/i915: make eb structure do more
Date: Tue, 11 Oct 2011 20:11:56 +0100	[thread overview]
Message-ID: <f80fcd$253ol8@fmsmga001.fm.intel.com> (raw)
In-Reply-To: <1318357916-12661-3-git-send-email-ben@bwidawsk.net>

On Tue, 11 Oct 2011 11:31:55 -0700, Ben Widawsky <ben@bwidawsk.net> wrote:
> clean up some code using the existing eb structure.
> 
> There is a tiny hunk here related to setting eb->cliprects which is not
> really useful yet, but will be in the future.

You're scaring me! In the current incarnation there is no way cliprects
can be used successfully as it interferes with the 3D setup that the
batch believes itself to be in full control over...

Is there something fun in the pipeline? ;-)

> Signed-off-by: Ben Widawsky <ben@bwidawsk.net>

Other than the obnoxious cliprects,
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre

  reply	other threads:[~2011-10-11 19:11 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-11 18:31 [PATCH 0/3] execbuf cleanups Ben Widawsky
2011-10-11 18:31 ` [PATCH 1/3] drm/i915: extract constant offset setting Ben Widawsky
2011-10-11 19:09   ` Chris Wilson
2011-10-11 18:31 ` [PATCH 2/3] drm/i915: make eb structure do more Ben Widawsky
2011-10-11 19:11   ` Chris Wilson [this message]
2011-10-11 18:31 ` [PATCH 3/3] drm/i915: Force sync command ordering Ben Widawsky
2011-10-11 18:44   ` Ben Widawsky
2011-10-11 19:16   ` Chris Wilson
2011-10-11 19:18   ` Kenneth Graunke
2011-10-11 19:30     ` Ben Widawsky
2011-10-11 19:33       ` Ben Widawsky
2011-10-11 19:42         ` Chris Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='f80fcd$253ol8@fmsmga001.fm.intel.com' \
    --to=chris@chris-wilson.co.uk \
    --cc=ben@bwidawsk.net \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.