* [PATCH] drm/i915: disable temporal dithering on the internal panel
@ 2011-10-11 15:27 Daniel Vetter
2011-10-11 16:02 ` Adam Jackson
0 siblings, 1 reply; 5+ messages in thread
From: Daniel Vetter @ 2011-10-11 15:27 UTC (permalink / raw)
To: intel-gfx; +Cc: Daniel Vetter
<ajax> i'm getting tempted to just disable temporal
<mjg59> Approved.
<ajax> apparently it makes the screen look pulse-y which is worse
than the disease.
References: http://lists.freedesktop.org/archives/intel-gfx/2011-October/012545.html
Tested-by: Олег Герман <oleg.german@gmail.com>
Cc: Adam Jackson <ajax@redhat.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---
drivers/gpu/drm/i915/intel_display.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index f0e5f9f..6fa1e12 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -5533,7 +5533,7 @@ static int ironlake_crtc_mode_set(struct drm_crtc *crtc,
pipeconf &= ~PIPECONF_DITHER_TYPE_MASK;
if ((is_lvds && dev_priv->lvds_dither) || dither) {
pipeconf |= PIPECONF_DITHER_EN;
- pipeconf |= PIPECONF_DITHER_TYPE_ST1;
+ pipeconf |= PIPECONF_DITHER_TYPE_SP;
}
if (is_dp || intel_encoder_is_pch_edp(&has_edp_encoder->base)) {
intel_dp_set_m_n(crtc, mode, adjusted_mode);
--
1.7.6.3
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] drm/i915: disable temporal dithering on the internal panel
2011-10-11 15:27 [PATCH] drm/i915: disable temporal dithering on the internal panel Daniel Vetter
@ 2011-10-11 16:02 ` Adam Jackson
2011-10-11 19:24 ` Chris Wilson
2011-10-23 10:03 ` Daniel Vetter
0 siblings, 2 replies; 5+ messages in thread
From: Adam Jackson @ 2011-10-11 16:02 UTC (permalink / raw)
To: Daniel Vetter; +Cc: intel-gfx
On 10/11/11 11:27 AM, Daniel Vetter wrote:
> <ajax> i'm getting tempted to just disable temporal
> <mjg59> Approved.
> <ajax> apparently it makes the screen look pulse-y which is worse
> than the disease.
>
> References: http://lists.freedesktop.org/archives/intel-gfx/2011-October/012545.html
> Tested-by: Олег Герман<oleg.german@gmail.com>
> Cc: Adam Jackson<ajax@redhat.com>
> Signed-off-by: Daniel Vetter<daniel.vetter@ffwll.ch>
I was going to call you out for not also removing it from the GM45 DP
path, but apparently it's no longer there anyway.
Might be worth wiring this up as an output property someday.
Reviewed-by: Adam Jackson <ajax@redhat.com>
- ajax
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915: disable temporal dithering on the internal panel
2011-10-11 16:02 ` Adam Jackson
@ 2011-10-11 19:24 ` Chris Wilson
2011-10-23 10:03 ` Daniel Vetter
1 sibling, 0 replies; 5+ messages in thread
From: Chris Wilson @ 2011-10-11 19:24 UTC (permalink / raw)
To: Adam Jackson, Daniel Vetter; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 855 bytes --]
On Tue, 11 Oct 2011 12:02:58 -0400, Adam Jackson <ajax@redhat.com> wrote:
> On 10/11/11 11:27 AM, Daniel Vetter wrote:
> > <ajax> i'm getting tempted to just disable temporal
> > <mjg59> Approved.
> > <ajax> apparently it makes the screen look pulse-y which is worse
> > than the disease.
> >
> > References: http://lists.freedesktop.org/archives/intel-gfx/2011-October/012545.html
> > Tested-by: Олег Герман<oleg.german@gmail.com>
> > Cc: Adam Jackson<ajax@redhat.com>
> > Signed-off-by: Daniel Vetter<daniel.vetter@ffwll.ch>
>
> I was going to call you out for not also removing it from the GM45 DP
> path, but apparently it's no longer there anyway.
>
> Might be worth wiring this up as an output property someday.
Good idea, Daniel can you include a hint for a rainy day?
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915: disable temporal dithering on the internal panel
2011-10-11 16:02 ` Adam Jackson
2011-10-11 19:24 ` Chris Wilson
@ 2011-10-23 10:03 ` Daniel Vetter
2011-10-23 19:18 ` Keith Packard
1 sibling, 1 reply; 5+ messages in thread
From: Daniel Vetter @ 2011-10-23 10:03 UTC (permalink / raw)
To: keithp; +Cc: Daniel Vetter, intel-gfx
Hi Keith,
This patch hasn't shown up in your -next pull request. Please consider
merging for 3.2.
Yours, Daniel
On Tue, Oct 11, 2011 at 12:02:58PM -0400, Adam Jackson wrote:
> On 10/11/11 11:27 AM, Daniel Vetter wrote:
> ><ajax> i'm getting tempted to just disable temporal
> ><mjg59> Approved.
> ><ajax> apparently it makes the screen look pulse-y which is worse
> >than the disease.
> >
> >References: http://lists.freedesktop.org/archives/intel-gfx/2011-October/012545.html
> >Tested-by: Олег Герман<oleg.german@gmail.com>
> >Cc: Adam Jackson<ajax@redhat.com>
> >Signed-off-by: Daniel Vetter<daniel.vetter@ffwll.ch>
>
> I was going to call you out for not also removing it from the GM45
> DP path, but apparently it's no longer there anyway.
>
> Might be worth wiring this up as an output property someday.
>
> Reviewed-by: Adam Jackson <ajax@redhat.com>
>
> - ajax
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-10-23 19:18 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-11 15:27 [PATCH] drm/i915: disable temporal dithering on the internal panel Daniel Vetter
2011-10-11 16:02 ` Adam Jackson
2011-10-11 19:24 ` Chris Wilson
2011-10-23 10:03 ` Daniel Vetter
2011-10-23 19:18 ` Keith Packard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.