All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: Jean Delvare <khali@linux-fr.org>, Dave Airlie <airlied@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Florian Mickler <florian@mickler.org>,
	luto@mit.edu, markotahal@gmail.com,
	dri-devel@lists.freedesktop.org
Subject: Re: Revert "drm/i915: Enable GMBUS for post-gen2 chipsets"
Date: Thu, 16 Jun 2011 21:21:01 +0100	[thread overview]
Message-ID: <f80fcd$i79q3@fmsmga001.fm.intel.com> (raw)
In-Reply-To: <20110616221107.045a142d@endymion.delvare>

On Thu, 16 Jun 2011 22:11:07 +0200, Jean Delvare <khali@linux-fr.org> wrote:
> Hi Dave,
> 
> On Tue, 14 Jun 2011 13:39:35 +1000, Dave Airlie wrote:
> > Chris, also I don't see an ack anywhere on the list, only some
> > discussion in the bug,
> 
> I would indeed love to get a ack from Chris.

Sure, let me ack it again. Hmm, was the last ack on linux-kernel, not
dri-devel?
 
> > I suspect the correct fix is to remove all the offending code instead
> > of just putting back the piece
> > of plaster that fell out of the wall.
> 
> Which "offending code" are you talking about?

Dave and myself chatted on irc and hopefully we cleared up the confusion
that this patch is indeed just restoring the code to 2.6.39. And that
further works needs to be done before trying GMBUS again.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre

  reply	other threads:[~2011-06-16 20:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-04 19:34 [PATCH] Revert "drm/i915: Enable GMBUS for post-gen2 chipsets" Jean Delvare
2011-06-11 11:28 ` Florian Mickler
2011-06-11 12:58   ` Jean Delvare
2011-06-14  3:39     ` Dave Airlie
2011-06-16 20:11       ` Jean Delvare
2011-06-16 20:21         ` Chris Wilson [this message]
2011-06-16 20:21         ` Dave Airlie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='f80fcd$i79q3@fmsmga001.fm.intel.com' \
    --to=chris@chris-wilson.co.uk \
    --cc=airlied@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=florian@mickler.org \
    --cc=khali@linux-fr.org \
    --cc=luto@mit.edu \
    --cc=markotahal@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.