* [PATCH v2 2/4] arm64: dts: qcom: sc7280: add display dt nodes
2021-10-20 13:58 [PATCH v2 1/4] dt-bindings: msm: add DT bindings for sc7280 Krishna Manikandan
@ 2021-10-20 13:58 ` Krishna Manikandan
2021-10-20 20:30 ` kernel test robot
` (2 more replies)
2021-10-20 13:58 ` [PATCH v2 3/4] arm64: dts: qcom: sc7280: Add DSI display nodes Krishna Manikandan
` (2 subsequent siblings)
3 siblings, 3 replies; 13+ messages in thread
From: Krishna Manikandan @ 2021-10-20 13:58 UTC (permalink / raw)
To: linux-arm-msm, devicetree, linux-kernel
Cc: Krishna Manikandan, kalyan_t, sbillaka, abhinavk, robdclark,
swboyd, bjorn.andersson, khsieh, rajeevny, freedreno, dri-devel,
robh+dt
Add mdss and mdp DT nodes for sc7280.
Signed-off-by: Krishna Manikandan <quic_mkrishn@quicinc.com>
Changes in v2:
- Rename display dt nodes (Stephen Boyd)
- Add clock names one per line for readability (Stephen Boyd)
---
arch/arm64/boot/dts/qcom/sc7280.dtsi | 90 ++++++++++++++++++++++++++++++++++++
1 file changed, 90 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
index d74a4c8..4ee7f2f 100644
--- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
@@ -2588,6 +2588,96 @@
#power-domain-cells = <1>;
};
+ mdss: display-subsystem@ae00000 {
+ compatible = "qcom,sc7280-mdss";
+ reg = <0 0x0ae00000 0 0x1000>;
+ reg-names = "mdss";
+
+ power-domains = <&dispcc DISP_CC_MDSS_CORE_GDSC>;
+
+ clocks = <&gcc GCC_DISP_AHB_CLK>,
+ <&dispcc DISP_CC_MDSS_AHB_CLK>,
+ <&dispcc DISP_CC_MDSS_MDP_CLK>;
+ clock-names = "iface",
+ "ahb",
+ "core";
+
+ assigned-clocks = <&dispcc DISP_CC_MDSS_MDP_CLK>;
+ assigned-clock-rates = <300000000>;
+
+ interrupts = <GIC_SPI 83 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-controller;
+ #interrupt-cells = <1>;
+
+ interconnects = <&mmss_noc MASTER_MDP0 0 &mc_virt SLAVE_EBI1 0>;
+ interconnect-names = "mdp0-mem";
+
+ iommus = <&apps_smmu 0x900 0x402>;
+
+ #address-cells = <2>;
+ #size-cells = <2>;
+ ranges;
+
+ status = "disabled";
+
+ mdp: display-controller@ae01000 {
+ compatible = "qcom,sc7280-dpu";
+ reg = <0 0x0ae01000 0 0x8f030>,
+ <0 0x0aeb0000 0 0x2008>;
+ reg-names = "mdp", "vbif";
+
+ clocks = <&gcc GCC_DISP_HF_AXI_CLK>,
+ <&gcc GCC_DISP_SF_AXI_CLK>,
+ <&dispcc DISP_CC_MDSS_AHB_CLK>,
+ <&dispcc DISP_CC_MDSS_MDP_LUT_CLK>,
+ <&dispcc DISP_CC_MDSS_MDP_CLK>,
+ <&dispcc DISP_CC_MDSS_VSYNC_CLK>;
+ clock-names = "bus",
+ "nrt_bus",
+ "iface",
+ "lut",
+ "core",
+ "vsync";
+ assigned-clocks = <&dispcc DISP_CC_MDSS_MDP_CLK>,
+ <&dispcc DISP_CC_MDSS_VSYNC_CLK>,
+ <&dispcc DISP_CC_MDSS_AHB_CLK>;
+ assigned-clock-rates = <300000000>,
+ <19200000>,
+ <19200000>;
+ operating-points-v2 = <&mdp_opp_table>;
+ power-domains = <&rpmhpd SC7280_CX>;
+
+ interrupt-parent = <&mdss>;
+ interrupts = <0>;
+
+ status = "disabled";
+
+ mdp_opp_table: opp-table {
+ compatible = "operating-points-v2";
+
+ opp-200000000 {
+ opp-hz = /bits/ 64 <200000000>;
+ required-opps = <&rpmhpd_opp_low_svs>;
+ };
+
+ opp-300000000 {
+ opp-hz = /bits/ 64 <300000000>;
+ required-opps = <&rpmhpd_opp_svs>;
+ };
+
+ opp-380000000 {
+ opp-hz = /bits/ 64 <380000000>;
+ required-opps = <&rpmhpd_opp_svs_l1>;
+ };
+
+ opp-506666667 {
+ opp-hz = /bits/ 64 <506666667>;
+ required-opps = <&rpmhpd_opp_nom>;
+ };
+ };
+ };
+ };
+
pdc: interrupt-controller@b220000 {
compatible = "qcom,sc7280-pdc", "qcom,pdc";
reg = <0 0x0b220000 0 0x30000>;
--
2.7.4
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [PATCH v2 2/4] arm64: dts: qcom: sc7280: add display dt nodes
2021-10-20 13:58 ` [PATCH v2 2/4] arm64: dts: qcom: sc7280: add display dt nodes Krishna Manikandan
@ 2021-10-20 20:30 ` kernel test robot
2021-10-21 18:40 ` Stephen Boyd
2021-10-26 5:12 ` kernel test robot
2 siblings, 0 replies; 13+ messages in thread
From: kernel test robot @ 2021-10-20 20:30 UTC (permalink / raw)
To: Krishna Manikandan, linux-arm-msm, devicetree, linux-kernel
Cc: llvm, kbuild-all, Krishna Manikandan, kalyan_t, sbillaka,
abhinavk, robdclark, swboyd, bjorn.andersson
[-- Attachment #1: Type: text/plain, Size: 1886 bytes --]
Hi Krishna,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on robh/for-next]
[also build test ERROR on v5.15-rc6]
[cannot apply to next-20211020]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Krishna-Manikandan/dt-bindings-msm-add-DT-bindings-for-sc7280/20211020-220027
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: arm64-randconfig-r002-20211019 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 9660563950aaed54020bfdf0be07e7096a9553e4)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# https://github.com/0day-ci/linux/commit/694d3e3e8c78ce1e155292d82e2f0c23899cfed3
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Krishna-Manikandan/dt-bindings-msm-add-DT-bindings-for-sc7280/20211020-220027
git checkout 694d3e3e8c78ce1e155292d82e2f0c23899cfed3
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> Error: arch/arm64/boot/dts/qcom/sc7280.dtsi:1432.29-30 syntax error
FATAL ERROR: Unable to parse input tree
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 26907 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH v2 2/4] arm64: dts: qcom: sc7280: add display dt nodes
2021-10-20 13:58 ` [PATCH v2 2/4] arm64: dts: qcom: sc7280: add display dt nodes Krishna Manikandan
2021-10-20 20:30 ` kernel test robot
@ 2021-10-21 18:40 ` Stephen Boyd
2021-10-26 5:12 ` kernel test robot
2 siblings, 0 replies; 13+ messages in thread
From: Stephen Boyd @ 2021-10-21 18:40 UTC (permalink / raw)
To: Krishna Manikandan, devicetree, linux-arm-msm, linux-kernel
Cc: kalyan_t, sbillaka, abhinavk, robdclark, bjorn.andersson, khsieh,
rajeevny, freedreno, dri-devel, robh+dt
Quoting Krishna Manikandan (2021-10-20 06:58:51)
> Add mdss and mdp DT nodes for sc7280.
>
> Signed-off-by: Krishna Manikandan <quic_mkrishn@quicinc.com>
>
> Changes in v2:
> - Rename display dt nodes (Stephen Boyd)
> - Add clock names one per line for readability (Stephen Boyd)
> ---
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2 2/4] arm64: dts: qcom: sc7280: add display dt nodes
2021-10-20 13:58 ` [PATCH v2 2/4] arm64: dts: qcom: sc7280: add display dt nodes Krishna Manikandan
@ 2021-10-26 5:12 ` kernel test robot
2021-10-21 18:40 ` Stephen Boyd
2021-10-26 5:12 ` kernel test robot
2 siblings, 0 replies; 13+ messages in thread
From: kernel test robot @ 2021-10-26 5:12 UTC (permalink / raw)
To: Krishna Manikandan, linux-arm-msm, devicetree, linux-kernel
Cc: kbuild-all, Krishna Manikandan, kalyan_t, sbillaka, abhinavk,
robdclark, swboyd, bjorn.andersson
[-- Attachment #1: Type: text/plain, Size: 1703 bytes --]
Hi Krishna,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on robh/for-next]
[also build test ERROR on v5.15-rc7]
[cannot apply to next-20211025]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Krishna-Manikandan/dt-bindings-msm-add-DT-bindings-for-sc7280/20211020-220027
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: arm64-randconfig-r023-20211019 (attached as .config)
compiler: aarch64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/694d3e3e8c78ce1e155292d82e2f0c23899cfed3
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Krishna-Manikandan/dt-bindings-msm-add-DT-bindings-for-sc7280/20211020-220027
git checkout 694d3e3e8c78ce1e155292d82e2f0c23899cfed3
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> Error: arch/arm64/boot/dts/qcom/sc7280.dtsi:1432.29-30 syntax error
FATAL ERROR: Unable to parse input tree
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 40040 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH v2 3/4] arm64: dts: qcom: sc7280: Add DSI display nodes
2021-10-20 13:58 [PATCH v2 1/4] dt-bindings: msm: add DT bindings for sc7280 Krishna Manikandan
2021-10-20 13:58 ` [PATCH v2 2/4] arm64: dts: qcom: sc7280: add display dt nodes Krishna Manikandan
@ 2021-10-20 13:58 ` Krishna Manikandan
2021-10-21 18:45 ` Stephen Boyd
2021-10-20 13:58 ` [PATCH v2 4/4] arm64: dts: qcom: sc7280: add edp display dt nodes Krishna Manikandan
2021-10-21 18:37 ` [PATCH v2 1/4] dt-bindings: msm: add DT bindings for sc7280 Stephen Boyd
3 siblings, 1 reply; 13+ messages in thread
From: Krishna Manikandan @ 2021-10-20 13:58 UTC (permalink / raw)
To: linux-arm-msm, devicetree, linux-kernel
Cc: Krishna Manikandan, kalyan_t, sbillaka, abhinavk, robdclark,
swboyd, bjorn.andersson, khsieh, rajeevny, freedreno, dri-devel,
robh+dt, Rajeev Nandan
Add DSI controller and PHY nodes for sc7280.
Signed-off-by: Rajeev Nandan <quic_rajeevny@quicinc.com>
Signed-off-by: Krishna Manikandan <quic_mkrishn@quicinc.com>
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
Changes in v2:
- Drop flags from interrupts (Stephen Boyd)
- Rename dsi-opp-table (Stephen Boyd)
- Rename dsi phy node (Stephen Boyd)
---
arch/arm64/boot/dts/qcom/sc7280.dtsi | 101 +++++++++++++++++++++++++++++++++++
1 file changed, 101 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
index 4ee7f2f..dd35882 100644
--- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
@@ -2652,6 +2652,18 @@
status = "disabled";
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+ dpu_intf1_out: endpoint {
+ remote-endpoint = <&dsi0_in>;
+ };
+ };
+ };
+
mdp_opp_table: opp-table {
compatible = "operating-points-v2";
@@ -2676,6 +2688,95 @@
};
};
};
+
+ dsi0: dsi@ae94000 {
+ compatible = "qcom,mdss-dsi-ctrl";
+ reg = <0 0x0ae94000 0 0x400>;
+ reg-names = "dsi_ctrl";
+
+ interrupt-parent = <&mdss>;
+ interrupts = <4>;
+
+ clocks = <&dispcc DISP_CC_MDSS_BYTE0_CLK>,
+ <&dispcc DISP_CC_MDSS_BYTE0_INTF_CLK>,
+ <&dispcc DISP_CC_MDSS_PCLK0_CLK>,
+ <&dispcc DISP_CC_MDSS_ESC0_CLK>,
+ <&dispcc DISP_CC_MDSS_AHB_CLK>,
+ <&gcc GCC_DISP_HF_AXI_CLK>;
+ clock-names = "byte",
+ "byte_intf",
+ "pixel",
+ "core",
+ "iface",
+ "bus";
+
+ operating-points-v2 = <&dsi_opp_table>;
+ power-domains = <&rpmhpd SC7280_CX>;
+
+ phys = <&dsi_phy>;
+ phy-names = "dsi";
+
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ status = "disabled";
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+ dsi0_in: endpoint {
+ remote-endpoint = <&dpu_intf1_out>;
+ };
+ };
+
+ port@1 {
+ reg = <1>;
+ dsi0_out: endpoint {
+ };
+ };
+ };
+
+ dsi_opp_table: opp-table {
+ compatible = "operating-points-v2";
+
+ opp-187500000 {
+ opp-hz = /bits/ 64 <187500000>;
+ required-opps = <&rpmhpd_opp_low_svs>;
+ };
+
+ opp-300000000 {
+ opp-hz = /bits/ 64 <300000000>;
+ required-opps = <&rpmhpd_opp_svs>;
+ };
+
+ opp-358000000 {
+ opp-hz = /bits/ 64 <358000000>;
+ required-opps = <&rpmhpd_opp_svs_l1>;
+ };
+ };
+ };
+
+ dsi_phy: phy@ae94400 {
+ compatible = "qcom,sc7280-dsi-phy-7nm";
+ reg = <0 0x0ae94400 0 0x200>,
+ <0 0x0ae94600 0 0x280>,
+ <0 0x0ae94900 0 0x280>;
+ reg-names = "dsi_phy",
+ "dsi_phy_lane",
+ "dsi_pll";
+
+ #clock-cells = <1>;
+ #phy-cells = <0>;
+
+ clocks = <&dispcc DISP_CC_MDSS_AHB_CLK>,
+ <&rpmhcc RPMH_CXO_CLK>;
+ clock-names = "iface", "ref";
+
+ status = "disabled";
+ };
};
pdc: interrupt-controller@b220000 {
--
2.7.4
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [PATCH v2 3/4] arm64: dts: qcom: sc7280: Add DSI display nodes
2021-10-20 13:58 ` [PATCH v2 3/4] arm64: dts: qcom: sc7280: Add DSI display nodes Krishna Manikandan
@ 2021-10-21 18:45 ` Stephen Boyd
0 siblings, 0 replies; 13+ messages in thread
From: Stephen Boyd @ 2021-10-21 18:45 UTC (permalink / raw)
To: Krishna Manikandan, devicetree, linux-arm-msm, linux-kernel
Cc: kalyan_t, sbillaka, abhinavk, robdclark, bjorn.andersson, khsieh,
rajeevny, freedreno, dri-devel, robh+dt, Rajeev Nandan
Quoting Krishna Manikandan (2021-10-20 06:58:52)
> Add DSI controller and PHY nodes for sc7280.
>
> Signed-off-by: Rajeev Nandan <quic_rajeevny@quicinc.com>
> Signed-off-by: Krishna Manikandan <quic_mkrishn@quicinc.com>
> Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
>
> Changes in v2:
> - Drop flags from interrupts (Stephen Boyd)
> - Rename dsi-opp-table (Stephen Boyd)
> - Rename dsi phy node (Stephen Boyd)
> ---
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH v2 4/4] arm64: dts: qcom: sc7280: add edp display dt nodes
2021-10-20 13:58 [PATCH v2 1/4] dt-bindings: msm: add DT bindings for sc7280 Krishna Manikandan
2021-10-20 13:58 ` [PATCH v2 2/4] arm64: dts: qcom: sc7280: add display dt nodes Krishna Manikandan
2021-10-20 13:58 ` [PATCH v2 3/4] arm64: dts: qcom: sc7280: Add DSI display nodes Krishna Manikandan
@ 2021-10-20 13:58 ` Krishna Manikandan
2021-10-21 18:44 ` Stephen Boyd
2021-10-21 18:37 ` [PATCH v2 1/4] dt-bindings: msm: add DT bindings for sc7280 Stephen Boyd
3 siblings, 1 reply; 13+ messages in thread
From: Krishna Manikandan @ 2021-10-20 13:58 UTC (permalink / raw)
To: linux-arm-msm, devicetree, linux-kernel
Cc: Sankeerth Billakanti, kalyan_t, sbillaka, abhinavk, robdclark,
swboyd, bjorn.andersson, khsieh, rajeevny, freedreno, dri-devel,
robh+dt, Krishna Manikandan
From: Sankeerth Billakanti <quic_sbillaka@quicinc.com>
Add edp controller and phy DT nodes for sc7280.
Signed-off-by: Sankeerth Billakanti <quic_sbillaka@quicinc.com>
Signed-off-by: Krishna Manikandan <quic_mkrishn@quicinc.com>
Changes in v2:
- Move regulator definitions to board file (Matthias Kaehlcke)
- Move the gpio definitions to board file (Matthias Kaehlcke)
- Move the pinconf to board file (Matthias Kaehlcke)
- Move status property (Stephen Boyd)
- Drop flags from interrupts (Stephen Boyd)
- Add clock names one per line for readability (Stephen Boyd)
- Rename edp-opp-table (Stephen Boyd)
---
arch/arm64/boot/dts/qcom/sc7280.dtsi | 107 ++++++++++++++++++++++++++++++++++-
1 file changed, 106 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
index dd35882..4450277 100644
--- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
@@ -2575,7 +2575,7 @@
reg = <0 0xaf00000 0 0x20000>;
clocks = <&rpmhcc RPMH_CXO_CLK>,
<&gcc GCC_DISP_GPLL0_CLK_SRC>,
- <0>, <0>, <0>, <0>, <0>, <0>;
+ <0>, <0>, <0>, <0>, <&edp_phy 0>, <&edp_phy 1>;
clock-names = "bi_tcxo", "gcc_disp_gpll0_clk",
"dsi0_phy_pll_out_byteclk",
"dsi0_phy_pll_out_dsiclk",
@@ -2662,6 +2662,13 @@
remote-endpoint = <&dsi0_in>;
};
};
+
+ port@1 {
+ reg = <1>;
+ dpu_intf5_out: endpoint {
+ remote-endpoint = <&edp_in>;
+ };
+ };
};
mdp_opp_table: opp-table {
@@ -2777,6 +2784,103 @@
status = "disabled";
};
+
+ msm_edp: edp@aea0000 {
+ compatible = "qcom,sc7280-edp";
+
+ reg = <0 0xaea0000 0 0x200>,
+ <0 0xaea0200 0 0x200>,
+ <0 0xaea0400 0 0xc00>,
+ <0 0xaea1000 0 0x400>;
+
+ interrupt-parent = <&mdss>;
+ interrupts = <14>;
+
+ clocks = <&rpmhcc RPMH_CXO_CLK>,
+ <&gcc GCC_EDP_CLKREF_EN>,
+ <&dispcc DISP_CC_MDSS_AHB_CLK>,
+ <&dispcc DISP_CC_MDSS_EDP_AUX_CLK>,
+ <&dispcc DISP_CC_MDSS_EDP_LINK_CLK>,
+ <&dispcc DISP_CC_MDSS_EDP_LINK_INTF_CLK>,
+ <&dispcc DISP_CC_MDSS_EDP_PIXEL_CLK>;
+ clock-names = "core_xo",
+ "core_ref",
+ "core_iface",
+ "core_aux",
+ "ctrl_link",
+ "ctrl_link_iface",
+ "stream_pixel";
+ #clock-cells = <1>;
+ assigned-clocks = <&dispcc DISP_CC_MDSS_EDP_LINK_CLK_SRC>,
+ <&dispcc DISP_CC_MDSS_EDP_PIXEL_CLK_SRC>;
+ assigned-clock-parents = <&edp_phy 0>, <&edp_phy 1>;
+
+ phys = <&edp_phy>;
+ phy-names = "dp";
+
+ operating-points-v2 = <&edp_opp_table>;
+ power-domains = <&rpmhpd SC7280_CX>;
+
+
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ status = "disabled";
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ port@0 {
+ reg = <0>;
+ edp_in: endpoint {
+ remote-endpoint = <&dpu_intf5_out>;
+ };
+ };
+ };
+
+ edp_opp_table: opp-table {
+ compatible = "operating-points-v2";
+
+ opp-160000000 {
+ opp-hz = /bits/ 64 <160000000>;
+ required-opps = <&rpmhpd_opp_low_svs>;
+ };
+
+ opp-270000000 {
+ opp-hz = /bits/ 64 <270000000>;
+ required-opps = <&rpmhpd_opp_svs>;
+ };
+
+ opp-540000000 {
+ opp-hz = /bits/ 64 <540000000>;
+ required-opps = <&rpmhpd_opp_nom>;
+ };
+
+ opp-810000000 {
+ opp-hz = /bits/ 64 <810000000>;
+ required-opps = <&rpmhpd_opp_nom>;
+ };
+ };
+ };
+
+ edp_phy: phy@aec2000 {
+ compatible = "qcom,sc7280-edp-phy";
+
+ reg = <0 0xaec2a00 0 0x19c>,
+ <0 0xaec2200 0 0xa0>,
+ <0 0xaec2600 0 0xa0>,
+ <0 0xaec2000 0 0x1c0>;
+
+ clocks = <&rpmhcc RPMH_CXO_CLK>,
+ <&gcc GCC_EDP_CLKREF_EN>;
+ clock-names = "aux",
+ "cfg_ahb";
+
+ #clock-cells = <1>;
+ #phy-cells = <0>;
+
+ status = "disabled";
+ };
};
pdc: interrupt-controller@b220000 {
@@ -3932,6 +4036,7 @@
<&CPU3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
};
};
+
};
cpu1-thermal {
--
2.7.4
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [PATCH v2 4/4] arm64: dts: qcom: sc7280: add edp display dt nodes
2021-10-20 13:58 ` [PATCH v2 4/4] arm64: dts: qcom: sc7280: add edp display dt nodes Krishna Manikandan
@ 2021-10-21 18:44 ` Stephen Boyd
2021-10-25 21:25 ` khsieh
0 siblings, 1 reply; 13+ messages in thread
From: Stephen Boyd @ 2021-10-21 18:44 UTC (permalink / raw)
To: Krishna Manikandan, devicetree, linux-arm-msm, linux-kernel
Cc: Sankeerth Billakanti, kalyan_t, sbillaka, abhinavk, robdclark,
bjorn.andersson, khsieh, rajeevny, freedreno, dri-devel, robh+dt
Quoting Krishna Manikandan (2021-10-20 06:58:53)
> From: Sankeerth Billakanti <quic_sbillaka@quicinc.com>
>
> Add edp controller and phy DT nodes for sc7280.
>
> Signed-off-by: Sankeerth Billakanti <quic_sbillaka@quicinc.com>
> Signed-off-by: Krishna Manikandan <quic_mkrishn@quicinc.com>
>
Some comments below
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
> Changes in v2:
> - Move regulator definitions to board file (Matthias Kaehlcke)
> - Move the gpio definitions to board file (Matthias Kaehlcke)
> - Move the pinconf to board file (Matthias Kaehlcke)
> - Move status property (Stephen Boyd)
> - Drop flags from interrupts (Stephen Boyd)
> - Add clock names one per line for readability (Stephen Boyd)
> - Rename edp-opp-table (Stephen Boyd)
> ---
> arch/arm64/boot/dts/qcom/sc7280.dtsi | 107 ++++++++++++++++++++++++++++++++++-
> 1 file changed, 106 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> index dd35882..4450277 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> @@ -2575,7 +2575,7 @@
> reg = <0 0xaf00000 0 0x20000>;
> clocks = <&rpmhcc RPMH_CXO_CLK>,
> <&gcc GCC_DISP_GPLL0_CLK_SRC>,
> - <0>, <0>, <0>, <0>, <0>, <0>;
> + <0>, <0>, <0>, <0>, <&edp_phy 0>, <&edp_phy 1>;
I can already tell this is going to be a merge mess! Can this also be
one cell per line?
> clock-names = "bi_tcxo", "gcc_disp_gpll0_clk",
> "dsi0_phy_pll_out_byteclk",
> "dsi0_phy_pll_out_dsiclk",
> @@ -2777,6 +2784,103 @@
>
> status = "disabled";
> };
> +
> + msm_edp: edp@aea0000 {
> + compatible = "qcom,sc7280-edp";
> +
> + reg = <0 0xaea0000 0 0x200>,
> + <0 0xaea0200 0 0x200>,
> + <0 0xaea0400 0 0xc00>,
> + <0 0xaea1000 0 0x400>;
> +
> + interrupt-parent = <&mdss>;
> + interrupts = <14>;
> +
> + clocks = <&rpmhcc RPMH_CXO_CLK>,
> + <&gcc GCC_EDP_CLKREF_EN>,
> + <&dispcc DISP_CC_MDSS_AHB_CLK>,
> + <&dispcc DISP_CC_MDSS_EDP_AUX_CLK>,
> + <&dispcc DISP_CC_MDSS_EDP_LINK_CLK>,
> + <&dispcc DISP_CC_MDSS_EDP_LINK_INTF_CLK>,
> + <&dispcc DISP_CC_MDSS_EDP_PIXEL_CLK>;
> + clock-names = "core_xo",
> + "core_ref",
> + "core_iface",
> + "core_aux",
> + "ctrl_link",
> + "ctrl_link_iface",
> + "stream_pixel";
> + #clock-cells = <1>;
> + assigned-clocks = <&dispcc DISP_CC_MDSS_EDP_LINK_CLK_SRC>,
> + <&dispcc DISP_CC_MDSS_EDP_PIXEL_CLK_SRC>;
> + assigned-clock-parents = <&edp_phy 0>, <&edp_phy 1>;
> +
> + phys = <&edp_phy>;
> + phy-names = "dp";
> +
> + operating-points-v2 = <&edp_opp_table>;
> + power-domains = <&rpmhpd SC7280_CX>;
> +
> +
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + status = "disabled";
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + port@0 {
> + reg = <0>;
> + edp_in: endpoint {
> + remote-endpoint = <&dpu_intf5_out>;
> + };
> + };
> + };
> +
> + edp_opp_table: opp-table {
> + compatible = "operating-points-v2";
> +
> + opp-160000000 {
> + opp-hz = /bits/ 64 <160000000>;
> + required-opps = <&rpmhpd_opp_low_svs>;
> + };
> +
> + opp-270000000 {
> + opp-hz = /bits/ 64 <270000000>;
> + required-opps = <&rpmhpd_opp_svs>;
> + };
> +
> + opp-540000000 {
> + opp-hz = /bits/ 64 <540000000>;
> + required-opps = <&rpmhpd_opp_nom>;
> + };
> +
> + opp-810000000 {
> + opp-hz = /bits/ 64 <810000000>;
> + required-opps = <&rpmhpd_opp_nom>;
> + };
> + };
> + };
> +
> + edp_phy: phy@aec2000 {
unit address needs to match first reg property. This should be
edp_phy: phy@aec2a00
> + compatible = "qcom,sc7280-edp-phy";
> +
> + reg = <0 0xaec2a00 0 0x19c>,
> + <0 0xaec2200 0 0xa0>,
> + <0 0xaec2600 0 0xa0>,
> + <0 0xaec2000 0 0x1c0>;
> +
> + clocks = <&rpmhcc RPMH_CXO_CLK>,
> + <&gcc GCC_EDP_CLKREF_EN>;
> + clock-names = "aux",
> + "cfg_ahb";
> +
> + #clock-cells = <1>;
> + #phy-cells = <0>;
> +
> + status = "disabled";
> + };
> };
>
> pdc: interrupt-controller@b220000 {
> @@ -3932,6 +4036,7 @@
> <&CPU3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
> };
> };
> +
Drop this?
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH v2 4/4] arm64: dts: qcom: sc7280: add edp display dt nodes
2021-10-21 18:44 ` Stephen Boyd
@ 2021-10-25 21:25 ` khsieh
0 siblings, 0 replies; 13+ messages in thread
From: khsieh @ 2021-10-25 21:25 UTC (permalink / raw)
To: Stephen Boyd
Cc: Krishna Manikandan, devicetree, linux-arm-msm, linux-kernel,
Sankeerth Billakanti, kalyan_t, sbillaka, abhinavk, robdclark,
bjorn.andersson, rajeevny, freedreno, dri-devel, robh+dt
On 2021-10-21 11:44, Stephen Boyd wrote:
> Quoting Krishna Manikandan (2021-10-20 06:58:53)
>> From: Sankeerth Billakanti <quic_sbillaka@quicinc.com>
>>
>> Add edp controller and phy DT nodes for sc7280.
>>
>> Signed-off-by: Sankeerth Billakanti <quic_sbillaka@quicinc.com>
>> Signed-off-by: Krishna Manikandan <quic_mkrishn@quicinc.com>
>>
>
> Some comments below
>
> Reviewed-by: Stephen Boyd <swboyd@chromium.org>
>
>
>> Changes in v2:
>> - Move regulator definitions to board file (Matthias Kaehlcke)
>> - Move the gpio definitions to board file (Matthias Kaehlcke)
>> - Move the pinconf to board file (Matthias Kaehlcke)
>> - Move status property (Stephen Boyd)
>> - Drop flags from interrupts (Stephen Boyd)
>> - Add clock names one per line for readability (Stephen Boyd)
>> - Rename edp-opp-table (Stephen Boyd)
>> ---
>> arch/arm64/boot/dts/qcom/sc7280.dtsi | 107
>> ++++++++++++++++++++++++++++++++++-
>> 1 file changed, 106 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> index dd35882..4450277 100644
>> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> @@ -2575,7 +2575,7 @@
>> reg = <0 0xaf00000 0 0x20000>;
>> clocks = <&rpmhcc RPMH_CXO_CLK>,
>> <&gcc GCC_DISP_GPLL0_CLK_SRC>,
>> - <0>, <0>, <0>, <0>, <0>, <0>;
>> + <0>, <0>, <0>, <0>, <&edp_phy 0>,
>> <&edp_phy 1>;
>
> I can already tell this is going to be a merge mess! Can this also be
> one cell per line?
>
where are dsi phy? (<&dsi_phy 0>, <&dsi_phy 1>)
>> clock-names = "bi_tcxo", "gcc_disp_gpll0_clk",
>> "dsi0_phy_pll_out_byteclk",
>> "dsi0_phy_pll_out_dsiclk",
>> @@ -2777,6 +2784,103 @@
>>
>> status = "disabled";
>> };
>> +
>> + msm_edp: edp@aea0000 {
>> + compatible = "qcom,sc7280-edp";
>> +
>> + reg = <0 0xaea0000 0 0x200>,
>> + <0 0xaea0200 0 0x200>,
>> + <0 0xaea0400 0 0xc00>,
>> + <0 0xaea1000 0 0x400>;
>> +
>> + interrupt-parent = <&mdss>;
>> + interrupts = <14>;
>> +
>> + clocks = <&rpmhcc RPMH_CXO_CLK>,
>> + <&gcc GCC_EDP_CLKREF_EN>,
>> + <&dispcc
>> DISP_CC_MDSS_AHB_CLK>,
>> + <&dispcc
>> DISP_CC_MDSS_EDP_AUX_CLK>,
>> + <&dispcc
>> DISP_CC_MDSS_EDP_LINK_CLK>,
>> + <&dispcc
>> DISP_CC_MDSS_EDP_LINK_INTF_CLK>,
>> + <&dispcc
>> DISP_CC_MDSS_EDP_PIXEL_CLK>;
>> + clock-names = "core_xo",
>> + "core_ref",
>> + "core_iface",
>> + "core_aux",
>> + "ctrl_link",
>> + "ctrl_link_iface",
>> + "stream_pixel";
>> + #clock-cells = <1>;
>> + assigned-clocks = <&dispcc
>> DISP_CC_MDSS_EDP_LINK_CLK_SRC>,
>> + <&dispcc
>> DISP_CC_MDSS_EDP_PIXEL_CLK_SRC>;
>> + assigned-clock-parents = <&edp_phy 0>,
>> <&edp_phy 1>;
>> +
>> + phys = <&edp_phy>;
>> + phy-names = "dp";
>> +
>> + operating-points-v2 =
>> <&edp_opp_table>;
>> + power-domains = <&rpmhpd SC7280_CX>;
>> +
>> +
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + status = "disabled";
>> +
>> + ports {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + port@0 {
>> + reg = <0>;
>> + edp_in: endpoint {
>> +
>> remote-endpoint = <&dpu_intf5_out>;
>> + };
>> + };
>> + };
>> +
>> + edp_opp_table: opp-table {
>> + compatible =
>> "operating-points-v2";
>> +
>> + opp-160000000 {
>> + opp-hz = /bits/ 64
>> <160000000>;
>> + required-opps =
>> <&rpmhpd_opp_low_svs>;
>> + };
>> +
>> + opp-270000000 {
>> + opp-hz = /bits/ 64
>> <270000000>;
>> + required-opps =
>> <&rpmhpd_opp_svs>;
>> + };
>> +
>> + opp-540000000 {
>> + opp-hz = /bits/ 64
>> <540000000>;
>> + required-opps =
>> <&rpmhpd_opp_nom>;
>> + };
>> +
>> + opp-810000000 {
>> + opp-hz = /bits/ 64
>> <810000000>;
>> + required-opps =
>> <&rpmhpd_opp_nom>;
>> + };
>> + };
>> + };
>> +
>> + edp_phy: phy@aec2000 {
>
> unit address needs to match first reg property. This should be
>
> edp_phy: phy@aec2a00
>
>> + compatible = "qcom,sc7280-edp-phy";
>> +
>> + reg = <0 0xaec2a00 0 0x19c>,
>> + <0 0xaec2200 0 0xa0>,
>> + <0 0xaec2600 0 0xa0>,
>> + <0 0xaec2000 0 0x1c0>;
>> +
>> + clocks = <&rpmhcc RPMH_CXO_CLK>,
>> + <&gcc GCC_EDP_CLKREF_EN>;
>> + clock-names = "aux",
>> + "cfg_ahb";
>> +
>> + #clock-cells = <1>;
>> + #phy-cells = <0>;
>> +
>> + status = "disabled";
>> + };
>> };
>>
>> pdc: interrupt-controller@b220000 {
>> @@ -3932,6 +4036,7 @@
>> <&CPU3
>> THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
>> };
>> };
>> +
>
> Drop this?
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2 1/4] dt-bindings: msm: add DT bindings for sc7280
2021-10-20 13:58 [PATCH v2 1/4] dt-bindings: msm: add DT bindings for sc7280 Krishna Manikandan
` (2 preceding siblings ...)
2021-10-20 13:58 ` [PATCH v2 4/4] arm64: dts: qcom: sc7280: add edp display dt nodes Krishna Manikandan
@ 2021-10-21 18:37 ` Stephen Boyd
3 siblings, 0 replies; 13+ messages in thread
From: Stephen Boyd @ 2021-10-21 18:37 UTC (permalink / raw)
To: Krishna Manikandan, devicetree, linux-arm-msm, linux-kernel
Cc: kalyan_t, sbillaka, abhinavk, robdclark, bjorn.andersson, khsieh,
rajeevny, freedreno, dri-devel, robh+dt
Quoting Krishna Manikandan (2021-10-20 06:58:50)
> MSM Mobile Display Subsystem (MDSS) encapsulates sub-blocks
> like DPU display controller, DSI, EDP etc. Add required DPU
> device tree bindings for SC7280.
>
> Signed-off-by: Krishna Manikandan <quic_mkrishn@quicinc.com>
>
> Changes in v2:
> - Drop target from description (Stephen Boyd)
> - Drop items from compatible (Stephen Boyd)
> - Add clock names one per line for readability (Stephen Boyd)
> - Use correct indendation (Stephen Boyd)
This changelog should come after the triple dash. qcom maintainers don't
want drm style changelogs in the commit text.
> ---
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
^ permalink raw reply [flat|nested] 13+ messages in thread