From: SF Markus Elfring <elfring@users.sourceforge.net>
To: linux-fbdev@vger.kernel.org, linux-parisc@vger.kernel.org,
dri-devel@lists.freedesktop.org,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Helge Deller <deller@gmx.de>,
"James E. J. Bottomley" <jejb@parisc-linux.org>,
Rolf Eike Beer <eike-kernel@sf-tec.de>
Cc: kernel-janitors@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH v2 2/2] video/fbdev/stifb: Delete an error message for a failed memory allocation in stifb_in
Date: Sun, 07 Jan 2018 11:58:47 +0000 [thread overview]
Message-ID: <f92f41b1-d4fa-4ffa-8c19-af4eb0d2d8cf@users.sourceforge.net> (raw)
In-Reply-To: <889131fe-199c-3bef-0781-00761b807426@users.sourceforge.net>
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sun, 7 Jan 2018 12:34:22 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
v2:
This update suggestion was rebased on source files from the software
"Linux next-20180105" together with a change for an error code.
drivers/video/fbdev/stifb.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/video/fbdev/stifb.c b/drivers/video/fbdev/stifb.c
index 511a594889af..dec8efb4f256 100644
--- a/drivers/video/fbdev/stifb.c
+++ b/drivers/video/fbdev/stifb.c
@@ -1126,10 +1126,8 @@ static int __init stifb_init_fb(struct sti_struct *sti, int bpp_pref)
int bpp, xres, yres;
fb = kzalloc(sizeof(*fb), GFP_ATOMIC);
- if (!fb) {
- printk(KERN_ERR "stifb: Could not allocate stifb structure\n");
+ if (!fb)
return -ENOMEM;
- }
info = &fb->info;
--
2.15.1
WARNING: multiple messages have this Message-ID (diff)
From: SF Markus Elfring <elfring@users.sourceforge.net>
To: linux-fbdev@vger.kernel.org, linux-parisc@vger.kernel.org,
dri-devel@lists.freedesktop.org,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Helge Deller <deller@gmx.de>,
"James E. J. Bottomley" <jejb@parisc-linux.org>,
Rolf Eike Beer <eike-kernel@sf-tec.de>
Cc: kernel-janitors@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH v2 2/2] video/fbdev/stifb: Delete an error message for a failed memory allocation in stifb_init_fb()
Date: Sun, 7 Jan 2018 12:58:47 +0100 [thread overview]
Message-ID: <f92f41b1-d4fa-4ffa-8c19-af4eb0d2d8cf@users.sourceforge.net> (raw)
In-Reply-To: <889131fe-199c-3bef-0781-00761b807426@users.sourceforge.net>
RnJvbTogTWFya3VzIEVsZnJpbmcgPGVsZnJpbmdAdXNlcnMuc291cmNlZm9yZ2UubmV0PgpEYXRl
OiBTdW4sIDcgSmFuIDIwMTggMTI6MzQ6MjIgKzAxMDAKCk9taXQgYW4gZXh0cmEgbWVzc2FnZSBm
b3IgYSBtZW1vcnkgYWxsb2NhdGlvbiBmYWlsdXJlIGluIHRoaXMgZnVuY3Rpb24uCgpUaGlzIGlz
c3VlIHdhcyBkZXRlY3RlZCBieSB1c2luZyB0aGUgQ29jY2luZWxsZSBzb2Z0d2FyZS4KClNpZ25l
ZC1vZmYtYnk6IE1hcmt1cyBFbGZyaW5nIDxlbGZyaW5nQHVzZXJzLnNvdXJjZWZvcmdlLm5ldD4K
LS0tCgp2MjoKVGhpcyB1cGRhdGUgc3VnZ2VzdGlvbiB3YXMgcmViYXNlZCBvbiBzb3VyY2UgZmls
ZXMgZnJvbSB0aGUgc29mdHdhcmUKIkxpbnV4IG5leHQtMjAxODAxMDUiIHRvZ2V0aGVyIHdpdGgg
YSBjaGFuZ2UgZm9yIGFuIGVycm9yIGNvZGUuCgogZHJpdmVycy92aWRlby9mYmRldi9zdGlmYi5j
IHwgNCArLS0tCiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDMgZGVsZXRpb25zKC0p
CgpkaWZmIC0tZ2l0IGEvZHJpdmVycy92aWRlby9mYmRldi9zdGlmYi5jIGIvZHJpdmVycy92aWRl
by9mYmRldi9zdGlmYi5jCmluZGV4IDUxMWE1OTQ4ODlhZi4uZGVjOGVmYjRmMjU2IDEwMDY0NAot
LS0gYS9kcml2ZXJzL3ZpZGVvL2ZiZGV2L3N0aWZiLmMKKysrIGIvZHJpdmVycy92aWRlby9mYmRl
di9zdGlmYi5jCkBAIC0xMTI2LDEwICsxMTI2LDggQEAgc3RhdGljIGludCBfX2luaXQgc3RpZmJf
aW5pdF9mYihzdHJ1Y3Qgc3RpX3N0cnVjdCAqc3RpLCBpbnQgYnBwX3ByZWYpCiAJaW50IGJwcCwg
eHJlcywgeXJlczsKIAogCWZiID0ga3phbGxvYyhzaXplb2YoKmZiKSwgR0ZQX0FUT01JQyk7Ci0J
aWYgKCFmYikgewotCQlwcmludGsoS0VSTl9FUlIgInN0aWZiOiBDb3VsZCBub3QgYWxsb2NhdGUg
c3RpZmIgc3RydWN0dXJlXG4iKTsKKwlpZiAoIWZiKQogCQlyZXR1cm4gLUVOT01FTTsKLQl9CiAJ
CiAJaW5mbyA9ICZmYi0+aW5mbzsKIAotLSAKMi4xNS4xCgpfX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZl
bEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp
bG1hbi9saXN0aW5mby9kcmktZGV2ZWwK
WARNING: multiple messages have this Message-ID (diff)
From: SF Markus Elfring <elfring@users.sourceforge.net>
To: linux-fbdev@vger.kernel.org, linux-parisc@vger.kernel.org,
dri-devel@lists.freedesktop.org,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Helge Deller <deller@gmx.de>,
"James E. J. Bottomley" <jejb@parisc-linux.org>,
Rolf Eike Beer <eike-kernel@sf-tec.de>
Cc: kernel-janitors@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH v2 2/2] video/fbdev/stifb: Delete an error message for a failed memory allocation in stifb_init_fb()
Date: Sun, 7 Jan 2018 12:58:47 +0100 [thread overview]
Message-ID: <f92f41b1-d4fa-4ffa-8c19-af4eb0d2d8cf@users.sourceforge.net> (raw)
In-Reply-To: <889131fe-199c-3bef-0781-00761b807426@users.sourceforge.net>
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sun, 7 Jan 2018 12:34:22 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
v2:
This update suggestion was rebased on source files from the software
"Linux next-20180105" together with a change for an error code.
drivers/video/fbdev/stifb.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/video/fbdev/stifb.c b/drivers/video/fbdev/stifb.c
index 511a594889af..dec8efb4f256 100644
--- a/drivers/video/fbdev/stifb.c
+++ b/drivers/video/fbdev/stifb.c
@@ -1126,10 +1126,8 @@ static int __init stifb_init_fb(struct sti_struct *sti, int bpp_pref)
int bpp, xres, yres;
fb = kzalloc(sizeof(*fb), GFP_ATOMIC);
- if (!fb) {
- printk(KERN_ERR "stifb: Could not allocate stifb structure\n");
+ if (!fb)
return -ENOMEM;
- }
info = &fb->info;
--
2.15.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: SF Markus Elfring <elfring@users.sourceforge.net>
To: linux-fbdev@vger.kernel.org, linux-parisc@vger.kernel.org,
dri-devel@lists.freedesktop.org,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Helge Deller <deller@gmx.de>,
"James E. J. Bottomley" <jejb@parisc-linux.org>,
Rolf Eike Beer <eike-kernel@sf-tec.de>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: [PATCH v2 2/2] video/fbdev/stifb: Delete an error message for a failed memory allocation in stifb_init_fb()
Date: Sun, 7 Jan 2018 12:58:47 +0100 [thread overview]
Message-ID: <f92f41b1-d4fa-4ffa-8c19-af4eb0d2d8cf@users.sourceforge.net> (raw)
In-Reply-To: <889131fe-199c-3bef-0781-00761b807426@users.sourceforge.net>
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sun, 7 Jan 2018 12:34:22 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
v2:
This update suggestion was rebased on source files from the software
"Linux next-20180105" together with a change for an error code.
drivers/video/fbdev/stifb.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/video/fbdev/stifb.c b/drivers/video/fbdev/stifb.c
index 511a594889af..dec8efb4f256 100644
--- a/drivers/video/fbdev/stifb.c
+++ b/drivers/video/fbdev/stifb.c
@@ -1126,10 +1126,8 @@ static int __init stifb_init_fb(struct sti_struct *sti, int bpp_pref)
int bpp, xres, yres;
fb = kzalloc(sizeof(*fb), GFP_ATOMIC);
- if (!fb) {
- printk(KERN_ERR "stifb: Could not allocate stifb structure\n");
+ if (!fb)
return -ENOMEM;
- }
info = &fb->info;
--
2.15.1
next prev parent reply other threads:[~2018-01-07 11:58 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-24 21:28 [PATCH] video/fbdev/stifb: Delete an error message for a failed memory allocation in stifb_init_fb() SF Markus Elfring
2017-11-24 21:28 ` SF Markus Elfring
2017-11-24 21:30 ` [PATCH] video/fbdev/stifb: Delete an error message for a failed memory allocation in stifb_init_ Rolf Eike Beer
2017-11-24 21:30 ` [PATCH] video/fbdev/stifb: Delete an error message for a failed memory allocation in stifb_init_fb() Rolf Eike Beer
2017-12-29 18:05 ` [PATCH] video/fbdev/stifb: Delete an error message for a failed memory allocation in stifb_init_ Bartlomiej Zolnierkiewicz
2017-12-29 18:05 ` [PATCH] video/fbdev/stifb: Delete an error message for a failed memory allocation in stifb_init_fb() Bartlomiej Zolnierkiewicz
2018-01-07 11:55 ` [PATCH v2 0/2] video/fbdev/stifb: Adjustments for stifb_init_fb() SF Markus Elfring
2018-01-07 11:55 ` SF Markus Elfring
2018-01-07 11:55 ` SF Markus Elfring
2018-01-07 11:55 ` SF Markus Elfring
2018-01-07 11:56 ` [PATCH v2 1/2] video/fbdev/stifb: Return -ENOMEM after a failed kzalloc() in stifb_init_fb() SF Markus Elfring
2018-01-07 11:56 ` SF Markus Elfring
2018-01-07 11:56 ` SF Markus Elfring
2018-01-07 11:56 ` SF Markus Elfring
2018-03-28 13:34 ` Bartlomiej Zolnierkiewicz
2018-03-28 13:34 ` Bartlomiej Zolnierkiewicz
2018-03-28 13:34 ` Bartlomiej Zolnierkiewicz
2018-03-28 13:34 ` Bartlomiej Zolnierkiewicz
2018-01-07 11:58 ` SF Markus Elfring [this message]
2018-01-07 11:58 ` [PATCH v2 2/2] video/fbdev/stifb: Delete an error message for a failed memory allocation " SF Markus Elfring
2018-01-07 11:58 ` SF Markus Elfring
2018-01-07 11:58 ` SF Markus Elfring
2018-03-28 13:36 ` [PATCH v2 2/2] video/fbdev/stifb: Delete an error message for a failed memory allocation in stif Bartlomiej Zolnierkiewicz
2018-03-28 13:36 ` [PATCH v2 2/2] video/fbdev/stifb: Delete an error message for a failed memory allocation in stifb_init_fb() Bartlomiej Zolnierkiewicz
2018-03-28 13:36 ` Bartlomiej Zolnierkiewicz
2018-03-28 13:36 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f92f41b1-d4fa-4ffa-8c19-af4eb0d2d8cf@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=b.zolnierkie@samsung.com \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=eike-kernel@sf-tec.de \
--cc=jejb@parisc-linux.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.