Re: [PATCH] phy: qcom: snps-femto-v2: assert reset in probe

[Neil Armstrong <neil.armstrong@linaro.org>]

On 11/14/25 15:47, Casey Connolly wrote:
> The power on function for the phy only deasserts the reset, so the phy
> might be in a weird state that we don't clean up properly.
> 
> Assert the reset in probe() so that when we power on we will have the
> phy in a clean state.
> 
> Signed-off-by: Casey Connolly <casey.connolly@linaro.org>
> ---
>   drivers/phy/qcom/phy-qcom-snps-femto-v2.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/phy/qcom/phy-qcom-snps-femto-v2.c b/drivers/phy/qcom/phy-qcom-snps-femto-v2.c
> index 04f0f0e7817d..e782de07ebc5 100644
> --- a/drivers/phy/qcom/phy-qcom-snps-femto-v2.c
> +++ b/drivers/phy/qcom/phy-qcom-snps-femto-v2.c
> @@ -173,9 +173,9 @@ static int qcom_snps_hsphy_phy_probe(struct udevice *dev)
>   		printf("failed to get resets, ret = %d\n", ret);
>   		return ret;
>   	}
>   
> -	reset_deassert_bulk(&priv->resets);
> +	reset_assert_bulk(&priv->resets);
>   
>   	return 0;
>   }
>   

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>