* [PATCH] phy: qcom: snps-femto-v2: assert reset in probe
@ 2025-11-14 14:47 Casey Connolly
2025-11-18 8:09 ` Neil Armstrong
2026-01-16 18:03 ` Casey Connolly
0 siblings, 2 replies; 3+ messages in thread
From: Casey Connolly @ 2025-11-14 14:47 UTC (permalink / raw)
To: u-boot-qcom, Casey Connolly, Neil Armstrong, Sumit Garg, Tom Rini; +Cc: u-boot
The power on function for the phy only deasserts the reset, so the phy
might be in a weird state that we don't clean up properly.
Assert the reset in probe() so that when we power on we will have the
phy in a clean state.
Signed-off-by: Casey Connolly <casey.connolly@linaro.org>
---
drivers/phy/qcom/phy-qcom-snps-femto-v2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/phy/qcom/phy-qcom-snps-femto-v2.c b/drivers/phy/qcom/phy-qcom-snps-femto-v2.c
index 04f0f0e7817d..e782de07ebc5 100644
--- a/drivers/phy/qcom/phy-qcom-snps-femto-v2.c
+++ b/drivers/phy/qcom/phy-qcom-snps-femto-v2.c
@@ -173,9 +173,9 @@ static int qcom_snps_hsphy_phy_probe(struct udevice *dev)
printf("failed to get resets, ret = %d\n", ret);
return ret;
}
- reset_deassert_bulk(&priv->resets);
+ reset_assert_bulk(&priv->resets);
return 0;
}
--
2.51.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] phy: qcom: snps-femto-v2: assert reset in probe
2025-11-14 14:47 [PATCH] phy: qcom: snps-femto-v2: assert reset in probe Casey Connolly
@ 2025-11-18 8:09 ` Neil Armstrong
2026-01-16 18:03 ` Casey Connolly
1 sibling, 0 replies; 3+ messages in thread
From: Neil Armstrong @ 2025-11-18 8:09 UTC (permalink / raw)
To: Casey Connolly, u-boot-qcom, Sumit Garg, Tom Rini; +Cc: u-boot
On 11/14/25 15:47, Casey Connolly wrote:
> The power on function for the phy only deasserts the reset, so the phy
> might be in a weird state that we don't clean up properly.
>
> Assert the reset in probe() so that when we power on we will have the
> phy in a clean state.
>
> Signed-off-by: Casey Connolly <casey.connolly@linaro.org>
> ---
> drivers/phy/qcom/phy-qcom-snps-femto-v2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/phy/qcom/phy-qcom-snps-femto-v2.c b/drivers/phy/qcom/phy-qcom-snps-femto-v2.c
> index 04f0f0e7817d..e782de07ebc5 100644
> --- a/drivers/phy/qcom/phy-qcom-snps-femto-v2.c
> +++ b/drivers/phy/qcom/phy-qcom-snps-femto-v2.c
> @@ -173,9 +173,9 @@ static int qcom_snps_hsphy_phy_probe(struct udevice *dev)
> printf("failed to get resets, ret = %d\n", ret);
> return ret;
> }
>
> - reset_deassert_bulk(&priv->resets);
> + reset_assert_bulk(&priv->resets);
>
> return 0;
> }
>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] phy: qcom: snps-femto-v2: assert reset in probe
2025-11-14 14:47 [PATCH] phy: qcom: snps-femto-v2: assert reset in probe Casey Connolly
2025-11-18 8:09 ` Neil Armstrong
@ 2026-01-16 18:03 ` Casey Connolly
1 sibling, 0 replies; 3+ messages in thread
From: Casey Connolly @ 2026-01-16 18:03 UTC (permalink / raw)
To: u-boot-qcom, Neil Armstrong, Sumit Garg, Tom Rini, Casey Connolly; +Cc: u-boot
On Fri, 14 Nov 2025 15:47:21 +0100, Casey Connolly wrote:
> The power on function for the phy only deasserts the reset, so the phy
> might be in a weird state that we don't clean up properly.
>
> Assert the reset in probe() so that when we power on we will have the
> phy in a clean state.
>
>
> [...]
Applied, thanks!
[1/1] phy: qcom: snps-femto-v2: assert reset in probe
https://source.denx.de/u-boot/custodians/u-boot-snapdragon/-/commit/c9c61c1f4e74
Best regards,
--
// Casey (she/they)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-01-16 18:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-14 14:47 [PATCH] phy: qcom: snps-femto-v2: assert reset in probe Casey Connolly
2025-11-18 8:09 ` Neil Armstrong
2026-01-16 18:03 ` Casey Connolly
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.