From: Krzysztof Kozlowski <krzk@kernel.org>
To: dongxuyang@eswincomputing.com, p.zabel@pengutronix.de,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: ningyu@eswincomputing.com, linmin@eswincomputing.com,
huangyifeng@eswincomputing.com
Subject: Re: [PATCH v3 2/2] reset: eswin: Add eic7700 reset driver
Date: Thu, 19 Jun 2025 19:41:09 +0200 [thread overview]
Message-ID: <f9a48d99-49c6-4efa-bd97-e9dba9fc55f6@kernel.org> (raw)
In-Reply-To: <20250619080101.1360-1-dongxuyang@eswincomputing.com>
On 19/06/2025 10:01, dongxuyang@eswincomputing.com wrote:
> +
> +static const struct reset_control_ops eswin_reset_ops = {
> + .reset = eswin_reset_reset,
> + .assert = eswin_reset_assert,
> + .deassert = eswin_reset_deassert,
> +};
> +
> +static int eswin_reset_of_xlate_lookup_id(int id, void *p, void *data)
> +{
> + struct of_phandle_args *reset_spec = data;
Still wrong cast.
What is the type? You got exactly that question. How did you resolve it?
> + struct eswin_reset_control *slot_control = p;
> +
> + if (reset_spec->args[0] == slot_control->dev_id &&
> + reset_spec->args[1] == slot_control->reset_bit)
> + return id;
> +
> + return 0;
> +}
> +
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-06-19 17:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-19 7:58 [PATCH v3 0/2] Add driver support for ESWIN eic7700 SoC reset controller dongxuyang
2025-06-19 8:00 ` [PATCH v3 1/2] dt-bindings: reset: eswin: Documentation for eic7700 SoC dongxuyang
2025-06-19 17:39 ` Krzysztof Kozlowski
2025-06-19 8:01 ` [PATCH v3 2/2] reset: eswin: Add eic7700 reset driver dongxuyang
2025-06-19 17:41 ` Krzysztof Kozlowski [this message]
2025-06-19 17:40 ` [PATCH v3 0/2] Add driver support for ESWIN eic7700 SoC reset controller Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9a48d99-49c6-4efa-bd97-e9dba9fc55f6@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dongxuyang@eswincomputing.com \
--cc=huangyifeng@eswincomputing.com \
--cc=krzk+dt@kernel.org \
--cc=linmin@eswincomputing.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ningyu@eswincomputing.com \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.