All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Lis, Tomasz" <tomasz.lis@intel.com>
To: Lucas De Marchi <lucas.demarchi@intel.com>,
	Matt Roper <matthew.d.roper@intel.com>
Cc: intel-gfx@lists.freedesktop.org,
	Francisco Jerez <francisco.jerez.plata@intel.com>
Subject: Re: [PATCH v3 2/2] drm/i915/tgl: MOCS table update
Date: Wed, 13 Nov 2019 13:58:32 +0100	[thread overview]
Message-ID: <fa3d2488-bdcc-6d31-7cd2-4dd0be3cfb20@intel.com> (raw)
In-Reply-To: <20191113010921.3saafyl6mo6ien5c@ldmartin-desk1>


On 2019-11-13 02:09, Lucas De Marchi wrote:
> On Tue, Nov 12, 2019 at 02:47:57PM -0800, Matt Roper wrote:
>> The bspec was just updated with a minor correction to entry 61 (it
>> shouldn't have had the SCF bit set).
>>
>> v2:
>> - Add a MOCS_ENTRY_UNUSED() and use it to declare the
>>   explicitly-reserved MOCS entries. (Lucas)
>> - Move the warning suppression from the Makefile to a #pragma that only
>>   affects the TGL table. (Lucas)
>>
>> v3:
>> - Entries 16 and 17 are identical to ICL now, so no need to explicitly
>>   adjust them (or mess with compiler warning overrides).
>>
>> Bspec: 45101
>> Fixes: 2ddf992179c4 ("drm/i915/tgl: Define MOCS entries for Tigerlake")
>> Cc: Tomasz Lis <tomasz.lis@intel.com>
>> Cc: Lucas De Marchi <lucas.demarchi@intel.com>
>> Cc: Francisco Jerez <francisco.jerez.plata@intel.com>
>> Cc: Jon Bloomfield <jon.bloomfield@intel.com>
>> Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
>
>
> Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
>
> Lucas De Marchi

Reviewed-by: Tomasz Lis <tomasz.lis@intel.com>

Tomasz

>
>> ---
>> drivers/gpu/drm/i915/gt/intel_mocs.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/gt/intel_mocs.c 
>> b/drivers/gpu/drm/i915/gt/intel_mocs.c
>> index 06e2adbf27be..2b977991b785 100644
>> --- a/drivers/gpu/drm/i915/gt/intel_mocs.c
>> +++ b/drivers/gpu/drm/i915/gt/intel_mocs.c
>> @@ -263,7 +263,7 @@ static const struct drm_i915_mocs_entry 
>> tigerlake_mocs_table[] = {
>>            L3_1_UC),
>>     /* HW Special Case (Displayable) */
>>     MOCS_ENTRY(61,
>> -           LE_1_UC | LE_TC_1_LLC | LE_SCF(1),
>> +           LE_1_UC | LE_TC_1_LLC,
>>            L3_3_WB),
>> };
>>
>> -- 
>> 2.21.0
>>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: "Lis, Tomasz" <tomasz.lis@intel.com>
To: Lucas De Marchi <lucas.demarchi@intel.com>,
	Matt Roper <matthew.d.roper@intel.com>
Cc: intel-gfx@lists.freedesktop.org,
	Francisco Jerez <francisco.jerez.plata@intel.com>
Subject: Re: [Intel-gfx] [PATCH v3 2/2] drm/i915/tgl: MOCS table update
Date: Wed, 13 Nov 2019 13:58:32 +0100	[thread overview]
Message-ID: <fa3d2488-bdcc-6d31-7cd2-4dd0be3cfb20@intel.com> (raw)
Message-ID: <20191113125832.q6CcY4Fz4Hhn43IExeZJhWKGC-d_rWal0vf64vDaFY0@z> (raw)
In-Reply-To: <20191113010921.3saafyl6mo6ien5c@ldmartin-desk1>


On 2019-11-13 02:09, Lucas De Marchi wrote:
> On Tue, Nov 12, 2019 at 02:47:57PM -0800, Matt Roper wrote:
>> The bspec was just updated with a minor correction to entry 61 (it
>> shouldn't have had the SCF bit set).
>>
>> v2:
>> - Add a MOCS_ENTRY_UNUSED() and use it to declare the
>>   explicitly-reserved MOCS entries. (Lucas)
>> - Move the warning suppression from the Makefile to a #pragma that only
>>   affects the TGL table. (Lucas)
>>
>> v3:
>> - Entries 16 and 17 are identical to ICL now, so no need to explicitly
>>   adjust them (or mess with compiler warning overrides).
>>
>> Bspec: 45101
>> Fixes: 2ddf992179c4 ("drm/i915/tgl: Define MOCS entries for Tigerlake")
>> Cc: Tomasz Lis <tomasz.lis@intel.com>
>> Cc: Lucas De Marchi <lucas.demarchi@intel.com>
>> Cc: Francisco Jerez <francisco.jerez.plata@intel.com>
>> Cc: Jon Bloomfield <jon.bloomfield@intel.com>
>> Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
>
>
> Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
>
> Lucas De Marchi

Reviewed-by: Tomasz Lis <tomasz.lis@intel.com>

Tomasz

>
>> ---
>> drivers/gpu/drm/i915/gt/intel_mocs.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/gt/intel_mocs.c 
>> b/drivers/gpu/drm/i915/gt/intel_mocs.c
>> index 06e2adbf27be..2b977991b785 100644
>> --- a/drivers/gpu/drm/i915/gt/intel_mocs.c
>> +++ b/drivers/gpu/drm/i915/gt/intel_mocs.c
>> @@ -263,7 +263,7 @@ static const struct drm_i915_mocs_entry 
>> tigerlake_mocs_table[] = {
>>            L3_1_UC),
>>     /* HW Special Case (Displayable) */
>>     MOCS_ENTRY(61,
>> -           LE_1_UC | LE_TC_1_LLC | LE_SCF(1),
>> +           LE_1_UC | LE_TC_1_LLC,
>>            L3_3_WB),
>> };
>>
>> -- 
>> 2.21.0
>>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2019-11-13 12:58 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-12 22:47 [PATCH v3 1/2] Revert "drm/i915/ehl: Update MOCS table for EHL" Matt Roper
2019-11-12 22:47 ` [Intel-gfx] " Matt Roper
2019-11-12 22:47 ` [PATCH v3 2/2] drm/i915/tgl: MOCS table update Matt Roper
2019-11-12 22:47   ` [Intel-gfx] " Matt Roper
2019-11-12 23:20   ` Francisco Jerez
2019-11-12 23:20     ` [Intel-gfx] " Francisco Jerez
2019-11-13  1:09   ` Lucas De Marchi
2019-11-13  1:09     ` [Intel-gfx] " Lucas De Marchi
2019-11-13 12:58     ` Lis, Tomasz [this message]
2019-11-13 12:58       ` Lis, Tomasz
2019-11-12 23:15 ` [PATCH v3 1/2] Revert "drm/i915/ehl: Update MOCS table for EHL" Francisco Jerez
2019-11-12 23:15   ` [Intel-gfx] " Francisco Jerez
2019-11-13  0:32 ` ✓ Fi.CI.BAT: success for series starting with [v3,1/2] " Patchwork
2019-11-13  0:32   ` [Intel-gfx] " Patchwork
2019-11-13 11:49 ` ✗ Fi.CI.IGT: failure " Patchwork
2019-11-13 11:49   ` [Intel-gfx] " Patchwork
2019-11-13 16:39   ` Matt Roper
2019-11-13 16:39     ` [Intel-gfx] " Matt Roper
2019-11-13 16:51     ` [igt-dev] [PATCH i-g-t] i915/gem_mocs_settings: Update TGL MOCS table Matt Roper
2019-11-13 16:51       ` [Intel-gfx] " Matt Roper
2019-11-13 16:51       ` Matt Roper
2019-11-13 21:25       ` [igt-dev] " Lucas De Marchi
2019-11-13 21:25         ` [Intel-gfx] " Lucas De Marchi
2019-11-13 21:25         ` Lucas De Marchi
2019-11-13 17:41 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-11-14  8:35 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fa3d2488-bdcc-6d31-7cd2-4dd0be3cfb20@intel.com \
    --to=tomasz.lis@intel.com \
    --cc=francisco.jerez.plata@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=lucas.demarchi@intel.com \
    --cc=matthew.d.roper@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.