Re: [PATCH] media: i2c: ov02c10: Narrow chip id check down to match ov02c chips only

[Vladimir Zapolskiy <vz@kernel.org>]

Hi Sakari,

On 6/21/26 17:58, Vladimir Zapolskiy wrote:
> Originally a chip id check in the driver's probe function is done for
> any OmniVision "ov02" sensors, but is too wide, since there are at least
> "ov02a", "ov02b", "ov02c", "ov02e", "ov02g", "ov02k" and likely even
> more families of sensors with similar names, thus the check for id shall
> be more specific and match "ov02c" exclusively and expectedly.
> 
> Signed-off-by: Vladimir Zapolskiy <vz@kernel.org>
> ---
>   drivers/media/i2c/ov02c10.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/media/i2c/ov02c10.c b/drivers/media/i2c/ov02c10.c
> index cf93d36032e1..b36da75d7dfa 100644
> --- a/drivers/media/i2c/ov02c10.c
> +++ b/drivers/media/i2c/ov02c10.c
> @@ -18,8 +18,8 @@
>   #define OV02C10_MCLK			19200000
>   #define OV02C10_RGB_DEPTH		10
>   
> -#define OV02C10_REG_CHIP_ID		CCI_REG16(0x300a)
> -#define OV02C10_CHIP_ID			0x5602
> +#define OV02C10_REG_CHIP_ID		CCI_REG24(0x300a)
> +#define OV02C10_CHIP_ID			0x560243
>   
>   #define OV02C10_REG_STREAM_CONTROL	CCI_REG8(0x0100)
>   

can you please start review of this trivial and long-standing change?

Thank you in advance.

-- 
Best wishes,
Vladimir