[PATCH] media: i2c: ov02c10: Narrow chip id check down to match ov02c chips only

All of lore.kernel.org
 help / color / mirror / Atom feed

* [PATCH] media: i2c: ov02c10: Narrow chip id check down to match ov02c chips only
@ 2026-06-21 14:58 Vladimir Zapolskiy
  2026-06-22  6:00 ` Tarang Raval
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Vladimir Zapolskiy @ 2026-06-21 14:58 UTC (permalink / raw)
  To: Hans de Goede
  Cc: Bryan O'Donoghue, Sakari Ailus, Mauro Carvalho Chehab,
	linux-media

Originally a chip id check in the driver's probe function is done for
any OmniVision "ov02" sensors, but is too wide, since there are at least
"ov02a", "ov02b", "ov02c", "ov02e", "ov02g", "ov02k" and likely even
more families of sensors with similar names, thus the check for id shall
be more specific and match "ov02c" exclusively and expectedly.

Signed-off-by: Vladimir Zapolskiy <vz@kernel.org>
---
 drivers/media/i2c/ov02c10.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/media/i2c/ov02c10.c b/drivers/media/i2c/ov02c10.c
index cf93d36032e1..b36da75d7dfa 100644
--- a/drivers/media/i2c/ov02c10.c
+++ b/drivers/media/i2c/ov02c10.c
@@ -18,8 +18,8 @@
 #define OV02C10_MCLK			19200000
 #define OV02C10_RGB_DEPTH		10
 
-#define OV02C10_REG_CHIP_ID		CCI_REG16(0x300a)
-#define OV02C10_CHIP_ID			0x5602
+#define OV02C10_REG_CHIP_ID		CCI_REG24(0x300a)
+#define OV02C10_CHIP_ID			0x560243
 
 #define OV02C10_REG_STREAM_CONTROL	CCI_REG8(0x0100)
 
-- 
2.51.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] media: i2c: ov02c10: Narrow chip id check down to match ov02c chips only
  2026-06-21 14:58 [PATCH] media: i2c: ov02c10: Narrow chip id check down to match ov02c chips only Vladimir Zapolskiy
@ 2026-06-22  6:00 ` Tarang Raval
  2026-09-08 13:12 ` Vladimir Zapolskiy
  2026-09-29  7:58 ` Vladimir Zapolskiy
  2 siblings, 0 replies; 5+ messages in thread
From: Tarang Raval @ 2026-06-22  6:00 UTC (permalink / raw)
  To: Vladimir Zapolskiy, Hans de Goede
  Cc: Bryan O'Donoghue, Sakari Ailus, Mauro Carvalho Chehab,
	linux-media@vger.kernel.org

Hi Vladimir,

> Originally a chip id check in the driver's probe function is done for
> any OmniVision "ov02" sensors, but is too wide, since there are at least
> "ov02a", "ov02b", "ov02c", "ov02e", "ov02g", "ov02k" and likely even
> more families of sensors with similar names, thus the check for id shall
> be more specific and match "ov02c" exclusively and expectedly.
>
> Signed-off-by: Vladimir Zapolskiy <vz@kernel.org>
> ---
>  drivers/media/i2c/ov02c10.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/i2c/ov02c10.c b/drivers/media/i2c/ov02c10.c
> index cf93d36032e1..b36da75d7dfa 100644
> --- a/drivers/media/i2c/ov02c10.c
> +++ b/drivers/media/i2c/ov02c10.c
> @@ -18,8 +18,8 @@
>  #define OV02C10_MCLK                   19200000
>  #define OV02C10_RGB_DEPTH              10
>
> -#define OV02C10_REG_CHIP_ID            CCI_REG16(0x300a)
> -#define OV02C10_CHIP_ID                        0x5602
> +#define OV02C10_REG_CHIP_ID            CCI_REG24(0x300a)
> +#define OV02C10_CHIP_ID                        0x560243

Reviewed-by: Tarang Raval <tarang.raval@siliconsignals.io>

Best Regards,
Tarang

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] media: i2c: ov02c10: Narrow chip id check down to match ov02c chips only
  2026-06-21 14:58 [PATCH] media: i2c: ov02c10: Narrow chip id check down to match ov02c chips only Vladimir Zapolskiy
  2026-06-22  6:00 ` Tarang Raval
@ 2026-09-08 13:12 ` Vladimir Zapolskiy
  2026-09-29  7:58 ` Vladimir Zapolskiy
  2 siblings, 0 replies; 5+ messages in thread
From: Vladimir Zapolskiy @ 2026-09-08 13:12 UTC (permalink / raw)
  To: Sakari Ailus
  Cc: Bryan O'Donoghue, Mauro Carvalho Chehab, linux-media,
	Hans de Goede

Hi Sakari,

On 6/21/26 17:58, Vladimir Zapolskiy wrote:
> Originally a chip id check in the driver's probe function is done for
> any OmniVision "ov02" sensors, but is too wide, since there are at least
> "ov02a", "ov02b", "ov02c", "ov02e", "ov02g", "ov02k" and likely even
> more families of sensors with similar names, thus the check for id shall
> be more specific and match "ov02c" exclusively and expectedly.
> 
> Signed-off-by: Vladimir Zapolskiy <vz@kernel.org>
> ---
>   drivers/media/i2c/ov02c10.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/media/i2c/ov02c10.c b/drivers/media/i2c/ov02c10.c
> index cf93d36032e1..b36da75d7dfa 100644
> --- a/drivers/media/i2c/ov02c10.c
> +++ b/drivers/media/i2c/ov02c10.c
> @@ -18,8 +18,8 @@
>   #define OV02C10_MCLK			19200000
>   #define OV02C10_RGB_DEPTH		10
>   
> -#define OV02C10_REG_CHIP_ID		CCI_REG16(0x300a)
> -#define OV02C10_CHIP_ID			0x5602
> +#define OV02C10_REG_CHIP_ID		CCI_REG24(0x300a)
> +#define OV02C10_CHIP_ID			0x560243
>   
>   #define OV02C10_REG_STREAM_CONTROL	CCI_REG8(0x0100)
>   

is there anything else to be done to get this proposed change accepted?

-- 
Best wishes,
Vladimir

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] media: i2c: ov02c10: Narrow chip id check down to match ov02c chips only
  2026-06-21 14:58 [PATCH] media: i2c: ov02c10: Narrow chip id check down to match ov02c chips only Vladimir Zapolskiy
  2026-06-22  6:00 ` Tarang Raval
  2026-09-08 13:12 ` Vladimir Zapolskiy
@ 2026-09-29  7:58 ` Vladimir Zapolskiy
  2026-09-29 12:02   ` Sakari Ailus
  2 siblings, 1 reply; 5+ messages in thread
From: Vladimir Zapolskiy @ 2026-09-29  7:58 UTC (permalink / raw)
  To: Sakari Ailus
  Cc: Bryan O'Donoghue, Mauro Carvalho Chehab, linux-media,
	Hans de Goede

Hi Sakari,

On 6/21/26 17:58, Vladimir Zapolskiy wrote:
> Originally a chip id check in the driver's probe function is done for
> any OmniVision "ov02" sensors, but is too wide, since there are at least
> "ov02a", "ov02b", "ov02c", "ov02e", "ov02g", "ov02k" and likely even
> more families of sensors with similar names, thus the check for id shall
> be more specific and match "ov02c" exclusively and expectedly.
> 
> Signed-off-by: Vladimir Zapolskiy <vz@kernel.org>
> ---
>   drivers/media/i2c/ov02c10.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/media/i2c/ov02c10.c b/drivers/media/i2c/ov02c10.c
> index cf93d36032e1..b36da75d7dfa 100644
> --- a/drivers/media/i2c/ov02c10.c
> +++ b/drivers/media/i2c/ov02c10.c
> @@ -18,8 +18,8 @@
>   #define OV02C10_MCLK			19200000
>   #define OV02C10_RGB_DEPTH		10
>   
> -#define OV02C10_REG_CHIP_ID		CCI_REG16(0x300a)
> -#define OV02C10_CHIP_ID			0x5602
> +#define OV02C10_REG_CHIP_ID		CCI_REG24(0x300a)
> +#define OV02C10_CHIP_ID			0x560243
>   
>   #define OV02C10_REG_STREAM_CONTROL	CCI_REG8(0x0100)
>   

can you please start review of this trivial and long-standing change?

Thank you in advance.

-- 
Best wishes,
Vladimir

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] media: i2c: ov02c10: Narrow chip id check down to match ov02c chips only
  2026-09-29  7:58 ` Vladimir Zapolskiy
@ 2026-09-29 12:02   ` Sakari Ailus
  0 siblings, 0 replies; 5+ messages in thread
From: Sakari Ailus @ 2026-09-29 12:02 UTC (permalink / raw)
  To: Vladimir Zapolskiy
  Cc: Bryan O'Donoghue, Mauro Carvalho Chehab, linux-media,
	Hans de Goede

Hi Vladimir,

On Tue, Sep 29, 2026 at 10:58:16AM +0300, Vladimir Zapolskiy wrote:
> Hi Sakari,
> 
> On 6/21/26 17:58, Vladimir Zapolskiy wrote:
> > Originally a chip id check in the driver's probe function is done for
> > any OmniVision "ov02" sensors, but is too wide, since there are at least
> > "ov02a", "ov02b", "ov02c", "ov02e", "ov02g", "ov02k" and likely even
> > more families of sensors with similar names, thus the check for id shall
> > be more specific and match "ov02c" exclusively and expectedly.
> > 
> > Signed-off-by: Vladimir Zapolskiy <vz@kernel.org>
> > ---
> >   drivers/media/i2c/ov02c10.c | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/media/i2c/ov02c10.c b/drivers/media/i2c/ov02c10.c
> > index cf93d36032e1..b36da75d7dfa 100644
> > --- a/drivers/media/i2c/ov02c10.c
> > +++ b/drivers/media/i2c/ov02c10.c
> > @@ -18,8 +18,8 @@
> >   #define OV02C10_MCLK			19200000
> >   #define OV02C10_RGB_DEPTH		10
> > -#define OV02C10_REG_CHIP_ID		CCI_REG16(0x300a)
> > -#define OV02C10_CHIP_ID			0x5602
> > +#define OV02C10_REG_CHIP_ID		CCI_REG24(0x300a)
> > +#define OV02C10_CHIP_ID			0x560243
> >   #define OV02C10_REG_STREAM_CONTROL	CCI_REG8(0x0100)
> 
> can you please start review of this trivial and long-standing change?
> 
> Thank you in advance.

Thanks for the ping. I've queued it for 7.4.

-- 
Kind regards,

Sakari Ailus

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2026-09-29 12:02 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-21 14:58 [PATCH] media: i2c: ov02c10: Narrow chip id check down to match ov02c chips only Vladimir Zapolskiy
2026-06-22  6:00 ` Tarang Raval
2026-09-08 13:12 ` Vladimir Zapolskiy
2026-09-29  7:58 ` Vladimir Zapolskiy
2026-09-29 12:02   ` Sakari Ailus

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.