All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicolas Dufresne <nicolas.dufresne@collabora.com>
To: Detlev Casanova <detlev.casanova@collabora.com>,
	Daniel Almeida	 <daniel.almeida@collabora.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Masami Hiramatsu <mhiramat@kernel.org>,
	Mathieu Desnoyers	 <mathieu.desnoyers@efficios.com>,
	Benjamin Gaignard	 <benjamin.gaignard@collabora.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	 Heiko Stuebner	 <heiko@sntech.de>
Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
	 linux-trace-kernel@vger.kernel.org,
	linux-rockchip@lists.infradead.org,
	 linux-arm-kernel@lists.infradead.org, kernel@collabora.com
Subject: Re: [PATCH v2 0/9] v4l2: Add tracing for stateless codecs
Date: Tue, 17 Nov 2026 17:08:30 -0500	[thread overview]
Message-ID: <fa76c2a0093bc0c75702dcdbfacbf0b2adc8ad9c.camel@collabora.com> (raw)
In-Reply-To: <20260610-v4l2-add-ftrace-v2-0-9756edf72ac1@collabora.com>

[-- Attachment #1: Type: text/plain, Size: 4311 bytes --]

Hi,

Le mercredi 10 juin 2026 à 10:33 -0400, Detlev Casanova a écrit :
> Hi !
> 
> This patchset aims to improve codec event tracing in v4l2.
> 
> The traces added in visl by Daniel Almeida are moved to the global trace
> events.
> They are adapted to trace each each field separately and not just the
> whole struct so that userspace can filter on different fields and
> libraries like libtracefs and libtraceevent can be used to list the
> fields instead of parsing the trace printk's.
> 
> The trace event templates are also reworked to avoid long lines, but
> quoted string splits are kept as they don't cut words.
> 
> To each trace event are also added a tgid and fd fields, helping
> userspace track different decoding sessions (contexts) based on the given
> file descriptor used by the given process id.
> 
> Also for better tracking, stream on and stream off events are added as
> well as HW run and HW done events to track decoder core usage.
> 
> The main focus is to be able to generate perfetto traces to show VPU usage,
> a perfetto producer using this can be found at [1] (it will be renamed to
> match the more generic approach than hantro).
> Other controls can be traced later as well, this patch set only focuses on
> mem2mem type drivers.

This is getting old, can you rebase and fix all the checkpatch and smatch issue.
There might be some build issues too?

https://gitlab.freedesktop.org/linux-media/users/patchwork/-/pipelines/1683571/

cheers,
Nicolas

> 
> [1]:
> https://gitlab.collabora.com/detlev/hantro-perf/-/tree/hantro-improved-info
> 
> Changes since v1:
> - Don't modify the printk format
> - Trace all fields of the structs instead of the whole struct as a buffer
> - Remove fdinfo patches (they will come in another patch set)
> - Fix long lines
> - Rename v4l2_requests.h trace header to v4l2_controls.h
> - Add basic documentation
> 
> Signed-off-by: Detlev Casanova <detlev.casanova@collabora.com>
> ---
> Detlev Casanova (9):
>       media: Move visl traces to v4l2-core
>       media: Map each struct field to its own trace field
>       media: Add tgid and fd fields in v4l2_fh struct
>       media: Add tgid and fd to the v4l2-requests trace fields
>       media: Add missing types to v4l2_ctrl_ptr
>       media: Trace the stateless controls when set in v4l2-ctrls-core.c
>       media: Add stream on/off traces and run them in the ioctl
>       media: Add HW run/done trace events
>       media: hantro: Add v4l2_hw run/done traces
> 
>  drivers/media/platform/verisilicon/hantro.h        |    1 +
>  drivers/media/platform/verisilicon/hantro_drv.c    |   10 +
>  .../platform/verisilicon/rockchip_vpu981_regs.h    |    1 +
>  .../media/platform/verisilicon/rockchip_vpu_hw.c   |    4 +
>  drivers/media/test-drivers/visl/Makefile           |    2 +-
>  drivers/media/test-drivers/visl/visl-dec.c         |   76 -
>  drivers/media/test-drivers/visl/visl-trace-av1.h   |  314 ---
>  drivers/media/test-drivers/visl/visl-trace-fwht.h  |   66 -
>  drivers/media/test-drivers/visl/visl-trace-h264.h  |  349 ---
>  drivers/media/test-drivers/visl/visl-trace-hevc.h  |  464 ----
>  drivers/media/test-drivers/visl/visl-trace-mpeg2.h |   99 -
>  .../media/test-drivers/visl/visl-trace-points.c    |   11 -
>  drivers/media/test-drivers/visl/visl-trace-vp8.h   |  156 --
>  drivers/media/test-drivers/visl/visl-trace-vp9.h   |  292 ---
>  drivers/media/v4l2-core/v4l2-ctrls-api.c           |   10 +
>  drivers/media/v4l2-core/v4l2-ctrls-core.c          |  114 +
>  drivers/media/v4l2-core/v4l2-fh.c                  |    1 +
>  drivers/media/v4l2-core/v4l2-ioctl.c               |   37 +-
>  drivers/media/v4l2-core/v4l2-trace.c               |   48 +
>  include/media/v4l2-ctrls.h                         |   19 +
>  include/media/v4l2-fh.h                            |    4 +
>  include/trace/events/v4l2.h                        |   77 +
>  include/trace/events/v4l2_controls.h               | 2708 ++++++++++++++++++++
>  23 files changed, 3033 insertions(+), 1830 deletions(-)
> ---
> base-commit: acb7500801e98639f6d8c2d796ed9f64cba83d3a
> change-id: 20260608-v4l2-add-ftrace-aec6e7f60a6c
> 
> Best regards,
> --  
> Detlev Casanova <detlev.casanova@collabora.com>
> 

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Dufresne <nicolas.dufresne@collabora.com>
To: Detlev Casanova <detlev.casanova@collabora.com>,
	Daniel Almeida	 <daniel.almeida@collabora.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Masami Hiramatsu <mhiramat@kernel.org>,
	Mathieu Desnoyers	 <mathieu.desnoyers@efficios.com>,
	Benjamin Gaignard	 <benjamin.gaignard@collabora.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	 Heiko Stuebner	 <heiko@sntech.de>
Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
	 linux-trace-kernel@vger.kernel.org,
	linux-rockchip@lists.infradead.org,
	 linux-arm-kernel@lists.infradead.org, kernel@collabora.com
Subject: Re: [PATCH v2 0/9] v4l2: Add tracing for stateless codecs
Date: Tue, 17 Nov 2026 17:08:30 -0500	[thread overview]
Message-ID: <fa76c2a0093bc0c75702dcdbfacbf0b2adc8ad9c.camel@collabora.com> (raw)
In-Reply-To: <20260610-v4l2-add-ftrace-v2-0-9756edf72ac1@collabora.com>


[-- Attachment #1.1: Type: text/plain, Size: 4311 bytes --]

Hi,

Le mercredi 10 juin 2026 à 10:33 -0400, Detlev Casanova a écrit :
> Hi !
> 
> This patchset aims to improve codec event tracing in v4l2.
> 
> The traces added in visl by Daniel Almeida are moved to the global trace
> events.
> They are adapted to trace each each field separately and not just the
> whole struct so that userspace can filter on different fields and
> libraries like libtracefs and libtraceevent can be used to list the
> fields instead of parsing the trace printk's.
> 
> The trace event templates are also reworked to avoid long lines, but
> quoted string splits are kept as they don't cut words.
> 
> To each trace event are also added a tgid and fd fields, helping
> userspace track different decoding sessions (contexts) based on the given
> file descriptor used by the given process id.
> 
> Also for better tracking, stream on and stream off events are added as
> well as HW run and HW done events to track decoder core usage.
> 
> The main focus is to be able to generate perfetto traces to show VPU usage,
> a perfetto producer using this can be found at [1] (it will be renamed to
> match the more generic approach than hantro).
> Other controls can be traced later as well, this patch set only focuses on
> mem2mem type drivers.

This is getting old, can you rebase and fix all the checkpatch and smatch issue.
There might be some build issues too?

https://gitlab.freedesktop.org/linux-media/users/patchwork/-/pipelines/1683571/

cheers,
Nicolas

> 
> [1]:
> https://gitlab.collabora.com/detlev/hantro-perf/-/tree/hantro-improved-info
> 
> Changes since v1:
> - Don't modify the printk format
> - Trace all fields of the structs instead of the whole struct as a buffer
> - Remove fdinfo patches (they will come in another patch set)
> - Fix long lines
> - Rename v4l2_requests.h trace header to v4l2_controls.h
> - Add basic documentation
> 
> Signed-off-by: Detlev Casanova <detlev.casanova@collabora.com>
> ---
> Detlev Casanova (9):
>       media: Move visl traces to v4l2-core
>       media: Map each struct field to its own trace field
>       media: Add tgid and fd fields in v4l2_fh struct
>       media: Add tgid and fd to the v4l2-requests trace fields
>       media: Add missing types to v4l2_ctrl_ptr
>       media: Trace the stateless controls when set in v4l2-ctrls-core.c
>       media: Add stream on/off traces and run them in the ioctl
>       media: Add HW run/done trace events
>       media: hantro: Add v4l2_hw run/done traces
> 
>  drivers/media/platform/verisilicon/hantro.h        |    1 +
>  drivers/media/platform/verisilicon/hantro_drv.c    |   10 +
>  .../platform/verisilicon/rockchip_vpu981_regs.h    |    1 +
>  .../media/platform/verisilicon/rockchip_vpu_hw.c   |    4 +
>  drivers/media/test-drivers/visl/Makefile           |    2 +-
>  drivers/media/test-drivers/visl/visl-dec.c         |   76 -
>  drivers/media/test-drivers/visl/visl-trace-av1.h   |  314 ---
>  drivers/media/test-drivers/visl/visl-trace-fwht.h  |   66 -
>  drivers/media/test-drivers/visl/visl-trace-h264.h  |  349 ---
>  drivers/media/test-drivers/visl/visl-trace-hevc.h  |  464 ----
>  drivers/media/test-drivers/visl/visl-trace-mpeg2.h |   99 -
>  .../media/test-drivers/visl/visl-trace-points.c    |   11 -
>  drivers/media/test-drivers/visl/visl-trace-vp8.h   |  156 --
>  drivers/media/test-drivers/visl/visl-trace-vp9.h   |  292 ---
>  drivers/media/v4l2-core/v4l2-ctrls-api.c           |   10 +
>  drivers/media/v4l2-core/v4l2-ctrls-core.c          |  114 +
>  drivers/media/v4l2-core/v4l2-fh.c                  |    1 +
>  drivers/media/v4l2-core/v4l2-ioctl.c               |   37 +-
>  drivers/media/v4l2-core/v4l2-trace.c               |   48 +
>  include/media/v4l2-ctrls.h                         |   19 +
>  include/media/v4l2-fh.h                            |    4 +
>  include/trace/events/v4l2.h                        |   77 +
>  include/trace/events/v4l2_controls.h               | 2708 ++++++++++++++++++++
>  23 files changed, 3033 insertions(+), 1830 deletions(-)
> ---
> base-commit: acb7500801e98639f6d8c2d796ed9f64cba83d3a
> change-id: 20260608-v4l2-add-ftrace-aec6e7f60a6c
> 
> Best regards,
> --  
> Detlev Casanova <detlev.casanova@collabora.com>
> 

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 170 bytes --]

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

  parent reply	other threads:[~2026-11-17 22:08 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-10 14:33 [PATCH v2 0/9] v4l2: Add tracing for stateless codecs Detlev Casanova
2026-06-10 14:33 ` Detlev Casanova
2026-06-10 14:33 ` [PATCH v2 1/9] media: Move visl traces to v4l2-core Detlev Casanova
2026-06-10 14:33   ` Detlev Casanova
2026-06-10 14:33 ` [PATCH v2 2/9] media: Map each struct field to its own trace field Detlev Casanova
2026-06-10 14:33   ` Detlev Casanova
2026-06-10 14:33 ` [PATCH v2 3/9] media: Add tgid and fd fields in v4l2_fh struct Detlev Casanova
2026-06-10 14:33   ` Detlev Casanova
2026-06-10 14:33 ` [PATCH v2 4/9] media: Add tgid and fd to the v4l2-requests trace fields Detlev Casanova
2026-06-10 14:33   ` Detlev Casanova
2026-06-10 14:33 ` [PATCH v2 5/9] media: Add missing types to v4l2_ctrl_ptr Detlev Casanova
2026-06-10 14:33   ` Detlev Casanova
2026-06-10 14:33 ` [PATCH v2 6/9] media: Trace the stateless controls when set in v4l2-ctrls-core.c Detlev Casanova
2026-06-10 14:33   ` Detlev Casanova
2026-06-10 14:33 ` [PATCH v2 7/9] media: Add stream on/off traces and run them in the ioctl Detlev Casanova
2026-06-10 14:33   ` Detlev Casanova
2026-06-10 14:33 ` [PATCH v2 8/9] media: Add HW run/done trace events Detlev Casanova
2026-06-10 14:33   ` Detlev Casanova
2026-06-10 14:33 ` [PATCH v2 9/9] media: hantro: Add v4l2_hw run/done traces Detlev Casanova
2026-06-10 14:33   ` Detlev Casanova
2026-11-17 22:08 ` Nicolas Dufresne [this message]
2026-11-17 22:08   ` [PATCH v2 0/9] v4l2: Add tracing for stateless codecs Nicolas Dufresne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fa76c2a0093bc0c75702dcdbfacbf0b2adc8ad9c.camel@collabora.com \
    --to=nicolas.dufresne@collabora.com \
    --cc=benjamin.gaignard@collabora.com \
    --cc=daniel.almeida@collabora.com \
    --cc=detlev.casanova@collabora.com \
    --cc=heiko@sntech.de \
    --cc=kernel@collabora.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mchehab@kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.