From: "Abdul Rahim, Faizal" <faizal.abdul.rahim@linux.intel.com>
To: Simon Horman <horms@kernel.org>
Cc: Vinicius Costa Gomes <vinicius.gomes@intel.com>,
intel-wired-lan@lists.osuosl.org, stable@vger.kernel.org,
linux-kernel@vger.kernel.org, Eric Dumazet <edumazet@google.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
netdev@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
"David S . Miller" <davem@davemloft.net>
Subject: Re: [Intel-wired-lan] [PATCH iwl-net v1 3/4] igc: Remove unused qbv_count
Date: Sat, 6 Jul 2024 00:47:20 +0800 [thread overview]
Message-ID: <faabc72b-b421-48c7-93cb-b2fe65655989@linux.intel.com> (raw)
In-Reply-To: <20240703151008.GP598357@kernel.org>
On 3/7/2024 11:10 pm, Simon Horman wrote:
> On Tue, Jul 02, 2024 at 12:09:25AM -0400, Faizal Rahim wrote:
>> Removing qbv_count which is now obsolete after these 2 patches:
>> "igc: Fix reset adapter logics when tx mode change"
>> "igc: Fix qbv_config_change_errors logics"
>>
>> The variable qbv_count serves to indicate whether Taprio is active or if
>> the tx mode is in TSN (IGC_TQAVCTRL_TRANSMIT_MODE_TSN). This is due to its
>> unconditional increment within igc_tsn_enable_offload(), which both runs
>> Taprio and sets the tx mode to TSN.
>>
>> Signed-off-by: Faizal Rahim <faizal.abdul.rahim@linux.intel.com>
>
> Hi Faizal,
>
> This change looks good to me.
> However, it seems more appropriate as a clean-up for iwl-next
> once the previous to patches make it there via iwl-net.
>
> That notwithstanding,
>
> Reviewed-by: Simon Horman <horms@kernel.org>
>
> ...
Got it, will do that.
Thanks.
WARNING: multiple messages have this Message-ID (diff)
From: "Abdul Rahim, Faizal" <faizal.abdul.rahim@linux.intel.com>
To: Simon Horman <horms@kernel.org>
Cc: "David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
Vinicius Costa Gomes <vinicius.gomes@intel.com>,
intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH iwl-net v1 3/4] igc: Remove unused qbv_count
Date: Sat, 6 Jul 2024 00:47:20 +0800 [thread overview]
Message-ID: <faabc72b-b421-48c7-93cb-b2fe65655989@linux.intel.com> (raw)
In-Reply-To: <20240703151008.GP598357@kernel.org>
On 3/7/2024 11:10 pm, Simon Horman wrote:
> On Tue, Jul 02, 2024 at 12:09:25AM -0400, Faizal Rahim wrote:
>> Removing qbv_count which is now obsolete after these 2 patches:
>> "igc: Fix reset adapter logics when tx mode change"
>> "igc: Fix qbv_config_change_errors logics"
>>
>> The variable qbv_count serves to indicate whether Taprio is active or if
>> the tx mode is in TSN (IGC_TQAVCTRL_TRANSMIT_MODE_TSN). This is due to its
>> unconditional increment within igc_tsn_enable_offload(), which both runs
>> Taprio and sets the tx mode to TSN.
>>
>> Signed-off-by: Faizal Rahim <faizal.abdul.rahim@linux.intel.com>
>
> Hi Faizal,
>
> This change looks good to me.
> However, it seems more appropriate as a clean-up for iwl-next
> once the previous to patches make it there via iwl-net.
>
> That notwithstanding,
>
> Reviewed-by: Simon Horman <horms@kernel.org>
>
> ...
Got it, will do that.
Thanks.
next prev parent reply other threads:[~2024-07-05 16:47 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-02 4:09 [Intel-wired-lan] [PATCH iwl-net v1 0/4] igc bug fixes related to qbv_count usage Faizal Rahim
2024-07-02 4:09 ` Faizal Rahim
2024-07-02 4:09 ` [Intel-wired-lan] [PATCH iwl-net v1 1/4] igc: Fix qbv_config_change_errors logics Faizal Rahim
2024-07-02 4:09 ` Faizal Rahim
2024-07-02 4:16 ` [Intel-wired-lan] " kernel test robot
2024-07-03 15:08 ` Simon Horman
2024-07-03 15:08 ` Simon Horman
2024-07-05 16:58 ` [Intel-wired-lan] " Abdul Rahim, Faizal
2024-07-05 16:58 ` Abdul Rahim, Faizal
2024-07-02 4:09 ` [Intel-wired-lan] [PATCH iwl-net v1 2/4] igc: Fix reset adapter logics when tx mode change Faizal Rahim
2024-07-02 4:09 ` Faizal Rahim
2024-07-03 15:03 ` [Intel-wired-lan] " Simon Horman
2024-07-03 15:03 ` Simon Horman
2024-07-05 16:52 ` [Intel-wired-lan] " Abdul Rahim, Faizal
2024-07-05 16:52 ` Abdul Rahim, Faizal
2024-07-02 4:09 ` [Intel-wired-lan] [PATCH iwl-net v1 3/4] igc: Remove unused qbv_count Faizal Rahim
2024-07-02 4:09 ` Faizal Rahim
2024-07-03 15:10 ` [Intel-wired-lan] " Simon Horman
2024-07-03 15:10 ` Simon Horman
2024-07-05 16:47 ` Abdul Rahim, Faizal [this message]
2024-07-05 16:47 ` Abdul Rahim, Faizal
2024-07-02 4:09 ` [Intel-wired-lan] [PATCH iwl-net v1 4/4] igc: Fix qbv tx latency by setting gtxoffset Faizal Rahim
2024-07-02 4:09 ` Faizal Rahim
2024-07-03 15:10 ` [Intel-wired-lan] " Simon Horman
2024-07-03 15:10 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=faabc72b-b421-48c7-93cb-b2fe65655989@linux.intel.com \
--to=faizal.abdul.rahim@linux.intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
--cc=vinicius.gomes@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.