From: Gang Li <gang.li@linux.dev>
To: Tim Chen <tim.c.chen@linux.intel.com>
Cc: linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
Mike Kravetz <mike.kravetz@oracle.com>,
linux-kernel@vger.kernel.org,
David Rientjes <rientjes@google.com>,
David Hildenbrand <david@redhat.com>,
ligang.bdlg@bytedance.com, Muchun Song <muchun.song@linux.dev>,
Gang Li <gang.li@linux.dev>
Subject: Re: [PATCH v3 2/7] hugetlb: split hugetlb_hstate_alloc_pages
Date: Thu, 11 Jan 2024 11:44:46 +0800 [thread overview]
Message-ID: <fb688bd2-f669-4407-b7c0-d50da7df7118@linux.dev> (raw)
In-Reply-To: <9b95c0ac0e5d560f1482af3753df54211a057b9d.camel@linux.intel.com>
On 2024/1/11 07:12, Tim Chen wrote:
> On Tue, 2024-01-02 at 21:12 +0800, Gang Li wrote:
>> +static unsigned long __init hugetlb_hstate_alloc_pages_gigantic(struct hstate *h)
>> +{
>> + unsigned long i;
>> +
>> + for (i = 0; i < h->max_huge_pages; ++i) {
>> + /*
>> + * gigantic pages not added to list as they are not
>> + * added to pools now.
>> + */
>
> This comment unnecessary as now we don't have mix gigantic and non-gigantic code,
> which uses foilio list. And folio_list is not in this routine.
>
> Can be removed.
>
> Otherwise Reviewed-by: Tim Chen <tim.c.chen@linux.intel.com>
>
Thanks!
next prev parent reply other threads:[~2024-01-11 3:44 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-02 13:12 [PATCH v3 0/7] hugetlb: parallelize hugetlb page init on boot Gang Li
2024-01-02 13:12 ` [PATCH v3 1/7] hugetlb: code clean for hugetlb_hstate_alloc_pages Gang Li
2024-01-10 10:19 ` Muchun Song
2024-01-11 3:30 ` Gang Li
2024-01-10 21:55 ` Tim Chen
2024-01-11 3:34 ` Gang Li
2024-01-02 13:12 ` [PATCH v3 2/7] hugetlb: split hugetlb_hstate_alloc_pages Gang Li
2024-01-10 23:12 ` Tim Chen
2024-01-11 3:44 ` Gang Li [this message]
2024-01-16 7:02 ` Muchun Song
2024-01-16 8:09 ` Gang Li
2024-01-02 13:12 ` [PATCH v3 3/7] padata: dispatch works on different nodes Gang Li
2024-01-11 17:50 ` Tim Chen
2024-01-12 7:09 ` Gang Li
2024-01-12 18:27 ` Tim Chen
2024-01-15 8:57 ` Gang Li
2024-01-17 22:14 ` Tim Chen
2024-01-18 6:15 ` Gang Li
2024-01-02 13:12 ` [PATCH v3 4/7] hugetlb: pass *next_nid_to_alloc directly to for_each_node_mask_to_alloc Gang Li
2024-01-03 1:32 ` David Rientjes
2024-01-03 2:22 ` Gang Li
2024-01-03 2:36 ` David Rientjes
2024-01-11 22:21 ` Tim Chen
2024-01-12 8:07 ` Gang Li
2024-01-02 13:12 ` [PATCH v3 5/7] hugetlb: have CONFIG_HUGETLBFS select CONFIG_PADATA Gang Li
2024-01-11 22:49 ` Tim Chen
2024-01-16 9:26 ` Muchun Song
2024-01-02 13:12 ` [PATCH v3 6/7] hugetlb: parallelize 2M hugetlb allocation and initialization Gang Li
2024-01-02 13:12 ` [PATCH v3 7/7] hugetlb: parallelize 1G hugetlb initialization Gang Li
2024-01-03 1:52 ` [PATCH v3 0/7] hugetlb: parallelize hugetlb page init on boot David Rientjes
2024-01-03 2:20 ` Gang Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb688bd2-f669-4407-b7c0-d50da7df7118@linux.dev \
--to=gang.li@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=ligang.bdlg@bytedance.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=muchun.song@linux.dev \
--cc=rientjes@google.com \
--cc=tim.c.chen@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.