Re: [PATCH v5 01/17] spi: dt-bindings: add spi-max-post-config-frequency-hz property

From: Krzysztof Kozlowski <krzk@kernel.org>
To: Santhosh Kumar K <s-k6@ti.com>
Cc: broonie@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, miquel.raynal@bootlin.com, richard@nod.at,
	vigneshr@ti.com, pratyush@kernel.org, mwalle@kernel.org,
	takahiro.kuwano@infineon.com, linux-spi@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-mtd@lists.infradead.org, praneeth@ti.com, u-kumar1@ti.com,
	a-dutta@ti.com, Conor Dooley <conor.dooley@microchip.com>
Subject: Re: [PATCH v5 01/17] spi: dt-bindings: add spi-max-post-config-frequency-hz property
Date: Mon, 20 Jul 2026 09:40:49 +0200	[thread overview]
Message-ID: <fba1531e-e416-4817-848e-94e9b3f3b501@kernel.org> (raw)
In-Reply-To: <3d470ec8-870a-4e14-90e8-6c7444950192@ti.com>

On 20/07/2026 09:38, Santhosh Kumar K wrote:
>>> diff --git a/Documentation/devicetree/bindings/spi/spi-peripheral-props.yaml b/Documentation/devicetree/bindings/spi/spi-peripheral-props.yaml
>>> index 880a9f624566..12211f8c9f7d 100644
>>> --- a/Documentation/devicetree/bindings/spi/spi-peripheral-props.yaml
>>> +++ b/Documentation/devicetree/bindings/spi/spi-peripheral-props.yaml
>>> @@ -45,6 +45,11 @@ properties:
>>>       description:
>>>         Maximum SPI clocking speed of the device in Hz.
>>>   
>>> +  spi-max-post-config-frequency-hz:
>>> +    description:
>>> +      Maximum SPI clock frequency in Hz achievable after controller-side
>>> +      configuration.
>>
>> How did you implement my feedback?
> 
> Three points from your feedback:
> 
> 1. -hz suffix: added
> 
> 2. Array property: I still lean towards keeping this as a scalar for
> now, as we don't have a concrete use case for multiple values today, and
> supporting two frequencies should be sufficient for the foreseeable
> future. I had responded to this in the v4 discussion as well, you may
> have missed that response.
> 
> 3. maxItems: Since the property remains a scalar, I have not added maxItems.

So how did you make this property scalar?

Best regards,
Krzysztof