From: "Nautiyal, Ankit K" <ankit.k.nautiyal@intel.com>
To: Eriksen Xie <xiaolu.xie@intel.com>,
<intel-gfx@lists.freedesktop.org>,
<intel-xe@lists.freedesktop.org>
Cc: "Chaitanya Kumar Borah" <chaitanya.kumar.borah@intel.com>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
"Suraj Kandpal" <suraj.kandpal@intel.com>
Subject: Re: [PATCH] drm/i915/dip: Clear VSC_SELECT before setting it
Date: Thu, 19 Nov 2026 07:54:18 +0530 [thread overview]
Message-ID: <fba24224-e42f-473d-8e9d-801ba183849b@intel.com> (raw)
In-Reply-To: <20261118131441.2023100-1-xiaolu.xie@intel.com>
On 11/18/2026 6:44 PM, Eriksen Xie wrote:
> VSC_SELECT in VIDEO_DIP_CTL is a two bit field selecting whether the
> header and the data of the VSC SDP are generated by the hardware or
> taken from the DIP data registers. hsw_write_infoframe() ORs
> VSC_DIP_HW_DATA_SW_HEA into the value read back from the register
> without clearing the field first, so a different value left in it,
> e.g. by the firmware, isn't replaced but combined with the new one
> (VSC_DIP_HW_HEA_SW_DATA | VSC_DIP_HW_DATA_SW_HEA results in
> VSC_DIP_SW_HEA_DATA).
>
> Clear the field before setting it.
>
> Signed-off-by: Eriksen Xie <xiaolu.xie@intel.com>
LGTM.
Sashiko suggested a 'Fixes' tag, but I don't think it's needed here, as
there is no known bug.
The driver doesn't accidentally change this bit, and any leftover state
would just be from GOP/BIOS programming, which hasn't caused issues.
Keeping the tag off avoids unnecessary stable backport churn.
Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Regards,
Ankit
> ---
>
> This was split out of my earlier patch [1], as suggested by Ankit in the
> review of Chaitanya's v2 [2]. It doesn't depend on that patch and applies
> with or without it.
>
> There is no report of a stale VSC_SELECT value on actual hardware, the
> issue follows from the field being only ORed into.
>
> [1] https://patchwork.freedesktop.org/patch/763779/
> [2] https://lists.freedesktop.org/archives/intel-gfx/2026-November/400881.html
>
> drivers/gpu/drm/i915/display/intel_hdmi.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c
> index 4ec0db8d93..14dacbb58a 100644
> --- a/drivers/gpu/drm/i915/display/intel_hdmi.c
> +++ b/drivers/gpu/drm/i915/display/intel_hdmi.c
> @@ -552,8 +552,10 @@ void hsw_write_infoframe(struct intel_encoder *encoder,
> !crtc_state->has_panel_replay && type == DP_SDP_VSC))
> val |= hsw_infoframe_enable(type);
>
> - if (type == DP_SDP_VSC)
> + if (type == DP_SDP_VSC) {
> + val &= ~VSC_SELECT_MASK;
> val |= VSC_DIP_HW_DATA_SW_HEA;
> + }
>
> intel_de_write(display, ctl_reg, val);
> intel_de_posting_read(display, ctl_reg);
next prev parent reply other threads:[~2026-11-19 2:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 13:14 [PATCH] drm/i915/dip: Clear VSC_SELECT before setting it Eriksen Xie
2026-11-18 13:21 ` sashiko-bot
2026-11-18 15:30 ` ✓ CI.KUnit: success for " Patchwork
2026-11-18 16:06 ` ✓ Xe.CI.BAT: " Patchwork
2026-11-18 22:27 ` ✓ i915.CI.BAT: " Patchwork
2026-11-19 2:24 ` Nautiyal, Ankit K [this message]
2026-11-19 5:45 ` ✓ i915.CI.Full: " Patchwork
2026-11-19 8:17 ` ✗ Xe.CI.FULL: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fba24224-e42f-473d-8e9d-801ba183849b@intel.com \
--to=ankit.k.nautiyal@intel.com \
--cc=chaitanya.kumar.borah@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=suraj.kandpal@intel.com \
--cc=ville.syrjala@linux.intel.com \
--cc=xiaolu.xie@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.