All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Eriksen Xie" <xiaolu.xie@intel.com>,
	intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/dip: Clear VSC_SELECT before setting it
Date: Wed, 18 Nov 2026 13:21:43 +0000	[thread overview]
Message-ID: <sashiko-outbox-221003@kernel.org> (raw)
In-Reply-To: <20261118131441.2023100-1-xiaolu.xie@intel.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] drm/i915/dip: missing Fixes trailer for VSC_SELECT in
  hsw_write_infoframe()
--

commit f244e26161b0f3b5713588fd3abc78616009d0e8
Author: Eriksen Xie <xiaolu.xie@intel.com>

> drm/i915/dip: Clear VSC_SELECT before setting it
>
> VSC_SELECT in VIDEO_DIP_CTL is a two bit field selecting whether the
> header and the data of the VSC SDP are generated by the hardware or
> taken from the DIP data registers. hsw_write_infoframe() ORs
> VSC_DIP_HW_DATA_SW_HEA into the value read back from the register
> without clearing the field first, so a different value left in it,
> e.g. by the firmware, isn't replaced but combined with the new one
> (VSC_DIP_HW_HEA_SW_DATA | VSC_DIP_HW_DATA_SW_HEA results in
> VSC_DIP_SW_HEA_DATA).
>
> Clear the field before setting it.
>
> Signed-off-by: Eriksen Xie <xiaolu.xie@intel.com>

[Severity: Low]
This fixes the unmasked VSC_SELECT bitfield update in
hsw_write_infoframe().  Should this include:

  Fixes: bac2d7d8e64b ("drm/i915/display: Take care of VSC select field in video dip ctl register")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261118131441.2023100-1-xiaolu.xie@intel.com?part=1

  reply	other threads:[~2026-11-18 13:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18 13:14 [PATCH] drm/i915/dip: Clear VSC_SELECT before setting it Eriksen Xie
2026-11-18 13:21 ` sashiko-bot [this message]
2026-11-18 15:30 ` ✓ CI.KUnit: success for " Patchwork
2026-11-18 16:06 ` ✓ Xe.CI.BAT: " Patchwork
2026-11-18 22:27 ` ✓ i915.CI.BAT: " Patchwork
2026-11-19  2:24 ` [PATCH] " Nautiyal, Ankit K
2026-11-19  5:45 ` ✓ i915.CI.Full: success for " Patchwork
2026-11-19  8:17 ` ✗ Xe.CI.FULL: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-221003@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=xiaolu.xie@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.