[PATCH] drm/amd/display: Add a new DC debug mask for PSR-SU

[PATCH] drm/amd/display: Add a new DC debug mask for PSR-SU

[Mario Limonciello]

Some issues have been raised that appear to be tied to PSR-SU.
To allow users to confirm they're tied to PSR-SU without turning off
PSR entirely introduce a new debug mask:

amdgpu.dcdebugmask=0x200

Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c | 3 +++
 drivers/gpu/drm/amd/include/amd_shared.h              | 1 +
 2 files changed, 4 insertions(+)

diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c
index 08ce3bb8f640..1f08c6564c3b 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c
@@ -51,6 +51,9 @@ static bool link_supports_psrsu(struct dc_link *link)
 	    !link->dpcd_caps.psr_info.psr2_su_y_granularity_cap)
 		return false;
 
+	if (amdgpu_dc_debug_mask & DC_DISABLE_PSR_SU)
+		return false;
+
 	return dc_dmub_check_min_version(dc->ctx->dmub_srv->dmub);
 }
 
diff --git a/drivers/gpu/drm/amd/include/amd_shared.h b/drivers/gpu/drm/amd/include/amd_shared.h
index ade68972ec28..5cad456f2e10 100644
--- a/drivers/gpu/drm/amd/include/amd_shared.h
+++ b/drivers/gpu/drm/amd/include/amd_shared.h
@@ -256,6 +256,7 @@ enum DC_DEBUG_MASK {
 	DC_DISABLE_MPO = 0x40,
 	DC_ENABLE_DPIA_TRACE = 0x80,
 	DC_ENABLE_DML2 = 0x100,
+	DC_DISABLE_PSR_SU = 0x200,
 };
 
 enum amd_dpm_forced_level;
-- 
2.34.1

Re: [PATCH] drm/amd/display: Add a new DC debug mask for PSR-SU

[Harry Wentland]

On 2023-12-14 16:12, Mario Limonciello wrote:
> Some issues have been raised that appear to be tied to PSR-SU.
> To allow users to confirm they're tied to PSR-SU without turning off
> PSR entirely introduce a new debug mask:
> 
> amdgpu.dcdebugmask=0x200
> 
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>

Reviewed-by: Harry Wentland <harry.wentland@amd.com>

Harry

> ---
>  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c | 3 +++
>  drivers/gpu/drm/amd/include/amd_shared.h              | 1 +
>  2 files changed, 4 insertions(+)
> 
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c
> index 08ce3bb8f640..1f08c6564c3b 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c
> @@ -51,6 +51,9 @@ static bool link_supports_psrsu(struct dc_link *link)
>  	    !link->dpcd_caps.psr_info.psr2_su_y_granularity_cap)
>  		return false;
>  
> +	if (amdgpu_dc_debug_mask & DC_DISABLE_PSR_SU)
> +		return false;
> +
>  	return dc_dmub_check_min_version(dc->ctx->dmub_srv->dmub);
>  }
>  
> diff --git a/drivers/gpu/drm/amd/include/amd_shared.h b/drivers/gpu/drm/amd/include/amd_shared.h
> index ade68972ec28..5cad456f2e10 100644
> --- a/drivers/gpu/drm/amd/include/amd_shared.h
> +++ b/drivers/gpu/drm/amd/include/amd_shared.h
> @@ -256,6 +256,7 @@ enum DC_DEBUG_MASK {
>  	DC_DISABLE_MPO = 0x40,
>  	DC_ENABLE_DPIA_TRACE = 0x80,
>  	DC_ENABLE_DML2 = 0x100,
> +	DC_DISABLE_PSR_SU = 0x200,
>  };
>  
>  enum amd_dpm_forced_level;