All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Teres Alexis, Alan Previn" <alan.previn.teres.alexis@intel.com>
To: "Ceraolo Spurio, Daniele" <daniele.ceraolospurio@intel.com>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>
Cc: "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH v2 3/5] drm/i915/mtl/gsc: query the GSC FW for its compatibility version
Date: Thu, 8 Jun 2023 23:36:26 +0000	[thread overview]
Message-ID: <fbe6c03fc5ef0117aed23904c04dedf5410b796e.camel@intel.com> (raw)
In-Reply-To: <20230606022402.2048235-4-daniele.ceraolospurio@intel.com>

On Mon, 2023-06-05 at 19:24 -0700, Ceraolo Spurio, Daniele wrote:
> The compatibility version is queried via an MKHI command. Right now, the
> only existing interface is 1.0
> This is basically the interface version for the GSC FW, so the plan is
> to use it as the main tracked version, including for the binary naming
> in the fetch code.
> 
> v2: use define for the object size (Alan)
> 
> Cc: Alan Previn <alan.previn.teres.alexis@intel.com>
> Cc: John Harrison <John.C.Harrison@Intel.com>
> Reviewed-by: Alan Previn <alan.previn.teres.alexis@intel.com> #v1


Diff'd v1 vs v2 of this patch - differences are good. So my R'B still holds:
Reviewed-by: Alan Previn <alan.previn.teres.alexis@intel.com>

> ---


WARNING: multiple messages have this Message-ID (diff)
From: "Teres Alexis, Alan Previn" <alan.previn.teres.alexis@intel.com>
To: "Ceraolo Spurio, Daniele" <daniele.ceraolospurio@intel.com>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>
Cc: "Harrison, John C" <john.c.harrison@intel.com>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH v2 3/5] drm/i915/mtl/gsc: query the GSC FW for its compatibility version
Date: Thu, 8 Jun 2023 23:36:26 +0000	[thread overview]
Message-ID: <fbe6c03fc5ef0117aed23904c04dedf5410b796e.camel@intel.com> (raw)
In-Reply-To: <20230606022402.2048235-4-daniele.ceraolospurio@intel.com>

On Mon, 2023-06-05 at 19:24 -0700, Ceraolo Spurio, Daniele wrote:
> The compatibility version is queried via an MKHI command. Right now, the
> only existing interface is 1.0
> This is basically the interface version for the GSC FW, so the plan is
> to use it as the main tracked version, including for the binary naming
> in the fetch code.
> 
> v2: use define for the object size (Alan)
> 
> Cc: Alan Previn <alan.previn.teres.alexis@intel.com>
> Cc: John Harrison <John.C.Harrison@Intel.com>
> Reviewed-by: Alan Previn <alan.previn.teres.alexis@intel.com> #v1


Diff'd v1 vs v2 of this patch - differences are good. So my R'B still holds:
Reviewed-by: Alan Previn <alan.previn.teres.alexis@intel.com>

> ---


  reply	other threads:[~2023-06-08 23:36 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-06  2:23 [Intel-gfx] [PATCH v2 0/5] drm/i915: GSC FW support for MTL Daniele Ceraolo Spurio
2023-06-06  2:23 ` Daniele Ceraolo Spurio
2023-06-06  2:23 ` [Intel-gfx] [PATCH v2 1/5] drm/i915/gsc: fixes and updates for GSC memory allocation Daniele Ceraolo Spurio
2023-06-06  2:23   ` Daniele Ceraolo Spurio
2023-06-07 19:22   ` [Intel-gfx] " Teres Alexis, Alan Previn
2023-06-07 19:22     ` Teres Alexis, Alan Previn
2023-06-06  2:23 ` [Intel-gfx] [PATCH v2 2/5] drm/i915/mtl/gsc: extract release and security versions from the gsc binary Daniele Ceraolo Spurio
2023-06-06  2:23   ` Daniele Ceraolo Spurio
2023-06-08 21:51   ` [Intel-gfx] " Teres Alexis, Alan Previn
2023-06-08 21:51     ` Teres Alexis, Alan Previn
2023-06-06  2:24 ` [Intel-gfx] [PATCH v2 3/5] drm/i915/mtl/gsc: query the GSC FW for its compatibility version Daniele Ceraolo Spurio
2023-06-06  2:24   ` Daniele Ceraolo Spurio
2023-06-08 23:36   ` Teres Alexis, Alan Previn [this message]
2023-06-08 23:36     ` Teres Alexis, Alan Previn
2023-06-06  2:24 ` [Intel-gfx] [PATCH v2 4/5] drm/i915/mtl/gsc: Add a gsc_info debugfs Daniele Ceraolo Spurio
2023-06-06  2:24   ` Daniele Ceraolo Spurio
2023-06-06  4:32   ` [Intel-gfx] [PATCH v3] " Daniele Ceraolo Spurio
2023-06-06  4:32     ` Daniele Ceraolo Spurio
2023-06-07 21:23     ` [Intel-gfx] " Teres Alexis, Alan Previn
2023-06-07 21:23       ` Teres Alexis, Alan Previn
2023-06-06  6:49   ` [Intel-gfx] [PATCH v2 4/5] " kernel test robot
2023-06-06  6:49     ` kernel test robot
2023-06-06  7:21   ` kernel test robot
2023-06-06  7:21     ` kernel test robot
2023-06-06  8:04   ` kernel test robot
2023-06-06  8:04     ` kernel test robot
2023-06-06  8:26   ` kernel test robot
2023-06-06  8:26     ` kernel test robot
2023-06-06  2:24 ` [Intel-gfx] [PATCH v2 5/5] drm/i915/gsc: define gsc fw Daniele Ceraolo Spurio
2023-06-06  2:24   ` Daniele Ceraolo Spurio
2023-06-06  2:53 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915: GSC FW support for MTL (rev2) Patchwork
2023-06-06  5:32 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: GSC FW support for MTL (rev3) Patchwork
2023-06-06  5:32 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-06-06  5:42 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-06-07  0:17 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fbe6c03fc5ef0117aed23904c04dedf5410b796e.camel@intel.com \
    --to=alan.previn.teres.alexis@intel.com \
    --cc=daniele.ceraolospurio@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.