All of lore.kernel.org
 help / color / mirror / Atom feed
From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Greg Kurz <groug@kaod.org>, qemu-devel@nongnu.org
Cc: Stefan Hajnoczi <stefanha@redhat.com>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	Laurent Vivier <lvivier@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Yajun Wu <yajunw@nvidia.com>,
	Peter Maydell <peter.maydell@linaro.org>,
	Parav Pandit <parav@nvidia.com>,
	qemu-stable@nongnu.org
Subject: Re: [PATCH 2/2] Revert "vhost-user: Introduce nested event loop in vhost_user_read()"
Date: Fri, 20 Jan 2023 16:13:08 +0100	[thread overview]
Message-ID: <fbe712bb-a1cc-6f83-501a-8549e842f49d@redhat.com> (raw)
In-Reply-To: <20230119172424.478268-3-groug@kaod.org>



On 1/19/23 18:24, Greg Kurz wrote:
> This reverts commit a7f523c7d114d445c5d83aecdba3efc038e5a692.
> 
> The nested event loop is broken by design. It's only user was removed.
> Drop the code as well so that nobody ever tries to use it again.
> 
> I had to fix a couple of trivial conflicts around return values because
> of 025faa872bcf ("vhost-user: stick to -errno error return convention").
> 
> Signed-off-by: Greg Kurz <groug@kaod.org>
> ---
>   hw/virtio/vhost-user.c | 65 ++++--------------------------------------
>   1 file changed, 5 insertions(+), 60 deletions(-)
> 

Acked-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime



  reply	other threads:[~2023-01-20 15:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-19 17:24 [PATCH 0/2] vhost-user: Remove the nested event loop to unbreak the DPDK use case Greg Kurz
2023-01-19 17:24 ` [PATCH 1/2] Revert "vhost-user: Monitor slave channel in vhost_user_read()" Greg Kurz
2023-01-19 18:39   ` Greg Kurz
2023-01-19 21:10   ` Stefan Hajnoczi
2023-01-20 15:03   ` Maxime Coquelin
2023-01-19 17:24 ` [PATCH 2/2] Revert "vhost-user: Introduce nested event loop " Greg Kurz
2023-01-20 15:13   ` Maxime Coquelin [this message]
2023-01-23  8:21 ` [PATCH 0/2] vhost-user: Remove the nested event loop to unbreak the DPDK use case Greg Kurz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fbe712bb-a1cc-6f83-501a-8549e842f49d@redhat.com \
    --to=maxime.coquelin@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=groug@kaod.org \
    --cc=lvivier@redhat.com \
    --cc=mst@redhat.com \
    --cc=parav@nvidia.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=yajunw@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.