Re: [PATCH v4 3/5] pinctrl: Add driver support for Amlogic SoCs

From: Xianwei Zhao <xianwei.zhao@amlogic.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Kevin Hilman <khilman@baylibre.com>,
	Jerome Brunet <jbrunet@baylibre.com>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	Bartosz Golaszewski <brgl@bgdev.pl>,
	linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-amlogic@lists.infradead.org
Subject: Re: [PATCH v4 3/5] pinctrl: Add driver support for Amlogic SoCs
Date: Fri, 7 Feb 2025 15:07:27 +0800	[thread overview]
Message-ID: <fc2ee33d-db32-425f-ae5b-e56a15bc27e4@amlogic.com> (raw)
In-Reply-To: <CACRpkdZRbpd0Kw9V=aYX5P0vJLtErNR+aBzPagSwf=AZh6QERA@mail.gmail.com>

Hi Linus,
    Thanks for your reply.

On 2025/1/27 17:59, Linus Walleij wrote:
> [ EXTERNAL EMAIL ]
> 
> Hi Xianwei,
> 
> thanks for your patch!
> 
> On Wed, Jan 22, 2025 at 4:26 AM Xianwei Zhao via B4 Relay
> <devnull+xianwei.zhao.amlogic.com@kernel.org> wrote:
> 
>> From: Xianwei Zhao <xianwei.zhao@amlogic.com>
>>
>> Add a new pinctrl driver for Amlogic SoCs. All future Amlogic
>> SoCs pinctrl drives use this, such A4, A5, S6, S7 etc. To support
>> new Amlogic SoCs, only need to add the corresponding dts file.
>>
>> Signed-off-by: Xianwei Zhao <xianwei.zhao@amlogic.com>
>> ---
>>   drivers/pinctrl/Kconfig           |   18 +
>>   drivers/pinctrl/Makefile          |    1 +
>>   drivers/pinctrl/pinctrl-amlogic.c | 1053 +++++++++++++++++++++++++++++++++++++
> 
> Please move this file into drivers/pinctrl/meson as I requested
> earlier. We can rename "meson" to "amlogic" later if that placement
> is confusing.
> 

Will Move this file into drivers/pinctrl/meson in next version.

>> +config PINCTRL_AMLOGIC
> 
> There is already PINCTRL_AMLOGIC_C3 and PINCTRL_AMLOGIC_T7
> as will be very apparent when you move this driver.
> 
> What is a *proper* name for this family of SoCs?
> 

This is for A4, Will use PINCTRL_AMLOGIC_A4 instead.

>> +MODULE_LICENSE("Dual BSD/GPL");
> 
> On the top of the file you have:
>> +// SPDX-License-Identifier: GPL-2.0-only
> 
> So this does not add up. Fix one or the other.
> 

Will drop "MODULE_LICENSE("Dual BSD/GPL");".

> Yours,
> Linus Walleij

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic