[KJ] Re: [PATCH] typo patch on v850e_uart.c

[KJ] Re: [PATCH] typo patch on v850e_uart.c

[Miles Bader]

On 5/13/05, Christophe Lucas <clucas@rotomalug.org> wrote:
> Description:
> Little patch on typo problem.

I'm confused -- your patch appears to simply remove a blank line.

The blank line it removes is not a typo, it was put there intentionally.

-Miles
-- 
Do not taunt Happy Fun Ball.

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

[KJ] Re: [PATCH] typo patch on v850e_uart.c

[Miles Bader]

[-- Attachment #1: Type: text/plain, Size: 574 bytes --]

Miles Bader <snogglethorpe@gmail.com> writes:
>> Description:
>> Little patch on typo problem.
>
> I'm confused -- your patch appears to simply remove a blank line.
>
> The blank line it removes is not a typo, it was put there intentionally.

Oh, I see it actually removes a blank line which contains a form-feed
character.  Same difference though:  it isn't a typo.

-Miles
-- 
`Cars give people wonderful freedom and increase their opportunities.
 But they also destroy the environment, to an extent so drastic that
 they kill all social life' (from _A Pattern Language_)

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

[KJ] Re: [PATCH] typo patch on v850e_uart.c

[Christophe Lucas]

[-- Attachment #1: Type: text/plain, Size: 511 bytes --]

Miles Bader (snogglethorpe@gmail.com) wrote:
> On 5/13/05, Christophe Lucas <clucas@rotomalug.org> wrote:
> > Description:
> > Little patch on typo problem.
> 
> I'm confused -- your patch appears to simply remove a blank line.
> 
> The blank line it removes is not a typo, it was put there intentionally.

It is not only one blank line.

	http://lxr.linux.no/source/drivers/serial/v850e_uart.c#L52

I have remove one "^L".

Have a nice day,

	~Christophe

PS: Sorry for the noise if this patch has no sens :)


[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

[KJ] Re: [PATCH] typo patch on v850e_uart.c

[Christophe Lucas]

[-- Attachment #1: Type: text/plain, Size: 539 bytes --]

Miles Bader (miles@lsi.nec.co.jp) wrote:
> Miles Bader <snogglethorpe@gmail.com> writes:
> >> Description:
> >> Little patch on typo problem.
> >
> > I'm confused -- your patch appears to simply remove a blank line.
> >
> > The blank line it removes is not a typo, it was put there intentionally.
> 
> Oh, I see it actually removes a blank line which contains a form-feed
> character.  Same difference though:  it isn't a typo.
> 
> -Miles

Oh sorry, it is not always easy for a french man to have the right word.
Sorry :-(

	~Christophe


[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

[KJ] Re: [PATCH] typo patch on v850e_uart.c

[Miles Bader]

On 5/13/05, Christophe Lucas <clucas@rotomalug.org> wrote:
> > Oh, I see it actually removes a blank line which contains a form-feed
> > character.  Same difference though:  it isn't a typo.
> 
> Oh sorry, it is not always easy for a french man to have the right word.

Er, I guess I'm not making my point well.  It's not the description
that's the problem, it's the patch.  I put the ^L there on purpose, I
don't want it to be removed unless there's a good reason, and your
mail didn't give a good reason.

If there _is_ a good reason (e.g., "Linus declares he hates ^L and
wants them all removed"), then please send it with the patch;
otherwise, please drop this patch.

Thanks,

-Miles
-- 
Do not taunt Happy Fun Ball.

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

[KJ] Re: [PATCH] typo patch on v850e_uart.c

[Christophe Lucas]

[-- Attachment #1: Type: text/plain, Size: 823 bytes --]

Miles Bader (snogglethorpe@gmail.com) wrote:
> On 5/13/05, Christophe Lucas <clucas@rotomalug.org> wrote:
> > > Oh, I see it actually removes a blank line which contains a form-feed
> > > character.  Same difference though:  it isn't a typo.
> > 
> > Oh sorry, it is not always easy for a french man to have the right word.
> 
> Er, I guess I'm not making my point well.  It's not the description
> that's the problem, it's the patch.  I put the ^L there on purpose, I
> don't want it to be removed unless there's a good reason, and your
> mail didn't give a good reason.
> 
> If there _is_ a good reason (e.g., "Linus declares he hates ^L and
> wants them all removed"), then please send it with the patch;
> otherwise, please drop this patch.

Ok, sorry to have wasted your time. Patch dropped.

Have fun,

	~Christophe


[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors