From: Devesh Sharma <devesh.sharma-1wcpHE2jlwO1Z/+hSey0Gg@public.gmane.org>
To: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Laurent Navet
<laurent.navet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: selvin.xavier-laKkSmNT4hbQT0dZR+AlfA@public.gmane.org,
devesh.sharma-laKkSmNT4hbQT0dZR+AlfA@public.gmane.org,
mitesh.ahuja-laKkSmNT4hbQT0dZR+AlfA@public.gmane.org,
sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: RE: [PATCH] RDMA/ocrdma: remove unneeded tests
Date: Tue, 26 May 2015 21:30:03 +0530 [thread overview]
Message-ID: <fc65b86cff5dc0ca24bc90c3dab7c205@mail.gmail.com> (raw)
In-Reply-To: <1432644310.28905.95.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Although already applied, Thanks Laurent and Doug.
Acked-By: Devesh Sharma <devesh.sharma-1wcpHE2jlwO1Z/+hSey0Gg@public.gmane.org>
> -----Original Message-----
> From: Doug Ledford [mailto:dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org]
> Sent: Tuesday, May 26, 2015 6:15 PM
> To: Laurent Navet
> Cc: selvin.xavier-laKkSmNT4hbQT0dZR+AlfA@public.gmane.org; devesh.sharma-laKkSmNT4hbQT0dZR+AlfA@public.gmane.org;
> mitesh.ahuja-laKkSmNT4hbQT0dZR+AlfA@public.gmane.org; sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org; hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org;
> linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> Subject: Re: [PATCH] RDMA/ocrdma: remove unneeded tests
>
> On Thu, 2015-05-21 at 22:07 +0200, Laurent Navet wrote:
> > The same code is executed regardless status value, so these tests can
> > be removed.
> > Fix Coverity CID 1271151 and 1268788
>
> Thanks, applied for 4.2.
>
> > Signed-off-by: Laurent Navet <laurent.navet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> > ---
> > drivers/infiniband/hw/ocrdma/ocrdma_hw.c | 6 ------
> > 1 file changed, 6 deletions(-)
> >
> > diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
> > b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
> > index 0c9e959..e748090 100644
> > --- a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
> > +++ b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
> > @@ -1960,9 +1960,6 @@ static int ocrdma_mbx_reg_mr_cont(struct
> ocrdma_dev *dev,
> > upper_32_bits(hwmr->pbl_table[i + pbl_offset].pa);
> > }
> > status = ocrdma_mbx_cmd(dev, (struct ocrdma_mqe *)cmd);
> > - if (status)
> > - goto mbx_err;
> > -mbx_err:
> > kfree(cmd);
> > return status;
> > }
> > @@ -3044,9 +3041,6 @@ static int ocrdma_mbx_modify_eqd(struct
> ocrdma_dev *dev, struct ocrdma_eq *eq,
> > (eq[i].aic_obj.prev_eqd * 65)/100;
> > }
> > status = ocrdma_mbx_cmd(dev, (struct ocrdma_mqe *)cmd);
> > - if (status)
> > - goto mbx_err;
> > -mbx_err:
> > kfree(cmd);
> > return status;
> > }
>
>
> --
> Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> GPG KeyID: 0E572FDD
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Devesh Sharma <devesh.sharma@avagotech.com>
To: Doug Ledford <dledford@redhat.com>,
Laurent Navet <laurent.navet@gmail.com>
Cc: selvin.xavier@emulex.com, devesh.sharma@emulex.com,
mitesh.ahuja@emulex.com, sean.hefty@intel.com,
hal.rosenstock@gmail.com, linux-rdma@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: RE: [PATCH] RDMA/ocrdma: remove unneeded tests
Date: Tue, 26 May 2015 21:30:03 +0530 [thread overview]
Message-ID: <fc65b86cff5dc0ca24bc90c3dab7c205@mail.gmail.com> (raw)
In-Reply-To: <1432644310.28905.95.camel@redhat.com>
Although already applied, Thanks Laurent and Doug.
Acked-By: Devesh Sharma <devesh.sharma@avagotech.com>
> -----Original Message-----
> From: Doug Ledford [mailto:dledford@redhat.com]
> Sent: Tuesday, May 26, 2015 6:15 PM
> To: Laurent Navet
> Cc: selvin.xavier@emulex.com; devesh.sharma@emulex.com;
> mitesh.ahuja@emulex.com; sean.hefty@intel.com; hal.rosenstock@gmail.com;
> linux-rdma@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH] RDMA/ocrdma: remove unneeded tests
>
> On Thu, 2015-05-21 at 22:07 +0200, Laurent Navet wrote:
> > The same code is executed regardless status value, so these tests can
> > be removed.
> > Fix Coverity CID 1271151 and 1268788
>
> Thanks, applied for 4.2.
>
> > Signed-off-by: Laurent Navet <laurent.navet@gmail.com>
> > ---
> > drivers/infiniband/hw/ocrdma/ocrdma_hw.c | 6 ------
> > 1 file changed, 6 deletions(-)
> >
> > diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
> > b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
> > index 0c9e959..e748090 100644
> > --- a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
> > +++ b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
> > @@ -1960,9 +1960,6 @@ static int ocrdma_mbx_reg_mr_cont(struct
> ocrdma_dev *dev,
> > upper_32_bits(hwmr->pbl_table[i + pbl_offset].pa);
> > }
> > status = ocrdma_mbx_cmd(dev, (struct ocrdma_mqe *)cmd);
> > - if (status)
> > - goto mbx_err;
> > -mbx_err:
> > kfree(cmd);
> > return status;
> > }
> > @@ -3044,9 +3041,6 @@ static int ocrdma_mbx_modify_eqd(struct
> ocrdma_dev *dev, struct ocrdma_eq *eq,
> > (eq[i].aic_obj.prev_eqd * 65)/100;
> > }
> > status = ocrdma_mbx_cmd(dev, (struct ocrdma_mqe *)cmd);
> > - if (status)
> > - goto mbx_err;
> > -mbx_err:
> > kfree(cmd);
> > return status;
> > }
>
>
> --
> Doug Ledford <dledford@redhat.com>
> GPG KeyID: 0E572FDD
next prev parent reply other threads:[~2015-05-26 16:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-21 20:07 [PATCH] RDMA/ocrdma: remove unneeded tests Laurent Navet
2015-05-26 12:45 ` Doug Ledford
[not found] ` <1432644310.28905.95.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-05-26 16:00 ` Devesh Sharma [this message]
2015-05-26 16:00 ` Devesh Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc65b86cff5dc0ca24bc90c3dab7c205@mail.gmail.com \
--to=devesh.sharma-1wcphe2jlwo1z/+hsey0gg@public.gmane.org \
--cc=devesh.sharma-laKkSmNT4hbQT0dZR+AlfA@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=laurent.navet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mitesh.ahuja-laKkSmNT4hbQT0dZR+AlfA@public.gmane.org \
--cc=sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=selvin.xavier-laKkSmNT4hbQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.