From: Paolo Bonzini <pbonzini@redhat.com>
To: Markus Armbruster <armbru@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>
Cc: qemu-devel@nongnu.org,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Daniel P. Berrange" <berrange@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: Re: Target-dependent include path, why?
Date: Fri, 9 Dec 2022 17:48:59 +0100 [thread overview]
Message-ID: <fc83b2bb-c115-af96-ceed-c83d610a2044@redhat.com> (raw)
In-Reply-To: <87v8mlez92.fsf@pond.sub.org>
On 12/9/22 09:51, Markus Armbruster wrote:
>> Because of where [pixman] is added as a dependency in meson.build.
>
> Is it added where it is for a reason, or is it accidental?
Dependencies are usually added near the .c files that use them. That's
a bit messy of course if you have an "#include <>" in a heavily-included
QEMU header. You can consider it a way to discourage heavily-included
headers.
If you have a dependency in multiple unrelated .c files, specifying them
in multiple foo_ss.add() invocations doesn't hurt. In fact it is both
clearer and more compact, because it removes the need for "if"s.
The only dependency that you don't need to specify is glib, partly for
historical pre-Meson reasons partly because it would be everywhere. For
the others, if it makes sense to add them to multiple source sets you're
welcome to do so.
Paolo
next prev parent reply other threads:[~2022-12-09 16:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-09 5:12 Target-dependent include path, why? Markus Armbruster
2022-12-09 5:24 ` Richard Henderson
2022-12-09 7:05 ` Philippe Mathieu-Daudé
2022-12-09 8:51 ` Markus Armbruster
2022-12-09 15:02 ` Richard Henderson
2022-12-09 15:59 ` Philippe Mathieu-Daudé
2022-12-09 16:48 ` Paolo Bonzini [this message]
2022-12-09 16:52 ` Peter Maydell
2022-12-09 17:42 ` Paolo Bonzini
2022-12-09 19:53 ` Peter Maydell
2022-12-09 22:16 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc83b2bb-c115-af96-ceed-c83d610a2044@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.