* [DPU PATCH v2 0/2] Remove DPU RSC support
@ 2018-04-04 9:04 Rajesh Yadav
[not found] ` <1522832680-24490-1-git-send-email-ryadav-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-04-04 20:21 ` Sean Paul
0 siblings, 2 replies; 7+ messages in thread
From: Rajesh Yadav @ 2018-04-04 9:04 UTC (permalink / raw)
To: dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
linux-arm-msm-u79uwXL29TY76Z2rM5mHXA
Cc: robdclark-Re5JQEeQqe8AvxtiuMwx3w, seanpaul-F7+t8E8rja9g9hUCZPvPmw,
Rajesh Yadav, hoegsberg-F7+t8E8rja9g9hUCZPvPmw
MSM display controller hardware (DPU) has an inbuilt RSC block
which can control power resources and bus bandwidth voting
based on frame timing parameters w/o DPU driver intervention.
In absence of RSC HW, DPU driver controls these resources.
Downstream driver relies on RSC driver for controlling these
resources (via RSC HW block) for better power benefits.
Since, DPU driver can control these resources, removing RSC
driver support. Corresponding devicetree binding are also removed.
Details for DPU driver upstreaming:
https://lists.freedesktop.org/archives/freedreno/2018-February/001678.html
Changes in v2:
- Remove last reference to dpu_power_rsc_update
- Add DPU PATCH tag for better filtering
- Rebase on tip of for-next-staging
Rajesh Yadav (2):
dt-bindings: msm/disp: Remove DPU RSC device bindings
drm/msm: Remove RSC support from DPU driver
.../devicetree/bindings/display/msm/dpu-rsc.txt | 96 --
drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 130 +-
drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.h | 6 -
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 14 -
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h | 9 +-
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 242 +---
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h | 7 -
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h | 1 -
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_top.c | 20 +-
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_top.h | 3 -
drivers/gpu/drm/msm/dpu_dbg.c | 27 -
drivers/gpu/drm/msm/dpu_dbg.h | 10 -
drivers/gpu/drm/msm/dpu_power_handle.c | 73 +-
drivers/gpu/drm/msm/dpu_power_handle.h | 4 -
drivers/gpu/drm/msm/dpu_rsc.c | 1367 --------------------
drivers/gpu/drm/msm/dpu_rsc_hw.c | 818 ------------
drivers/gpu/drm/msm/dpu_rsc_priv.h | 191 ---
include/linux/dpu_rsc.h | 302 -----
18 files changed, 42 insertions(+), 3278 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/display/msm/dpu-rsc.txt
delete mode 100644 drivers/gpu/drm/msm/dpu_rsc.c
delete mode 100644 drivers/gpu/drm/msm/dpu_rsc_hw.c
delete mode 100644 drivers/gpu/drm/msm/dpu_rsc_priv.h
delete mode 100644 include/linux/dpu_rsc.h
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
_______________________________________________
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [DPU PATCH v2 0/2] Remove DPU RSC support
[not found] ` <1522832680-24490-1-git-send-email-ryadav-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
@ 2018-04-04 10:26 ` Daniel Vetter
[not found] ` <20180404102633.GG3881-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org>
0 siblings, 1 reply; 7+ messages in thread
From: Daniel Vetter @ 2018-04-04 10:26 UTC (permalink / raw)
To: Rajesh Yadav
Cc: linux-arm-msm-u79uwXL29TY76Z2rM5mHXA,
hoegsberg-F7+t8E8rja9g9hUCZPvPmw,
freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
On Wed, Apr 04, 2018 at 02:34:40PM +0530, Rajesh Yadav wrote:
> MSM display controller hardware (DPU) has an inbuilt RSC block
> which can control power resources and bus bandwidth voting
> based on frame timing parameters w/o DPU driver intervention.
> In absence of RSC HW, DPU driver controls these resources.
>
> Downstream driver relies on RSC driver for controlling these
> resources (via RSC HW block) for better power benefits.
>
> Since, DPU driver can control these resources, removing RSC
> driver support. Corresponding devicetree binding are also removed.
If it has benefits, why remove the support for this?
-Daniel
>
> Details for DPU driver upstreaming:
> https://lists.freedesktop.org/archives/freedreno/2018-February/001678.html
>
> Changes in v2:
> - Remove last reference to dpu_power_rsc_update
> - Add DPU PATCH tag for better filtering
> - Rebase on tip of for-next-staging
>
> Rajesh Yadav (2):
> dt-bindings: msm/disp: Remove DPU RSC device bindings
> drm/msm: Remove RSC support from DPU driver
>
> .../devicetree/bindings/display/msm/dpu-rsc.txt | 96 --
> drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 130 +-
> drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.h | 6 -
> drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 14 -
> drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h | 9 +-
> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 242 +---
> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h | 7 -
> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h | 1 -
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_top.c | 20 +-
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_top.h | 3 -
> drivers/gpu/drm/msm/dpu_dbg.c | 27 -
> drivers/gpu/drm/msm/dpu_dbg.h | 10 -
> drivers/gpu/drm/msm/dpu_power_handle.c | 73 +-
> drivers/gpu/drm/msm/dpu_power_handle.h | 4 -
> drivers/gpu/drm/msm/dpu_rsc.c | 1367 --------------------
> drivers/gpu/drm/msm/dpu_rsc_hw.c | 818 ------------
> drivers/gpu/drm/msm/dpu_rsc_priv.h | 191 ---
> include/linux/dpu_rsc.h | 302 -----
> 18 files changed, 42 insertions(+), 3278 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/display/msm/dpu-rsc.txt
> delete mode 100644 drivers/gpu/drm/msm/dpu_rsc.c
> delete mode 100644 drivers/gpu/drm/msm/dpu_rsc_hw.c
> delete mode 100644 drivers/gpu/drm/msm/dpu_rsc_priv.h
> delete mode 100644 include/linux/dpu_rsc.h
>
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [DPU PATCH v2 0/2] Remove DPU RSC support
[not found] ` <20180404102633.GG3881-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org>
@ 2018-04-04 11:23 ` ryadav-sgV2jX0FEOL9JmXXK+q4OQ
[not found] ` <9b96938a6c783fd00e55cc767592ec7e-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
0 siblings, 1 reply; 7+ messages in thread
From: ryadav-sgV2jX0FEOL9JmXXK+q4OQ @ 2018-04-04 11:23 UTC (permalink / raw)
To: Daniel Vetter
Cc: linux-arm-msm-u79uwXL29TY76Z2rM5mHXA,
hoegsberg-F7+t8E8rja9g9hUCZPvPmw,
freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW, Daniel Vetter
On 2018-04-04 15:56, Daniel Vetter wrote:
> On Wed, Apr 04, 2018 at 02:34:40PM +0530, Rajesh Yadav wrote:
>> MSM display controller hardware (DPU) has an inbuilt RSC block
>> which can control power resources and bus bandwidth voting
>> based on frame timing parameters w/o DPU driver intervention.
>> In absence of RSC HW, DPU driver controls these resources.
>>
>> Downstream driver relies on RSC driver for controlling these
>> resources (via RSC HW block) for better power benefits.
>>
>> Since, DPU driver can control these resources, removing RSC
>> driver support. Corresponding devicetree binding are also removed.
>
> If it has benefits, why remove the support for this?
> -Daniel
Currently, the dpu driver has custom implementation for power
management.
We are planning to move to runtime_pm and this change is 1st step toward
that goal.
We will re-introduce the RSC support at a later stage when all the
dependencies
are sent upstream.
Thanks,
Rajesh
>
>>
>> Details for DPU driver upstreaming:
>> https://lists.freedesktop.org/archives/freedreno/2018-February/001678.html
>>
>> Changes in v2:
>> - Remove last reference to dpu_power_rsc_update
>> - Add DPU PATCH tag for better filtering
>> - Rebase on tip of for-next-staging
>>
>> Rajesh Yadav (2):
>> dt-bindings: msm/disp: Remove DPU RSC device bindings
>> drm/msm: Remove RSC support from DPU driver
>>
>> .../devicetree/bindings/display/msm/dpu-rsc.txt | 96 --
>> drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 130 +-
>> drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.h | 6 -
>> drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 14 -
>> drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h | 9 +-
>> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 242 +---
>> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h | 7 -
>> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h | 1 -
>> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_top.c | 20 +-
>> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_top.h | 3 -
>> drivers/gpu/drm/msm/dpu_dbg.c | 27 -
>> drivers/gpu/drm/msm/dpu_dbg.h | 10 -
>> drivers/gpu/drm/msm/dpu_power_handle.c | 73 +-
>> drivers/gpu/drm/msm/dpu_power_handle.h | 4 -
>> drivers/gpu/drm/msm/dpu_rsc.c | 1367
>> --------------------
>> drivers/gpu/drm/msm/dpu_rsc_hw.c | 818
>> ------------
>> drivers/gpu/drm/msm/dpu_rsc_priv.h | 191 ---
>> include/linux/dpu_rsc.h | 302 -----
>> 18 files changed, 42 insertions(+), 3278 deletions(-)
>> delete mode 100644
>> Documentation/devicetree/bindings/display/msm/dpu-rsc.txt
>> delete mode 100644 drivers/gpu/drm/msm/dpu_rsc.c
>> delete mode 100644 drivers/gpu/drm/msm/dpu_rsc_hw.c
>> delete mode 100644 drivers/gpu/drm/msm/dpu_rsc_priv.h
>> delete mode 100644 include/linux/dpu_rsc.h
>>
>> --
>> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
>> Forum,
>> a Linux Foundation Collaborative Project
>>
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [DPU PATCH v2 0/2] Remove DPU RSC support
[not found] ` <9b96938a6c783fd00e55cc767592ec7e-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
@ 2018-04-04 12:19 ` Daniel Vetter
[not found] ` <20180404121938.GM3881-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org>
0 siblings, 1 reply; 7+ messages in thread
From: Daniel Vetter @ 2018-04-04 12:19 UTC (permalink / raw)
To: ryadav-sgV2jX0FEOL9JmXXK+q4OQ
Cc: linux-arm-msm-u79uwXL29TY76Z2rM5mHXA,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW, Daniel Vetter,
Daniel Vetter, hoegsberg-F7+t8E8rja9g9hUCZPvPmw,
freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
On Wed, Apr 04, 2018 at 04:53:51PM +0530, ryadav@codeaurora.org wrote:
> On 2018-04-04 15:56, Daniel Vetter wrote:
> > On Wed, Apr 04, 2018 at 02:34:40PM +0530, Rajesh Yadav wrote:
> > > MSM display controller hardware (DPU) has an inbuilt RSC block
> > > which can control power resources and bus bandwidth voting
> > > based on frame timing parameters w/o DPU driver intervention.
> > > In absence of RSC HW, DPU driver controls these resources.
> > >
> > > Downstream driver relies on RSC driver for controlling these
> > > resources (via RSC HW block) for better power benefits.
> > >
> > > Since, DPU driver can control these resources, removing RSC
> > > driver support. Corresponding devicetree binding are also removed.
> >
> > If it has benefits, why remove the support for this?
> > -Daniel
> Currently, the dpu driver has custom implementation for power management.
> We are planning to move to runtime_pm and this change is 1st step toward
> that goal.
> We will re-introduce the RSC support at a later stage when all the
> dependencies
> are sent upstream.
That kind of context would be really good to explain in the commit message
and cover letter.
-Daniel
>
> Thanks,
> Rajesh
> >
> > >
> > > Details for DPU driver upstreaming:
> > > https://lists.freedesktop.org/archives/freedreno/2018-February/001678.html
> > >
> > > Changes in v2:
> > > - Remove last reference to dpu_power_rsc_update
> > > - Add DPU PATCH tag for better filtering
> > > - Rebase on tip of for-next-staging
> > >
> > > Rajesh Yadav (2):
> > > dt-bindings: msm/disp: Remove DPU RSC device bindings
> > > drm/msm: Remove RSC support from DPU driver
> > >
> > > .../devicetree/bindings/display/msm/dpu-rsc.txt | 96 --
> > > drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 130 +-
> > > drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.h | 6 -
> > > drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 14 -
> > > drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h | 9 +-
> > > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 242 +---
> > > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h | 7 -
> > > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h | 1 -
> > > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_top.c | 20 +-
> > > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_top.h | 3 -
> > > drivers/gpu/drm/msm/dpu_dbg.c | 27 -
> > > drivers/gpu/drm/msm/dpu_dbg.h | 10 -
> > > drivers/gpu/drm/msm/dpu_power_handle.c | 73 +-
> > > drivers/gpu/drm/msm/dpu_power_handle.h | 4 -
> > > drivers/gpu/drm/msm/dpu_rsc.c | 1367
> > > --------------------
> > > drivers/gpu/drm/msm/dpu_rsc_hw.c | 818
> > > ------------
> > > drivers/gpu/drm/msm/dpu_rsc_priv.h | 191 ---
> > > include/linux/dpu_rsc.h | 302 -----
> > > 18 files changed, 42 insertions(+), 3278 deletions(-)
> > > delete mode 100644
> > > Documentation/devicetree/bindings/display/msm/dpu-rsc.txt
> > > delete mode 100644 drivers/gpu/drm/msm/dpu_rsc.c
> > > delete mode 100644 drivers/gpu/drm/msm/dpu_rsc_hw.c
> > > delete mode 100644 drivers/gpu/drm/msm/dpu_rsc_priv.h
> > > delete mode 100644 include/linux/dpu_rsc.h
> > >
> > > --
> > > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
> > > Forum,
> > > a Linux Foundation Collaborative Project
> > >
> > > _______________________________________________
> > > dri-devel mailing list
> > > dri-devel@lists.freedesktop.org
> > > https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [DPU PATCH v2 0/2] Remove DPU RSC support
2018-04-04 9:04 [DPU PATCH v2 0/2] Remove DPU RSC support Rajesh Yadav
[not found] ` <1522832680-24490-1-git-send-email-ryadav-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
@ 2018-04-04 20:21 ` Sean Paul
2018-04-05 4:42 ` ryadav-sgV2jX0FEOL9JmXXK+q4OQ
1 sibling, 1 reply; 7+ messages in thread
From: Sean Paul @ 2018-04-04 20:21 UTC (permalink / raw)
To: Rajesh Yadav; +Cc: linux-arm-msm, dri-devel, hoegsberg, freedreno
On Wed, Apr 04, 2018 at 02:34:40PM +0530, Rajesh Yadav wrote:
> MSM display controller hardware (DPU) has an inbuilt RSC block
> which can control power resources and bus bandwidth voting
> based on frame timing parameters w/o DPU driver intervention.
> In absence of RSC HW, DPU driver controls these resources.
>
> Downstream driver relies on RSC driver for controlling these
> resources (via RSC HW block) for better power benefits.
>
> Since, DPU driver can control these resources, removing RSC
> driver support. Corresponding devicetree binding are also removed.
>
> Details for DPU driver upstreaming:
> https://lists.freedesktop.org/archives/freedreno/2018-February/001678.html
>
> Changes in v2:
> - Remove last reference to dpu_power_rsc_update
> - Add DPU PATCH tag for better filtering
> - Rebase on tip of for-next-staging
Hi Rajesh,
Unrelated to this change, but I've noticed the threading seems off on the patch
sets you're sending. Are you sending the emails one-by-one, or specifying
--no-thread in git send-email?
Sean
>
> Rajesh Yadav (2):
> dt-bindings: msm/disp: Remove DPU RSC device bindings
> drm/msm: Remove RSC support from DPU driver
>
> .../devicetree/bindings/display/msm/dpu-rsc.txt | 96 --
> drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 130 +-
> drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.h | 6 -
> drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 14 -
> drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h | 9 +-
> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 242 +---
> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h | 7 -
> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h | 1 -
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_top.c | 20 +-
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_top.h | 3 -
> drivers/gpu/drm/msm/dpu_dbg.c | 27 -
> drivers/gpu/drm/msm/dpu_dbg.h | 10 -
> drivers/gpu/drm/msm/dpu_power_handle.c | 73 +-
> drivers/gpu/drm/msm/dpu_power_handle.h | 4 -
> drivers/gpu/drm/msm/dpu_rsc.c | 1367 --------------------
> drivers/gpu/drm/msm/dpu_rsc_hw.c | 818 ------------
> drivers/gpu/drm/msm/dpu_rsc_priv.h | 191 ---
> include/linux/dpu_rsc.h | 302 -----
> 18 files changed, 42 insertions(+), 3278 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/display/msm/dpu-rsc.txt
> delete mode 100644 drivers/gpu/drm/msm/dpu_rsc.c
> delete mode 100644 drivers/gpu/drm/msm/dpu_rsc_hw.c
> delete mode 100644 drivers/gpu/drm/msm/dpu_rsc_priv.h
> delete mode 100644 include/linux/dpu_rsc.h
>
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
--
Sean Paul, Software Engineer, Google / Chromium OS
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [DPU PATCH v2 0/2] Remove DPU RSC support
2018-04-04 20:21 ` Sean Paul
@ 2018-04-05 4:42 ` ryadav-sgV2jX0FEOL9JmXXK+q4OQ
0 siblings, 0 replies; 7+ messages in thread
From: ryadav-sgV2jX0FEOL9JmXXK+q4OQ @ 2018-04-05 4:42 UTC (permalink / raw)
To: Sean Paul
Cc: linux-arm-msm-u79uwXL29TY76Z2rM5mHXA,
robdclark-Re5JQEeQqe8AvxtiuMwx3w,
freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
hoegsberg-F7+t8E8rja9g9hUCZPvPmw,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
On 2018-04-05 01:51, Sean Paul wrote:
> On Wed, Apr 04, 2018 at 02:34:40PM +0530, Rajesh Yadav wrote:
>> MSM display controller hardware (DPU) has an inbuilt RSC block
>> which can control power resources and bus bandwidth voting
>> based on frame timing parameters w/o DPU driver intervention.
>> In absence of RSC HW, DPU driver controls these resources.
>>
>> Downstream driver relies on RSC driver for controlling these
>> resources (via RSC HW block) for better power benefits.
>>
>> Since, DPU driver can control these resources, removing RSC
>> driver support. Corresponding devicetree binding are also removed.
>>
>> Details for DPU driver upstreaming:
>> https://lists.freedesktop.org/archives/freedreno/2018-February/001678.html
>>
>> Changes in v2:
>> - Remove last reference to dpu_power_rsc_update
>> - Add DPU PATCH tag for better filtering
>> - Rebase on tip of for-next-staging
>
> Hi Rajesh,
> Unrelated to this change, but I've noticed the threading seems off on
> the patch
> sets you're sending. Are you sending the emails one-by-one, or
> specifying
> --no-thread in git send-email?
>
> Sean
Hi Sean,
I had sent the patches one by one, I'll take care of this going forward.
Thanks,
Rajesh
>
>>
>> Rajesh Yadav (2):
>> dt-bindings: msm/disp: Remove DPU RSC device bindings
>> drm/msm: Remove RSC support from DPU driver
>>
>> .../devicetree/bindings/display/msm/dpu-rsc.txt | 96 --
>> drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 130 +-
>> drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.h | 6 -
>> drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 14 -
>> drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h | 9 +-
>> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 242 +---
>> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h | 7 -
>> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h | 1 -
>> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_top.c | 20 +-
>> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_top.h | 3 -
>> drivers/gpu/drm/msm/dpu_dbg.c | 27 -
>> drivers/gpu/drm/msm/dpu_dbg.h | 10 -
>> drivers/gpu/drm/msm/dpu_power_handle.c | 73 +-
>> drivers/gpu/drm/msm/dpu_power_handle.h | 4 -
>> drivers/gpu/drm/msm/dpu_rsc.c | 1367
>> --------------------
>> drivers/gpu/drm/msm/dpu_rsc_hw.c | 818
>> ------------
>> drivers/gpu/drm/msm/dpu_rsc_priv.h | 191 ---
>> include/linux/dpu_rsc.h | 302 -----
>> 18 files changed, 42 insertions(+), 3278 deletions(-)
>> delete mode 100644
>> Documentation/devicetree/bindings/display/msm/dpu-rsc.txt
>> delete mode 100644 drivers/gpu/drm/msm/dpu_rsc.c
>> delete mode 100644 drivers/gpu/drm/msm/dpu_rsc_hw.c
>> delete mode 100644 drivers/gpu/drm/msm/dpu_rsc_priv.h
>> delete mode 100644 include/linux/dpu_rsc.h
>>
>> --
>> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
>> Forum,
>> a Linux Foundation Collaborative Project
>>
_______________________________________________
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [DPU PATCH v2 0/2] Remove DPU RSC support
[not found] ` <20180404121938.GM3881-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org>
@ 2018-04-05 4:45 ` ryadav-sgV2jX0FEOL9JmXXK+q4OQ
0 siblings, 0 replies; 7+ messages in thread
From: ryadav-sgV2jX0FEOL9JmXXK+q4OQ @ 2018-04-05 4:45 UTC (permalink / raw)
To: Daniel Vetter
Cc: linux-arm-msm-u79uwXL29TY76Z2rM5mHXA,
hoegsberg-F7+t8E8rja9g9hUCZPvPmw,
freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW, Daniel Vetter
On 2018-04-04 17:49, Daniel Vetter wrote:
> On Wed, Apr 04, 2018 at 04:53:51PM +0530, ryadav@codeaurora.org wrote:
>> On 2018-04-04 15:56, Daniel Vetter wrote:
>> > On Wed, Apr 04, 2018 at 02:34:40PM +0530, Rajesh Yadav wrote:
>> > > MSM display controller hardware (DPU) has an inbuilt RSC block
>> > > which can control power resources and bus bandwidth voting
>> > > based on frame timing parameters w/o DPU driver intervention.
>> > > In absence of RSC HW, DPU driver controls these resources.
>> > >
>> > > Downstream driver relies on RSC driver for controlling these
>> > > resources (via RSC HW block) for better power benefits.
>> > >
>> > > Since, DPU driver can control these resources, removing RSC
>> > > driver support. Corresponding devicetree binding are also removed.
>> >
>> > If it has benefits, why remove the support for this?
>> > -Daniel
>> Currently, the dpu driver has custom implementation for power
>> management.
>> We are planning to move to runtime_pm and this change is 1st step
>> toward
>> that goal.
>> We will re-introduce the RSC support at a later stage when all the
>> dependencies
>> are sent upstream.
>
> That kind of context would be really good to explain in the commit
> message
> and cover letter.
> -Daniel
Noted. Will take care of it going forward.
Thanks,
Rajesh
>
>>
>> Thanks,
>> Rajesh
>> >
>> > >
>> > > Details for DPU driver upstreaming:
>> > > https://lists.freedesktop.org/archives/freedreno/2018-February/001678.html
>> > >
>> > > Changes in v2:
>> > > - Remove last reference to dpu_power_rsc_update
>> > > - Add DPU PATCH tag for better filtering
>> > > - Rebase on tip of for-next-staging
>> > >
>> > > Rajesh Yadav (2):
>> > > dt-bindings: msm/disp: Remove DPU RSC device bindings
>> > > drm/msm: Remove RSC support from DPU driver
>> > >
>> > > .../devicetree/bindings/display/msm/dpu-rsc.txt | 96 --
>> > > drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 130 +-
>> > > drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.h | 6 -
>> > > drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 14 -
>> > > drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h | 9 +-
>> > > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 242 +---
>> > > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h | 7 -
>> > > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h | 1 -
>> > > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_top.c | 20 +-
>> > > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_top.h | 3 -
>> > > drivers/gpu/drm/msm/dpu_dbg.c | 27 -
>> > > drivers/gpu/drm/msm/dpu_dbg.h | 10 -
>> > > drivers/gpu/drm/msm/dpu_power_handle.c | 73 +-
>> > > drivers/gpu/drm/msm/dpu_power_handle.h | 4 -
>> > > drivers/gpu/drm/msm/dpu_rsc.c | 1367
>> > > --------------------
>> > > drivers/gpu/drm/msm/dpu_rsc_hw.c | 818
>> > > ------------
>> > > drivers/gpu/drm/msm/dpu_rsc_priv.h | 191 ---
>> > > include/linux/dpu_rsc.h | 302 -----
>> > > 18 files changed, 42 insertions(+), 3278 deletions(-)
>> > > delete mode 100644
>> > > Documentation/devicetree/bindings/display/msm/dpu-rsc.txt
>> > > delete mode 100644 drivers/gpu/drm/msm/dpu_rsc.c
>> > > delete mode 100644 drivers/gpu/drm/msm/dpu_rsc_hw.c
>> > > delete mode 100644 drivers/gpu/drm/msm/dpu_rsc_priv.h
>> > > delete mode 100644 include/linux/dpu_rsc.h
>> > >
>> > > --
>> > > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
>> > > Forum,
>> > > a Linux Foundation Collaborative Project
>> > >
>> > > _______________________________________________
>> > > dri-devel mailing list
>> > > dri-devel@lists.freedesktop.org
>> > > https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-04-05 4:45 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-04-04 9:04 [DPU PATCH v2 0/2] Remove DPU RSC support Rajesh Yadav
[not found] ` <1522832680-24490-1-git-send-email-ryadav-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-04-04 10:26 ` Daniel Vetter
[not found] ` <20180404102633.GG3881-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org>
2018-04-04 11:23 ` ryadav-sgV2jX0FEOL9JmXXK+q4OQ
[not found] ` <9b96938a6c783fd00e55cc767592ec7e-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-04-04 12:19 ` Daniel Vetter
[not found] ` <20180404121938.GM3881-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org>
2018-04-05 4:45 ` ryadav-sgV2jX0FEOL9JmXXK+q4OQ
2018-04-04 20:21 ` Sean Paul
2018-04-05 4:42 ` ryadav-sgV2jX0FEOL9JmXXK+q4OQ
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.