Re: [PATCH platform-next v8 4/7] platform: mellanox: Cosmetic changes to improve code style

["Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2188 bytes --]

On Sat, 12 Apr 2025, Vadim Pasternak wrote:

> Replace in 'for' loop - /i >= 0 ; i--/i >= 0 ;i--/.

Space is in the wrong place in the replace part.

> Replace in 'while' loop - /(--i >= 0)/(--i)/.
> 
> Signed-off-by: Vadim Pasternak <vadimp@nvidia.com>

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

-- 
 i.

> ---
> v5->v6
> Comments pointed out by Ilpo:
> - Fix 'while' loop in erro flow.
> ---
>  drivers/platform/mellanox/mlx-platform.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/platform/mellanox/mlx-platform.c b/drivers/platform/mellanox/mlx-platform.c
> index 29d938265676..4c7ff22117a6 100644
> --- a/drivers/platform/mellanox/mlx-platform.c
> +++ b/drivers/platform/mellanox/mlx-platform.c
> @@ -7807,7 +7807,7 @@ static int mlxplat_platdevs_init(struct mlxplat_priv *priv)
>  	while (i--)
>  		platform_device_unregister(priv->pdev_dpu[i]);
>  fail_platform_wd_register:
> -	while (--i >= 0)
> +	while (i--)
>  		platform_device_unregister(priv->pdev_wd[i]);
>  fail_platform_fan_register:
>  	if (mlxplat_regs_io)
> @@ -7828,7 +7828,7 @@ static void mlxplat_platdevs_exit(struct mlxplat_priv *priv)
>  
>  	for (i = MLXPLAT_CPLD_DPU_MAX_DEVS - 1; i >= 0; i--)
>  		platform_device_unregister(priv->pdev_dpu[i]);
> -	for (i = MLXPLAT_CPLD_WD_MAX_DEVS - 1; i >= 0 ; i--)
> +	for (i = MLXPLAT_CPLD_WD_MAX_DEVS - 1; i >= 0; i--)
>  		platform_device_unregister(priv->pdev_wd[i]);
>  	if (priv->pdev_fan)
>  		platform_device_unregister(priv->pdev_fan);
> @@ -7873,7 +7873,7 @@ static int mlxplat_i2c_mux_topology_init(struct mlxplat_priv *priv)
>  	return mlxplat_i2c_mux_complition_notify(priv, NULL, NULL);
>  
>  fail_platform_mux_register:
> -	while (--i >= 0)
> +	while (i--)
>  		platform_device_unregister(priv->pdev_mux[i]);
>  	return err;
>  }
> @@ -7882,7 +7882,7 @@ static void mlxplat_i2c_mux_topology_exit(struct mlxplat_priv *priv)
>  {
>  	int i;
>  
> -	for (i = mlxplat_mux_num - 1; i >= 0 ; i--) {
> +	for (i = mlxplat_mux_num - 1; i >= 0; i--) {
>  		if (priv->pdev_mux[i])
>  			platform_device_unregister(priv->pdev_mux[i]);
>  	}
>