[PATCH 0/2] target/riscv: Include missing headers in '*internals.h'

[PATCH 0/2] target/riscv: Include missing headers in '*internals.h'

[Philippe Mathieu-Daudé]

2 trivial RISC-V oriented patches extracted from a bigger
series which refactor include/exec/ headers.

Philippe Mathieu-Daudé (2):
  target/riscv: Include missing headers in 'vector_internals.h'
  target/riscv: Include missing headers in 'internals.h'

 target/riscv/internals.h        | 3 +++
 target/riscv/vector_internals.h | 1 +
 2 files changed, 4 insertions(+)

-- 
2.45.2

[PATCH 1/2] target/riscv: Include missing headers in 'vector_internals.h'

[Philippe Mathieu-Daudé]

Rather than relying on implicit includes, explicit them,
in order to avoid when refactoring unrelated headers:

  target/riscv/vector_internals.h:36:12: error: call to undeclared function 'FIELD_EX32'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     36 |     return FIELD_EX32(simd_data(desc), VDATA, NF);
        |            ^

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 target/riscv/vector_internals.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/target/riscv/vector_internals.h b/target/riscv/vector_internals.h
index 9e1e15b5750..a11cc8366dc 100644
--- a/target/riscv/vector_internals.h
+++ b/target/riscv/vector_internals.h
@@ -20,6 +20,7 @@
 #define TARGET_RISCV_VECTOR_INTERNALS_H
 
 #include "qemu/bitops.h"
+#include "hw/registerfields.h"
 #include "cpu.h"
 #include "tcg/tcg-gvec-desc.h"
 #include "internals.h"
-- 
2.45.2

Re: [PATCH 1/2] target/riscv: Include missing headers in 'vector_internals.h'

[Daniel Henrique Barboza]

On 12/3/24 5:08 PM, Philippe Mathieu-Daudé wrote:
> Rather than relying on implicit includes, explicit them,
> in order to avoid when refactoring unrelated headers:
> 
>    target/riscv/vector_internals.h:36:12: error: call to undeclared function 'FIELD_EX32'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
>       36 |     return FIELD_EX32(simd_data(desc), VDATA, NF);
>          |            ^
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---

Reviewed-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>

>   target/riscv/vector_internals.h | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/target/riscv/vector_internals.h b/target/riscv/vector_internals.h
> index 9e1e15b5750..a11cc8366dc 100644
> --- a/target/riscv/vector_internals.h
> +++ b/target/riscv/vector_internals.h
> @@ -20,6 +20,7 @@
>   #define TARGET_RISCV_VECTOR_INTERNALS_H
>   
>   #include "qemu/bitops.h"
> +#include "hw/registerfields.h"
>   #include "cpu.h"
>   #include "tcg/tcg-gvec-desc.h"
>   #include "internals.h"

Re: [PATCH 1/2] target/riscv: Include missing headers in 'vector_internals.h'

[Alistair Francis]

On Wed, Dec 4, 2024 at 5:09 AM Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
>
> Rather than relying on implicit includes, explicit them,
> in order to avoid when refactoring unrelated headers:
>
>   target/riscv/vector_internals.h:36:12: error: call to undeclared function 'FIELD_EX32'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
>      36 |     return FIELD_EX32(simd_data(desc), VDATA, NF);
>         |            ^
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Reviewed-by: Alistair Francis <alistair.francis@wdc.com>

Alistair

> ---
>  target/riscv/vector_internals.h | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/target/riscv/vector_internals.h b/target/riscv/vector_internals.h
> index 9e1e15b5750..a11cc8366dc 100644
> --- a/target/riscv/vector_internals.h
> +++ b/target/riscv/vector_internals.h
> @@ -20,6 +20,7 @@
>  #define TARGET_RISCV_VECTOR_INTERNALS_H
>
>  #include "qemu/bitops.h"
> +#include "hw/registerfields.h"
>  #include "cpu.h"
>  #include "tcg/tcg-gvec-desc.h"
>  #include "internals.h"
> --
> 2.45.2
>
>

[PATCH 2/2] target/riscv: Include missing headers in 'internals.h'

[Philippe Mathieu-Daudé]

Rather than relying on implicit includes, explicit them,
in order to avoid when refactoring unrelated headers:

  target/riscv/internals.h:49:15: error: use of undeclared identifier 'PRV_S'
     49 |         ret = PRV_S;
        |               ^
  target/riscv/internals.h:93:9: error: call to undeclared function 'env_archcpu'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     93 |     if (env_archcpu(env)->cfg.ext_zfinx) {
        |         ^
  target/riscv/internals.h:101:15: error: unknown type name 'float32'; did you mean 'float'?
    101 | static inline float32 check_nanbox_s(CPURISCVState *env, uint64_t f)
        |               ^~~~~~~
        |               float

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 target/riscv/internals.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/target/riscv/internals.h b/target/riscv/internals.h
index ddbdee885bc..76934eaa7b5 100644
--- a/target/riscv/internals.h
+++ b/target/riscv/internals.h
@@ -19,7 +19,10 @@
 #ifndef RISCV_CPU_INTERNALS_H
 #define RISCV_CPU_INTERNALS_H
 
+#include "exec/cpu-common.h"
 #include "hw/registerfields.h"
+#include "fpu/softfloat-types.h"
+#include "target/riscv/cpu_bits.h"
 
 /*
  * The current MMU Modes are:
-- 
2.45.2

Re: [PATCH 2/2] target/riscv: Include missing headers in 'internals.h'

[Daniel Henrique Barboza]

On 12/3/24 5:08 PM, Philippe Mathieu-Daudé wrote:
> Rather than relying on implicit includes, explicit them,
> in order to avoid when refactoring unrelated headers:
> 
>    target/riscv/internals.h:49:15: error: use of undeclared identifier 'PRV_S'
>       49 |         ret = PRV_S;
>          |               ^
>    target/riscv/internals.h:93:9: error: call to undeclared function 'env_archcpu'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
>       93 |     if (env_archcpu(env)->cfg.ext_zfinx) {
>          |         ^
>    target/riscv/internals.h:101:15: error: unknown type name 'float32'; did you mean 'float'?
>      101 | static inline float32 check_nanbox_s(CPURISCVState *env, uint64_t f)
>          |               ^~~~~~~
>          |               float
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---

Reviewed-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>

>   target/riscv/internals.h | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/target/riscv/internals.h b/target/riscv/internals.h
> index ddbdee885bc..76934eaa7b5 100644
> --- a/target/riscv/internals.h
> +++ b/target/riscv/internals.h
> @@ -19,7 +19,10 @@
>   #ifndef RISCV_CPU_INTERNALS_H
>   #define RISCV_CPU_INTERNALS_H
>   
> +#include "exec/cpu-common.h"
>   #include "hw/registerfields.h"
> +#include "fpu/softfloat-types.h"
> +#include "target/riscv/cpu_bits.h"
>   
>   /*
>    * The current MMU Modes are:

Re: [PATCH 2/2] target/riscv: Include missing headers in 'internals.h'

[Alistair Francis]

On Wed, Dec 4, 2024 at 5:09 AM Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
>
> Rather than relying on implicit includes, explicit them,
> in order to avoid when refactoring unrelated headers:
>
>   target/riscv/internals.h:49:15: error: use of undeclared identifier 'PRV_S'
>      49 |         ret = PRV_S;
>         |               ^
>   target/riscv/internals.h:93:9: error: call to undeclared function 'env_archcpu'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
>      93 |     if (env_archcpu(env)->cfg.ext_zfinx) {
>         |         ^
>   target/riscv/internals.h:101:15: error: unknown type name 'float32'; did you mean 'float'?
>     101 | static inline float32 check_nanbox_s(CPURISCVState *env, uint64_t f)
>         |               ^~~~~~~
>         |               float
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Reviewed-by: Alistair Francis <alistair.francis@wdc.com>

Alistair

> ---
>  target/riscv/internals.h | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/target/riscv/internals.h b/target/riscv/internals.h
> index ddbdee885bc..76934eaa7b5 100644
> --- a/target/riscv/internals.h
> +++ b/target/riscv/internals.h
> @@ -19,7 +19,10 @@
>  #ifndef RISCV_CPU_INTERNALS_H
>  #define RISCV_CPU_INTERNALS_H
>
> +#include "exec/cpu-common.h"
>  #include "hw/registerfields.h"
> +#include "fpu/softfloat-types.h"
> +#include "target/riscv/cpu_bits.h"
>
>  /*
>   * The current MMU Modes are:
> --
> 2.45.2
>
>

Re: [PATCH 0/2] target/riscv: Include missing headers in '*internals.h'

[Alistair Francis]

On Wed, Dec 4, 2024 at 5:09 AM Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
>
> 2 trivial RISC-V oriented patches extracted from a bigger
> series which refactor include/exec/ headers.
>
> Philippe Mathieu-Daudé (2):
>   target/riscv: Include missing headers in 'vector_internals.h'
>   target/riscv: Include missing headers in 'internals.h'

Thanks!

Applied to riscv-to-apply.next

Alistair

>
>  target/riscv/internals.h        | 3 +++
>  target/riscv/vector_internals.h | 1 +
>  2 files changed, 4 insertions(+)
>
> --
> 2.45.2
>
>